All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: gustavo.sousa@intel.com, "Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH v2 4/4] drm/i915/display: Set C10_VDR_CTRL_MSGBUS_ACCESS before phy reg read
Date: Tue, 22 Jul 2025 13:13:17 +0300	[thread overview]
Message-ID: <20250722101317.1728499-5-jouni.hogander@intel.com> (raw)
In-Reply-To: <20250722101317.1728499-1-jouni.hogander@intel.com>

According to C10 VDR Register programming sequence we need set
C10_VDR_CTRL_MSGBUS_ACCESS before accessing PHY internal registers from
MsgBus.

Fixes: 9dc619680de4 ("drm/i915/display: Add function to configure LFPS sending")
Suggested-by: Gustavo Sousa <gustavo.sousa@intel.com>
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/i915/display/intel_cx0_phy.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
index a203937d66db..886eff874cb7 100644
--- a/drivers/gpu/drm/i915/display/intel_cx0_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
@@ -3258,6 +3258,11 @@ void intel_lnl_mac_transmit_lfps(struct intel_encoder *encoder,
 		if (!(owned_lane_mask & lane_mask))
 			continue;
 
+		if (intel_encoder_is_c10phy(encoder))
+			intel_cx0_rmw(encoder, lane_mask, PHY_C10_VDR_CONTROL(1),
+				      0, C10_VDR_CTRL_MSGBUS_ACCESS,
+				      MB_WRITE_COMMITTED);
+
 		intel_cx0_rmw(encoder, lane_mask, PHY_CMN1_CONTROL(tx, 0),
 			      CONTROL0_MAC_TRANSMIT_LFPS,
 			      CONTROL0_MAC_TRANSMIT_LFPS, MB_WRITE_COMMITTED);
-- 
2.43.0


  parent reply	other threads:[~2025-07-22 10:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-22 10:13 [PATCH v2 0/4] PHY LFPS sending configuration fixes Jouni Högander
2025-07-22 10:13 ` [PATCH v2 1/4] drm/i915/display: Write PHY_CMN1_CONTROL only when using AUXLess ALPM Jouni Högander
2025-07-22 11:57   ` Gustavo Sousa
2025-07-22 10:13 ` [PATCH v2 2/4] drm/i915/display: Avoid unnecessarily calling intel_cx0_get_owned_lane_mask Jouni Högander
2025-07-22 11:58   ` Gustavo Sousa
2025-07-22 10:13 ` [PATCH v2 3/4] drm/i915/display: Ensure phy is accessible on lfps configuration Jouni Högander
2025-07-22 12:02   ` Gustavo Sousa
2025-07-22 10:13 ` Jouni Högander [this message]
2025-07-22 12:07   ` [PATCH v2 4/4] drm/i915/display: Set C10_VDR_CTRL_MSGBUS_ACCESS before phy reg read Gustavo Sousa
2025-07-22 12:14     ` Hogander, Jouni
2025-07-22 10:31 ` ✓ CI.KUnit: success for PHY LFPS sending configuration fixes Patchwork
2025-07-22 11:07 ` ✓ i915.CI.BAT: " Patchwork
2025-07-22 11:53 ` ✓ Xe.CI.BAT: " Patchwork
2025-07-22 13:32 ` ✗ Xe.CI.Full: failure " Patchwork
2025-07-22 14:09 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250722101317.1728499-5-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=gustavo.sousa@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.