Re: [PATCH v8 09/11] cxl/test: Setup target_map for cxl_test decoder initialization

[Jonathan Cameron <Jonathan.Cameron@huawei.com>]

On Thu, 14 Aug 2025 15:21:49 -0700
Dave Jiang <dave.jiang@intel.com> wrote:

> cxl_test uses mock functions for decoder enumation. Add initialization
> of the cxld->target_map[] for cxl_test based decoders in the mock
> functions.
> 
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Looks fine.

Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>

> ---
>  tools/testing/cxl/test/cxl.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
> index 0ef2a8ec1fab..2d50193d10fe 100644
> --- a/tools/testing/cxl/test/cxl.c
> +++ b/tools/testing/cxl/test/cxl.c
> @@ -818,15 +818,21 @@ static void mock_init_hdm_decoder(struct cxl_decoder *cxld)
>  		 */
>  		if (WARN_ON(!dev))
>  			continue;
> +
>  		cxlsd = to_cxl_switch_decoder(dev);
>  		if (i == 0) {
>  			/* put cxl_mem.4 second in the decode order */
> -			if (pdev->id == 4)
> +			if (pdev->id == 4) {
>  				cxlsd->target[1] = dport;
> -			else
> +				cxld->target_map[1] = dport->port_id;
> +			} else {
>  				cxlsd->target[0] = dport;
> -		} else
> +				cxld->target_map[0] = dport->port_id;
> +			}
> +		} else {
>  			cxlsd->target[0] = dport;
> +			cxld->target_map[0] = dport->port_id;
> +		}
>  		cxld = &cxlsd->cxld;
>  		cxld->target_type = CXL_DECODER_HOSTONLYMEM;
>  		cxld->flags = CXL_DECODER_F_ENABLE;