* Re: [PATCH 2/7] arm64: dts: allwinner: a523: add third usb2 phy
@ 2025-08-17 14:59 kernel test robot
0 siblings, 0 replies; 7+ messages in thread
From: kernel test robot @ 2025-08-17 14:59 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp
::::::
:::::: Manual check reason: "dtcheck: binding changes may go via different trees"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250816084700.569524-3-iuncuim@gmail.com>
References: <20250816084700.569524-3-iuncuim@gmail.com>
TO: iuncuim <iuncuim@gmail.com>
TO: Rob Herring <robh@kernel.org>
TO: Krzysztof Kozlowski <krzk@kernel.org>
TO: Conor Dooley <conor+dt@kernel.org>
TO: "Chen-Yu Tsai" <wens@csie.org>
TO: Jernej Skrabec <jernej.skrabec@gmail.com>
TO: Samuel Holland <samuel@sholland.org>
TO: Andre Przywara <andre.przywara@arm.com>
TO: Michael Turquette <mturquette@baylibre.com>
TO: Stephen Boyd <sboyd@kernel.org>
TO: Vinod Koul <vkoul@kernel.org>
TO: Kishon Vijay Abraham I <kishon@kernel.org>
TO: Philipp Zabel <p.zabel@pengutronix.de>
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: linux-arm-kernel@lists.infradead.org
CC: linux-phy@lists.infradead.org
CC: linux-clk@vger.kernel.org
CC: linux-sunxi@lists.linux.dev
Hi iuncuim,
kernel test robot noticed the following build warnings:
[auto build test WARNING on sunxi/sunxi/for-next]
[also build test WARNING on clk/clk-next krzk/for-next krzk-dt/for-next linus/master v6.17-rc1 next-20250815]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/iuncuim/clk-sunxi-ng-a523-add-missing-usb-related-clocks/20250816-165044
base: https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git sunxi/for-next
patch link: https://lore.kernel.org/r/20250816084700.569524-3-iuncuim%40gmail.com
patch subject: [PATCH 2/7] arm64: dts: allwinner: a523: add third usb2 phy
:::::: branch date: 30 hours ago
:::::: commit date: 30 hours ago
config: arm64-randconfig-051-20250817 (https://download.01.org/0day-ci/archive/20250817/202508172218.ZXHddmGw-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 93d24b6b7b148c47a2fa228a4ef31524fa1d9f3f)
dtschema version: 2025.6.2.dev4+g8f79ddd
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250817/202508172218.ZXHddmGw-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202508172218.ZXHddmGw-lkp@intel.com/
dtcheck warnings: (new ones prefixed by >>)
arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi:105.6-698.4: Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name
>> arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): clock-names: ['usb0_phy', 'usb1_phy', 'usb2_phy'] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): clocks: [[5], [5], [2, 179]] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): compatible: 'oneOf' conditional failed, one must be fixed:
['allwinner,sun55i-a523-usb-phy'] is too short
'allwinner,sun55i-a523-usb-phy' is not one of ['allwinner,sun20i-d1-usb-phy', 'allwinner,sun50i-a64-usb-phy']
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reg: [[68158464, 256], [68163584, 256], [69208064, 256], [81788928, 256]] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reg-names: ['phy_ctrl', 'pmu0', 'pmu1', 'pmu2'] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reset-names: ['usb0_reset', 'usb1_reset', 'usb2_reset'] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): resets: [[2, 49], [2, 50], [2, 56]] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
--
arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi:105.6-698.4: Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name
>> arch/arm64/boot/dts/allwinner/sun55i-h728-x96qpro+.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): clock-names: ['usb0_phy', 'usb1_phy', 'usb2_phy'] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-h728-x96qpro+.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): clocks: [[5], [5], [2, 179]] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-h728-x96qpro+.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): compatible: 'oneOf' conditional failed, one must be fixed:
['allwinner,sun55i-a523-usb-phy'] is too short
'allwinner,sun55i-a523-usb-phy' is not one of ['allwinner,sun20i-d1-usb-phy', 'allwinner,sun50i-a64-usb-phy']
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-h728-x96qpro+.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reg: [[68158464, 256], [68163584, 256], [69208064, 256], [81788928, 256]] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-h728-x96qpro+.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reg-names: ['phy_ctrl', 'pmu0', 'pmu1', 'pmu2'] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-h728-x96qpro+.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reset-names: ['usb0_reset', 'usb1_reset', 'usb2_reset'] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-h728-x96qpro+.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): resets: [[2, 49], [2, 50], [2, 56]] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
--
arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi:105.6-698.4: Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name
>> arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): clock-names: ['usb0_phy', 'usb1_phy', 'usb2_phy'] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): clocks: [[5], [5], [2, 179]] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): compatible: 'oneOf' conditional failed, one must be fixed:
['allwinner,sun55i-a523-usb-phy'] is too short
'allwinner,sun55i-a523-usb-phy' is not one of ['allwinner,sun20i-d1-usb-phy', 'allwinner,sun50i-a64-usb-phy']
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reg: [[68158464, 256], [68163584, 256], [69208064, 256], [81788928, 256]] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reg-names: ['phy_ctrl', 'pmu0', 'pmu1', 'pmu2'] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reset-names: ['usb0_reset', 'usb1_reset', 'usb2_reset'] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): resets: [[2, 49], [2, 50], [2, 56]] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
--
arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi:105.6-698.4: Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name
>> arch/arm64/boot/dts/allwinner/sun55i-t527-orangepi-4a.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): clock-names: ['usb0_phy', 'usb1_phy', 'usb2_phy'] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-t527-orangepi-4a.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): clocks: [[5], [5], [2, 179]] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-t527-orangepi-4a.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): compatible: 'oneOf' conditional failed, one must be fixed:
['allwinner,sun55i-a523-usb-phy'] is too short
'allwinner,sun55i-a523-usb-phy' is not one of ['allwinner,sun20i-d1-usb-phy', 'allwinner,sun50i-a64-usb-phy']
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-t527-orangepi-4a.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reg: [[68158464, 256], [68163584, 256], [69208064, 256], [81788928, 256]] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-t527-orangepi-4a.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reg-names: ['phy_ctrl', 'pmu0', 'pmu1', 'pmu2'] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-t527-orangepi-4a.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): reset-names: ['usb0_reset', 'usb1_reset', 'usb2_reset'] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
>> arch/arm64/boot/dts/allwinner/sun55i-t527-orangepi-4a.dtb: phy@4100400 (allwinner,sun55i-a523-usb-phy): resets: [[2, 49], [2, 50], [2, 56]] is too long
from schema $id: http://devicetree.org/schemas/phy/allwinner,sun50i-a64-usb-phy.yaml#
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 0/7] arm64: allwinner: a523: add USB3.0 support
@ 2025-08-16 8:46 iuncuim
2025-08-16 8:46 ` iuncuim
0 siblings, 1 reply; 7+ messages in thread
From: iuncuim @ 2025-08-16 8:46 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Andre Przywara, Michael Turquette,
Stephen Boyd, Vinod Koul, Kishon Vijay Abraham I, Philipp Zabel
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-phy, linux-clk,
linux-sunxi
From: Mikhail Kalashnikov <iuncuim@gmail.com>
This series is a draft and does not include patches for dt-bindings.
The first series is necessary for testing on other devices and
initiating discussion.
This series of patches adds USB 3.0 functionality for the
A523/A527/H728/T527 processor.Most of the code is derived from the BSP,
as the datasheet does not fully describe this feature.
I have verified functionality on two of my boards, walnutpi 2b (t527)
and x96qproplus (h728). When testing usb3.0 on x96qproplus, I get
reconnections of my nvme, it looks like the port does not provide enough
current to work. I have encountered similar complaints from users of the
device on Android. In the case of walnutpi, there is no such problem.
Based on 6.17-rc1
Mikhail Kalashnikov (7):
clk: sunxi-ng: a523: add missing usb related clocks
arm64: dts: allwinner: a523: add third usb2 phy
phy: sun4i-usb: a523: add support for the USB2 PHY
phy: allwinner: a523: add USB3/PCIe PHY driver
arm64: dts: allwinner: a523: add USB3.0 phy node
arm64: dts: allwinner: a523: add DWC3 USB3.0 node
arm64: dts: allwinner: a523: activate USB3 for all boards
.../arm64/boot/dts/allwinner/sun55i-a523.dtsi | 52 +++-
.../dts/allwinner/sun55i-a527-cubie-a5e.dts | 8 +
.../dts/allwinner/sun55i-h728-x96qpro+.dts | 8 +
.../dts/allwinner/sun55i-t527-avaota-a1.dts | 8 +
drivers/clk/sunxi-ng/ccu-sun55i-a523.c | 32 +++
drivers/clk/sunxi-ng/ccu-sun55i-a523.h | 2 +-
drivers/phy/allwinner/Kconfig | 9 +
drivers/phy/allwinner/Makefile | 1 +
drivers/phy/allwinner/phy-sun4i-usb.c | 10 +
drivers/phy/allwinner/phy-sun55i-usb3-pcie.c | 267 ++++++++++++++++++
include/dt-bindings/clock/sun55i-a523-ccu.h | 4 +
11 files changed, 392 insertions(+), 9 deletions(-)
create mode 100644 drivers/phy/allwinner/phy-sun55i-usb3-pcie.c
--
2.50.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/7] arm64: dts: allwinner: a523: add third usb2 phy
2025-08-16 8:46 [PATCH 0/7] arm64: allwinner: a523: add USB3.0 support iuncuim
@ 2025-08-16 8:46 ` iuncuim
0 siblings, 0 replies; 7+ messages in thread
From: iuncuim @ 2025-08-16 8:46 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Andre Przywara, Michael Turquette,
Stephen Boyd, Vinod Koul, Kishon Vijay Abraham I, Philipp Zabel
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-phy, linux-clk,
linux-sunxi
From: Mikhail Kalashnikov <iuncuim@gmail.com>
It seems that there are actually three usb2 phys in the processor, which
makes it incompatible with D1.
The third phy is used together with USB3/PCIe combophy with DWC3
controller. In the BSP code, the third PHY requires a separate glue
driver, but it seems that it is not needed.
According to the BSP code, the third phy does not have a reset line; the
only reset is declared in the DWC3 node, but none of this is documented.
Since sun4i-usb-phy driver requires a reset, I added RST_BUS_3 here.
Signed-off-by: Mikhail Kalashnikov <iuncuim@gmail.com>
---
.../arm64/boot/dts/allwinner/sun55i-a523.dtsi | 21 ++++++++++++-------
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
index 6b6f2296b..e4ed4fa82 100644
--- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
@@ -503,22 +503,27 @@ usb_otg: usb@4100000 {
};
usbphy: phy@4100400 {
- compatible = "allwinner,sun55i-a523-usb-phy",
- "allwinner,sun20i-d1-usb-phy";
+ compatible = "allwinner,sun55i-a523-usb-phy";
reg = <0x4100400 0x100>,
<0x4101800 0x100>,
- <0x4200800 0x100>;
+ <0x4200800 0x100>,
+ <0x4e00000 0x100>;
reg-names = "phy_ctrl",
"pmu0",
- "pmu1";
+ "pmu1",
+ "pmu2";
clocks = <&osc24M>,
- <&osc24M>;
+ <&osc24M>,
+ <&ccu CLK_USB2>;
clock-names = "usb0_phy",
- "usb1_phy";
+ "usb1_phy",
+ "usb2_phy";
resets = <&ccu RST_USB_PHY0>,
- <&ccu RST_USB_PHY1>;
+ <&ccu RST_USB_PHY1>,
+ <&ccu RST_BUS_3>;
reset-names = "usb0_reset",
- "usb1_reset";
+ "usb1_reset",
+ "usb2_reset";
status = "disabled";
#phy-cells = <1>;
};
--
2.50.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/7] arm64: dts: allwinner: a523: add third usb2 phy
@ 2025-08-16 8:46 ` iuncuim
0 siblings, 0 replies; 7+ messages in thread
From: iuncuim @ 2025-08-16 8:46 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Andre Przywara, Michael Turquette,
Stephen Boyd, Vinod Koul, Kishon Vijay Abraham I, Philipp Zabel
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-phy, linux-clk,
linux-sunxi
From: Mikhail Kalashnikov <iuncuim@gmail.com>
It seems that there are actually three usb2 phys in the processor, which
makes it incompatible with D1.
The third phy is used together with USB3/PCIe combophy with DWC3
controller. In the BSP code, the third PHY requires a separate glue
driver, but it seems that it is not needed.
According to the BSP code, the third phy does not have a reset line; the
only reset is declared in the DWC3 node, but none of this is documented.
Since sun4i-usb-phy driver requires a reset, I added RST_BUS_3 here.
Signed-off-by: Mikhail Kalashnikov <iuncuim@gmail.com>
---
.../arm64/boot/dts/allwinner/sun55i-a523.dtsi | 21 ++++++++++++-------
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
index 6b6f2296b..e4ed4fa82 100644
--- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
@@ -503,22 +503,27 @@ usb_otg: usb@4100000 {
};
usbphy: phy@4100400 {
- compatible = "allwinner,sun55i-a523-usb-phy",
- "allwinner,sun20i-d1-usb-phy";
+ compatible = "allwinner,sun55i-a523-usb-phy";
reg = <0x4100400 0x100>,
<0x4101800 0x100>,
- <0x4200800 0x100>;
+ <0x4200800 0x100>,
+ <0x4e00000 0x100>;
reg-names = "phy_ctrl",
"pmu0",
- "pmu1";
+ "pmu1",
+ "pmu2";
clocks = <&osc24M>,
- <&osc24M>;
+ <&osc24M>,
+ <&ccu CLK_USB2>;
clock-names = "usb0_phy",
- "usb1_phy";
+ "usb1_phy",
+ "usb2_phy";
resets = <&ccu RST_USB_PHY0>,
- <&ccu RST_USB_PHY1>;
+ <&ccu RST_USB_PHY1>,
+ <&ccu RST_BUS_3>;
reset-names = "usb0_reset",
- "usb1_reset";
+ "usb1_reset",
+ "usb2_reset";
status = "disabled";
#phy-cells = <1>;
};
--
2.50.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/7] arm64: dts: allwinner: a523: add third usb2 phy
2025-08-16 8:46 ` iuncuim
@ 2025-08-16 9:31 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-16 9:31 UTC (permalink / raw)
To: iuncuim, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Andre Przywara,
Michael Turquette, Stephen Boyd, Vinod Koul,
Kishon Vijay Abraham I, Philipp Zabel
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-phy, linux-clk,
linux-sunxi
On 16/08/2025 10:46, iuncuim wrote:
> From: Mikhail Kalashnikov <iuncuim@gmail.com>
>
> It seems that there are actually three usb2 phys in the processor, which
> makes it incompatible with D1.
> The third phy is used together with USB3/PCIe combophy with DWC3
> controller. In the BSP code, the third PHY requires a separate glue
> driver, but it seems that it is not needed.
> According to the BSP code, the third phy does not have a reset line; the
> only reset is declared in the DWC3 node, but none of this is documented.
> Since sun4i-usb-phy driver requires a reset, I added RST_BUS_3 here.
>
> Signed-off-by: Mikhail Kalashnikov <iuncuim@gmail.com>
> ---
> .../arm64/boot/dts/allwinner/sun55i-a523.dtsi | 21 ++++++++++++-------
> 1 file changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> index 6b6f2296b..e4ed4fa82 100644
> --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> @@ -503,22 +503,27 @@ usb_otg: usb@4100000 {
> };
>
> usbphy: phy@4100400 {
> - compatible = "allwinner,sun55i-a523-usb-phy",
> - "allwinner,sun20i-d1-usb-phy";
> + compatible = "allwinner,sun55i-a523-usb-phy";
That's potential break of all users. Also, having third phy (so
additional piece) is not making things incompatible.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 2/7] arm64: dts: allwinner: a523: add third usb2 phy
@ 2025-08-16 9:31 ` Krzysztof Kozlowski
0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-16 9:31 UTC (permalink / raw)
To: iuncuim, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Andre Przywara,
Michael Turquette, Stephen Boyd, Vinod Koul,
Kishon Vijay Abraham I, Philipp Zabel
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-phy, linux-clk,
linux-sunxi
On 16/08/2025 10:46, iuncuim wrote:
> From: Mikhail Kalashnikov <iuncuim@gmail.com>
>
> It seems that there are actually three usb2 phys in the processor, which
> makes it incompatible with D1.
> The third phy is used together with USB3/PCIe combophy with DWC3
> controller. In the BSP code, the third PHY requires a separate glue
> driver, but it seems that it is not needed.
> According to the BSP code, the third phy does not have a reset line; the
> only reset is declared in the DWC3 node, but none of this is documented.
> Since sun4i-usb-phy driver requires a reset, I added RST_BUS_3 here.
>
> Signed-off-by: Mikhail Kalashnikov <iuncuim@gmail.com>
> ---
> .../arm64/boot/dts/allwinner/sun55i-a523.dtsi | 21 ++++++++++++-------
> 1 file changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> index 6b6f2296b..e4ed4fa82 100644
> --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> @@ -503,22 +503,27 @@ usb_otg: usb@4100000 {
> };
>
> usbphy: phy@4100400 {
> - compatible = "allwinner,sun55i-a523-usb-phy",
> - "allwinner,sun20i-d1-usb-phy";
> + compatible = "allwinner,sun55i-a523-usb-phy";
That's potential break of all users. Also, having third phy (so
additional piece) is not making things incompatible.
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 2/7] arm64: dts: allwinner: a523: add third usb2 phy
2025-08-16 9:31 ` Krzysztof Kozlowski
@ 2025-08-16 13:38 ` Andre Przywara
-1 siblings, 0 replies; 7+ messages in thread
From: Andre Przywara @ 2025-08-16 13:38 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: iuncuim, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Michael Turquette,
Stephen Boyd, Vinod Koul, Kishon Vijay Abraham I, Philipp Zabel,
devicetree, linux-kernel, linux-arm-kernel, linux-phy, linux-clk,
linux-sunxi
On Sat, 16 Aug 2025 11:31:12 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 16/08/2025 10:46, iuncuim wrote:
> > From: Mikhail Kalashnikov <iuncuim@gmail.com>
> >
> > It seems that there are actually three usb2 phys in the processor, which
> > makes it incompatible with D1.
> > The third phy is used together with USB3/PCIe combophy with DWC3
> > controller. In the BSP code, the third PHY requires a separate glue
> > driver, but it seems that it is not needed.
> > According to the BSP code, the third phy does not have a reset line; the
> > only reset is declared in the DWC3 node, but none of this is documented.
> > Since sun4i-usb-phy driver requires a reset, I added RST_BUS_3 here.
> >
> > Signed-off-by: Mikhail Kalashnikov <iuncuim@gmail.com>
> > ---
> > .../arm64/boot/dts/allwinner/sun55i-a523.dtsi | 21 ++++++++++++-------
> > 1 file changed, 13 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> > index 6b6f2296b..e4ed4fa82 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> > @@ -503,22 +503,27 @@ usb_otg: usb@4100000 {
> > };
> >
> > usbphy: phy@4100400 {
> > - compatible = "allwinner,sun55i-a523-usb-phy",
> > - "allwinner,sun20i-d1-usb-phy";
> > + compatible = "allwinner,sun55i-a523-usb-phy";
>
>
> That's potential break of all users. Also, having third phy (so
> additional piece) is not making things incompatible.
Yes, we would want to keep the fallback, to allow newer DTs working on
older kernel. As the Linux driver is implemented right now, it's not
fully compatible, since it ties the number of PHYs to the compatible
string - but that's a Linux implementation choice, not something really
related to the binding. And as I replied on the driver patch, that
breaks anyway, and I think we can change it there to preserve
compatibility, and make everyone happy: newer DTs on older kernels,
older DTs on newer kernels, and all working within the kernel's
capability.
Oh, and it looks like there are whitespace issues in the patch ...
Cheers,
Andre
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 2/7] arm64: dts: allwinner: a523: add third usb2 phy
@ 2025-08-16 13:38 ` Andre Przywara
0 siblings, 0 replies; 7+ messages in thread
From: Andre Przywara @ 2025-08-16 13:38 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: iuncuim, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Michael Turquette,
Stephen Boyd, Vinod Koul, Kishon Vijay Abraham I, Philipp Zabel,
devicetree, linux-kernel, linux-arm-kernel, linux-phy, linux-clk,
linux-sunxi
On Sat, 16 Aug 2025 11:31:12 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 16/08/2025 10:46, iuncuim wrote:
> > From: Mikhail Kalashnikov <iuncuim@gmail.com>
> >
> > It seems that there are actually three usb2 phys in the processor, which
> > makes it incompatible with D1.
> > The third phy is used together with USB3/PCIe combophy with DWC3
> > controller. In the BSP code, the third PHY requires a separate glue
> > driver, but it seems that it is not needed.
> > According to the BSP code, the third phy does not have a reset line; the
> > only reset is declared in the DWC3 node, but none of this is documented.
> > Since sun4i-usb-phy driver requires a reset, I added RST_BUS_3 here.
> >
> > Signed-off-by: Mikhail Kalashnikov <iuncuim@gmail.com>
> > ---
> > .../arm64/boot/dts/allwinner/sun55i-a523.dtsi | 21 ++++++++++++-------
> > 1 file changed, 13 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> > index 6b6f2296b..e4ed4fa82 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> > @@ -503,22 +503,27 @@ usb_otg: usb@4100000 {
> > };
> >
> > usbphy: phy@4100400 {
> > - compatible = "allwinner,sun55i-a523-usb-phy",
> > - "allwinner,sun20i-d1-usb-phy";
> > + compatible = "allwinner,sun55i-a523-usb-phy";
>
>
> That's potential break of all users. Also, having third phy (so
> additional piece) is not making things incompatible.
Yes, we would want to keep the fallback, to allow newer DTs working on
older kernel. As the Linux driver is implemented right now, it's not
fully compatible, since it ties the number of PHYs to the compatible
string - but that's a Linux implementation choice, not something really
related to the binding. And as I replied on the driver patch, that
breaks anyway, and I think we can change it there to preserve
compatibility, and make everyone happy: newer DTs on older kernels,
older DTs on newer kernels, and all working within the kernel's
capability.
Oh, and it looks like there are whitespace issues in the patch ...
Cheers,
Andre
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-08-17 14:59 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-17 14:59 [PATCH 2/7] arm64: dts: allwinner: a523: add third usb2 phy kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2025-08-16 8:46 [PATCH 0/7] arm64: allwinner: a523: add USB3.0 support iuncuim
2025-08-16 8:46 ` [PATCH 2/7] arm64: dts: allwinner: a523: add third usb2 phy iuncuim
2025-08-16 8:46 ` iuncuim
2025-08-16 9:31 ` Krzysztof Kozlowski
2025-08-16 9:31 ` Krzysztof Kozlowski
2025-08-16 13:38 ` Andre Przywara
2025-08-16 13:38 ` Andre Przywara
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.