All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Hwang <leon.hwang@linux.dev>
To: bpf@vger.kernel.org
Cc: ast@kernel.org, andrii@kernel.org, daniel@iogearbox.net,
	martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org,
	yonghong.song@linux.dev, yatsenko@meta.com, puranjay@kernel.org,
	davidzalman.101@gmail.com, cheick.traore@foss.st.com,
	chen.dylane@linux.dev, mika.westerberg@linux.intel.com,
	ameryhung@gmail.com, menglong8.dong@gmail.com,
	leon.hwang@linux.dev, kernel-patches-bot@fb.com
Subject: [PATCH bpf-next v2 0/3] bpf: Allow union argument in trampoline based programs
Date: Tue, 16 Sep 2025 23:52:08 +0800	[thread overview]
Message-ID: <20250916155211.61083-1-leon.hwang@linux.dev> (raw)

While tracing 'release_pages' with bpfsnoop[0], the verifier reports:

The function release_pages arg0 type UNION is unsupported.

However, it should be acceptable to trace functions that have 'union'
arguments.

This patch set enables such support in the verifier by allowing 'union'
as a valid argument type.

Changes:
v1 -> v2:
* Add 16B 'union' argument support in x86_64 trampoline.
* Update selftests using bpf_testmod.
* Add test case about 16-bytes 'union' argument.
* Address comments from Alexei:
  * Study the patch set about 'struct' argument support.
  * Update selftests to cover more cases.
v1: https://lore.kernel.org/bpf/20250905133226.84675-1-leon.hwang@linux.dev/

Links:
[0] https://github.com/bpfsnoop/bpfsnoop

Leon Hwang (3):
  bpf: Allow union argument in trampoline based programs
  bpf, x64: Add union argument support in trampoline
  selftests/bpf: Add union argument tests using fexit programs

 arch/x86/net/bpf_jit_comp.c                   |  2 +-
 include/linux/bpf.h                           |  3 ++
 include/linux/btf.h                           |  5 +++
 kernel/bpf/btf.c                              |  8 +++--
 .../selftests/bpf/prog_tests/tracing_struct.c | 29 ++++++++++++++++
 .../selftests/bpf/progs/tracing_struct.c      | 33 +++++++++++++++++++
 .../selftests/bpf/test_kmods/bpf_testmod.c    | 31 +++++++++++++++++
 7 files changed, 107 insertions(+), 4 deletions(-)

--
2.50.1


             reply	other threads:[~2025-09-16 15:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-16 15:52 Leon Hwang [this message]
2025-09-16 15:52 ` [PATCH bpf-next v2 1/3] bpf: Allow union argument in trampoline based programs Leon Hwang
2025-09-16 21:35   ` Amery Hung
2025-09-17 12:40     ` Leon Hwang
2025-09-17 18:13       ` Alexei Starovoitov
2025-09-18  1:47         ` Leon Hwang
2025-09-16 15:52 ` [PATCH bpf-next v2 2/3] bpf, x64: Add union argument support in trampoline Leon Hwang
2025-09-16 15:52 ` [PATCH bpf-next v2 3/3] selftests/bpf: Add union argument tests using fexit programs Leon Hwang
2025-09-18 16:09   ` Tao Chen
2025-09-19  1:47     ` Leon Hwang
2025-09-19  1:53       ` Alexei Starovoitov
2025-09-19  2:01         ` Leon Hwang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250916155211.61083-1-leon.hwang@linux.dev \
    --to=leon.hwang@linux.dev \
    --cc=ameryhung@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=cheick.traore@foss.st.com \
    --cc=chen.dylane@linux.dev \
    --cc=daniel@iogearbox.net \
    --cc=davidzalman.101@gmail.com \
    --cc=eddyz87@gmail.com \
    --cc=kernel-patches-bot@fb.com \
    --cc=martin.lau@linux.dev \
    --cc=menglong8.dong@gmail.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=puranjay@kernel.org \
    --cc=song@kernel.org \
    --cc=yatsenko@meta.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.