All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Hwang <leon.hwang@linux.dev>
To: bpf@vger.kernel.org
Cc: ast@kernel.org, andrii@kernel.org, daniel@iogearbox.net,
	martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org,
	yonghong.song@linux.dev, yatsenko@meta.com, puranjay@kernel.org,
	davidzalman.101@gmail.com, cheick.traore@foss.st.com,
	chen.dylane@linux.dev, mika.westerberg@linux.intel.com,
	ameryhung@gmail.com, menglong8.dong@gmail.com,
	leon.hwang@linux.dev, kernel-patches-bot@fb.com
Subject: [PATCH bpf-next v2 2/3] bpf, x64: Add union argument support in trampoline
Date: Tue, 16 Sep 2025 23:52:10 +0800	[thread overview]
Message-ID: <20250916155211.61083-3-leon.hwang@linux.dev> (raw)
In-Reply-To: <20250916155211.61083-1-leon.hwang@linux.dev>

As verifier allows functions with 'union' argument can be traced, add
'union' arguments support in trampoline if the argument's size is in
range '(8, 16]'.

Signed-off-by: Leon Hwang <leon.hwang@linux.dev>
---
 arch/x86/net/bpf_jit_comp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/net/bpf_jit_comp.c b/arch/x86/net/bpf_jit_comp.c
index 8d34a9400a5e4..f30d3455ecf07 100644
--- a/arch/x86/net/bpf_jit_comp.c
+++ b/arch/x86/net/bpf_jit_comp.c
@@ -3164,7 +3164,7 @@ static int __arch_prepare_bpf_trampoline(struct bpf_tramp_image *im, void *rw_im
 
 	/* extra registers for struct arguments */
 	for (i = 0; i < m->nr_args; i++) {
-		if (m->arg_flags[i] & BTF_FMODEL_STRUCT_ARG)
+		if (m->arg_flags[i] & (BTF_FMODEL_STRUCT_ARG | BTF_FMODEL_UNION_ARG))
 			nr_regs += (m->arg_size[i] + 7) / 8 - 1;
 	}
 
-- 
2.50.1


  parent reply	other threads:[~2025-09-16 15:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-16 15:52 [PATCH bpf-next v2 0/3] bpf: Allow union argument in trampoline based programs Leon Hwang
2025-09-16 15:52 ` [PATCH bpf-next v2 1/3] " Leon Hwang
2025-09-16 21:35   ` Amery Hung
2025-09-17 12:40     ` Leon Hwang
2025-09-17 18:13       ` Alexei Starovoitov
2025-09-18  1:47         ` Leon Hwang
2025-09-16 15:52 ` Leon Hwang [this message]
2025-09-16 15:52 ` [PATCH bpf-next v2 3/3] selftests/bpf: Add union argument tests using fexit programs Leon Hwang
2025-09-18 16:09   ` Tao Chen
2025-09-19  1:47     ` Leon Hwang
2025-09-19  1:53       ` Alexei Starovoitov
2025-09-19  2:01         ` Leon Hwang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250916155211.61083-3-leon.hwang@linux.dev \
    --to=leon.hwang@linux.dev \
    --cc=ameryhung@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=cheick.traore@foss.st.com \
    --cc=chen.dylane@linux.dev \
    --cc=daniel@iogearbox.net \
    --cc=davidzalman.101@gmail.com \
    --cc=eddyz87@gmail.com \
    --cc=kernel-patches-bot@fb.com \
    --cc=martin.lau@linux.dev \
    --cc=menglong8.dong@gmail.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=puranjay@kernel.org \
    --cc=song@kernel.org \
    --cc=yatsenko@meta.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.