Re: [PATCH bpf-next v2 3/3] selftests/bpf: Add union argument tests using fexit programs

[Leon Hwang <leon.hwang@linux.dev>]

On 19/9/25 09:53, Alexei Starovoitov wrote:
> On Thu, Sep 18, 2025 at 6:47 PM Leon Hwang <leon.hwang@linux.dev> wrote:
>>
>>
>>
>> On 19/9/25 00:09, Tao Chen wrote:
>>> 在 2025/9/16 23:52, Leon Hwang 写道:
>>>> By referencing
>>>> commit 1642a3945e223 ("selftests/bpf: Add struct argument tests with
>>>> fentry/fexit programs."),
>>>> test the following cases for union argument support:
>>>>
>>>
>>> Can we use ‘commit 1642a3945e22’ with 12 chars, maybe it's minor nit
>>> anyways or not.
>>>
>> Thank you for pointing this out.
>>
>> I’ll update my script to generate the commit information in the proper
>> format.
> 
> Since you're going to respin please rewrite the whole commit log
> in both patches.
> There is no need to talk about patch 1642a3945e223 at all.
> It doesn't matter what you used to get inspiration from.
> Also don't say things like:
> 
> cd tools/testing/selftests/bpf
> ./test_progs -t tracing_struct/union_args
> 472/3   tracing_struct/union_args:OK
> 472     tracing_struct:OK
> Summary: 1/1 PASSED, 0 SKIPPED, 0 FAILED
> 
> of course they suppose to pass. Above is not useful in the commit log.
> 
> Instead describe what the test is for and what it's doing.
> > Similar in patch 1 trim bpftrace output.
> Only mention the relevant parts. The command line and the error.
> Things like:
> 
> processed 0 insns (limit 1000000) max_states_per_insn 0 total_states 0
> peak_states 0 mark_read 0
> 
> are not useful.

Got it.

I’ll respin with updated commit logs:

* Patch #1: trim bpftrace output to only include the relevant command
  line and error.
* Patch #2: drop references to commit 1642a3945e223 and test output, and
  instead describe what the test is for and what it does.

Thanks,
Leon