Re: [PATCH v3 06/10] iio: dac: ad5446: Separate I2C/SPI into different drivers

[Jonathan Cameron <jonathan.cameron@huawei.com>]

On Tue, 04 Nov 2025 07:44:13 +0000
Nuno Sá <noname.nuno@gmail.com> wrote:

> On Mon, 2025-11-03 at 21:30 +0200, Andy Shevchenko wrote:
> > On Mon, Nov 03, 2025 at 10:40:20AM +0000, Nuno Sá wrote:  
> > > On Mon, 2025-11-03 at 09:39 +0200, Andy Shevchenko wrote:  
> > > > On Sat, Nov 01, 2025 at 04:46:12PM +0000, Jonathan Cameron wrote:  
> > > > > On Fri, 31 Oct 2025 12:31:27 +0000
> > > > > Nuno Sá via B4 Relay <devnull+nuno.sa.analog.com@kernel.org> wrote:  
> > 
> > ...
> >   
> > > > > > +	st->d16 = cpu_to_be16(val);  
> > > > > 
> > > > > Should have an include for this.  Probably
> > > > > 
> > > > > linux/byteorder/generic.h
> > > > > though the kernel (and iio) has a random mix of that and
> > > > > asm/byteorder.h  
> > > 
> > > Yeah, I did tried linux/byteorder/generic.h but it fails to compile if it's the
> > > first 
> > > thing we include so I did not wanted to go that way :)  
> > > > Can somebody go and fix all of them to be asm/byteorder.h? Yeah, it might need
> > > > some thinking as in some _rare_ cases the author might imply the explicit
> > > > choice of the algo in use. But then it might be problematic on some
> > > > architectures
> > > > as well...
> > > >   
> > > > > Hmm. linux/unaligned.h is using asm/byteorder.h so maybe that's the better
> > > > > choice  
> > > > 
> > > > Yes.  
> > > 
> > > Hmm, so linux/unaligned.h or asm/byteorder.h? For the spi version I do have
> > > linux/unaligned.h beacuse we use some APIs but for i2c there's no use on
> > > unaligned so
> > > it feels a bit odd to include it?  
> > 
> > Maybe I misread what Jonathan said, but I meant that asm/byteorder.h is a
> > better choice over other *byteorder*.h variants.  
> 
> Ack. I was the one that got confused with your reply so I wanted to confirm
> before v4.
> 
I only meant that it was probably right choice in unaligned.h to use asm/byteorder.h
So definitely agree fixing all cases up to use asm/byteorder.h is the way
to go based on Andy's feedback.

unaligned.h is only appropriate if the calls made are all the unaligned variants.
If it's a mix, should include that and asm/byteorder.h

Thanks,

Jonathan

> - Nuno Sá
>