Re: [PATCH v3 04/10] iio: dac: ad5446: Move to single chip_info structures

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Fri, Oct 31, 2025 at 12:31:25PM +0000, Nuno Sá via B4 Relay wrote:
> 
> Do not use an array with an enum id kind of thing. Use the more
> maintainable chip_info variable per chip.
> 
> Adapt the probe functions to use the proper helpers (for SPI and I2c).
> Note that in a following patch we'll also add the chip_info variables to
> the of_device_id tables. Hence already use the helpers that internally use
> device_get_match_data().

...

> +static const struct ad5446_chip_info ad5310_chip_info = {
> +	.channel = AD5446_CHANNEL_POWERDOWN(10, 16, 2),
> +	.write = ad5446_write,
> +};
> +
> +static const struct ad5446_chip_info ad5320_chip_info = {
> +	.channel = AD5446_CHANNEL_POWERDOWN(12, 16, 0),
> +	.write = ad5446_write,
> +};
> +
> +static const struct ad5446_chip_info ad5444_chip_info = {
> +	.channel = AD5446_CHANNEL(12, 16, 2),
> +	.write = ad5446_write,
> +};
> +
> +static const struct ad5446_chip_info ad5446_chip_info = {
> +	.channel = AD5446_CHANNEL(14, 16, 0),
> +	.write = ad5446_write,
> +};
> +
> +static const struct ad5446_chip_info ad5450_chip_info = {
> +	.channel = AD5446_CHANNEL(8, 16, 6),
> +	.write = ad5446_write,
> +};
> +
> +static const struct ad5446_chip_info ad5451_chip_info = {
> +	.channel = AD5446_CHANNEL(10, 16, 4),
> +	.write = ad5446_write,
> +};
> +
> +static const struct ad5446_chip_info ad5541a_chip_info = {
> +	.channel = AD5446_CHANNEL(16, 16, 0),
> +	.write = ad5446_write,
> +};
> +
> +static const struct ad5446_chip_info ad5512a_chip_info = {
> +	.channel = AD5446_CHANNEL(12, 16, 4),
> +	.write = ad5446_write,
> +};
> +
> +static const struct ad5446_chip_info ad5553_chip_info = {
> +	.channel = AD5446_CHANNEL(14, 16, 0),
> +	.write = ad5446_write,
> +};

> +static const struct ad5446_chip_info ad5600_chip_info = {
> +	.channel = AD5446_CHANNEL(16, 16, 0),
> +	.write = ad5446_write,
> +};

Seems same as ad5541a_chip_info(). Do we need duplicates _now_?

> +static const struct ad5446_chip_info ad5601_chip_info = {
> +	.channel = AD5446_CHANNEL_POWERDOWN(8, 16, 6),
> +	.write = ad5446_write,
> +};
> +
> +static const struct ad5446_chip_info ad5611_chip_info = {
> +	.channel = AD5446_CHANNEL_POWERDOWN(10, 16, 4),
> +	.write = ad5446_write,
> +};
> +
> +static const struct ad5446_chip_info ad5621_chip_info = {
> +	.channel = AD5446_CHANNEL_POWERDOWN(12, 16, 2),
> +	.write = ad5446_write,
> +};
> +
> +static const struct ad5446_chip_info ad5641_chip_info = {
> +	.channel = AD5446_CHANNEL_POWERDOWN(14, 16, 0),
> +	.write = ad5446_write,
> +};
> +
> +static const struct ad5446_chip_info ad5620_2500_chip_info = {
> +	.channel = AD5446_CHANNEL_POWERDOWN(12, 16, 2),
> +	.int_vref_mv = 2500,
> +	.write = ad5446_write,
> +};
> +
> +static const struct ad5446_chip_info ad5620_1250_chip_info = {
> +	.channel = AD5446_CHANNEL_POWERDOWN(12, 16, 2),
> +	.int_vref_mv = 1250,
> +	.write = ad5446_write,
> +};
> +
> +static const struct ad5446_chip_info ad5640_2500_chip_info = {
> +	.channel = AD5446_CHANNEL_POWERDOWN(14, 16, 0),
> +	.int_vref_mv = 2500,
> +	.write = ad5446_write,
> +};
> +
> +static const struct ad5446_chip_info ad5640_1250_chip_info = {
> +	.channel = AD5446_CHANNEL_POWERDOWN(14, 16, 0),
> +	.int_vref_mv = 1250,
> +	.write = ad5446_write,
> +};
> +
> +static const struct ad5446_chip_info ad5660_2500_chip_info = {
> +	.channel = AD5446_CHANNEL_POWERDOWN(16, 16, 0),
> +	.int_vref_mv = 2500,
> +	.write = ad5660_write,
> +};
> +
> +static const struct ad5446_chip_info ad5660_1250_chip_info = {
> +	.channel = AD5446_CHANNEL_POWERDOWN(16, 16, 0),
> +	.int_vref_mv = 1250,
> +	.write = ad5660_write,
> +};
> +
> +static const struct ad5446_chip_info ad5662_chip_info = {
> +	.channel = AD5446_CHANNEL_POWERDOWN(16, 16, 0),
> +	.write = ad5660_write,
>  };

-- 
With Best Regards,
Andy Shevchenko