Re: [PATCH v3 03/10] iio: dac: ad5446: Don't ignore missing regulator

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Fri, Oct 31, 2025 at 03:40:11PM +0200, Andy Shevchenko wrote:
> On Fri, Oct 31, 2025 at 12:31:24PM +0000, Nuno Sá via B4 Relay wrote:

...

> >  	if (ret < 0 && ret != -ENODEV)
> >  		return ret;
> 
> Not exactly for your patch, but the whole chain can be refactored as
> 
> >  	if (ret == -ENODEV) {
> > -		if (chip_info->int_vref_mv)
> > -			st->vref_mv = chip_info->int_vref_mv;
> > -		else
> > -			dev_warn(dev, "reference voltage unspecified\n");
> > +		if (!chip_info->int_vref_mv)
> > +			return dev_err_probe(dev, ret,
> > +					     "reference voltage unspecified\n");
> > +
> > +		st->vref_mv = chip_info->int_vref_mv;
> >  	} else {
> >  		st->vref_mv = ret / 1000;
> >  	}
> 
> (assuming ret is never 0)
> 
> 	if (ret == -ENODEV)
> 		...
> 	else if (ret)
> 		return ret;
> 	else
> 		...
> 	if (!st->vref_mv)
> 		return dev_err_probe(dev, ret, "reference voltage unspecified\n");

Yeah, we still need to alter ret here... Whatever, just give a thought on it, maybe
you can up with something more beautiful.

-- 
With Best Regards,
Andy Shevchenko