* Re: [PATCH 1/4] xfs: rename xfs_linux.h to xfs_platform.h
@ 2025-12-19 17:18 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2025-12-19 17:18 UTC (permalink / raw)
To: oe-kbuild
::::::
:::::: Manual check reason: "high confidence checkpatch report"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20251219054202.1773441-2-hch@lst.de>
References: <20251219054202.1773441-2-hch@lst.de>
TO: Christoph Hellwig <hch@lst.de>
TO: Carlos Maiolino <cem@kernel.org>
Hi Christoph,
kernel test robot noticed the following build warnings:
[auto build test WARNING on xfs-linux/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Christoph-Hellwig/xfs-include-global-headers-first-in-xfs_platform-h/20251219-144249
base: https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git for-next
patch link: https://lore.kernel.org/r/20251219054202.1773441-2-hch%40lst.de
patch subject: [PATCH 1/4] xfs: rename xfs_linux.h to xfs_platform.h
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago
reproduce: (https://download.01.org/0day-ci/archive/20251219/202512191801.CYuDRRG2-lkp@intel.com/reproduce)
# many are suggestions rather than must-fix
WARNING:REPEATED_WORD: Possible repeated word: 'including'
#6:
Rename xfs_linux.h to prepare for including including it directly
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH v2] rename xfs.h
@ 2025-12-19 5:41 Christoph Hellwig
2025-12-19 5:41 ` [PATCH 1/4] xfs: rename xfs_linux.h to xfs_platform.h Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2025-12-19 5:41 UTC (permalink / raw)
To: Carlos Maiolino
Cc: Andrey Albershteyn, Darrick J . Wong, Dave Chinner, Eric Sandeen,
linux-xfs
Hi all,
currently one of the biggest difference between the kernel and xfsprogs
for the shared libxfs files is that the all kernel source files first
include xfs.h, while in xfsprogs they first include libxfs_priv.h. The
reason for that is that there is a public xfs.h header in xfsprogs that
causes a namespace collision.
This patch renames xfs.h in the kernel tree to xfs_plaform.h, a name that
is still available in xfsprogs. Any other name fitting that criteria
should work just as well, I'm open to better suggestion if there are
any.
Diffstat:
b/fs/xfs/libxfs/xfs_ag.c | 2 -
b/fs/xfs/libxfs/xfs_ag_resv.c | 2 -
b/fs/xfs/libxfs/xfs_alloc.c | 2 -
b/fs/xfs/libxfs/xfs_alloc_btree.c | 2 -
b/fs/xfs/libxfs/xfs_attr.c | 2 -
b/fs/xfs/libxfs/xfs_attr_leaf.c | 2 -
b/fs/xfs/libxfs/xfs_attr_remote.c | 2 -
b/fs/xfs/libxfs/xfs_bit.c | 2 -
b/fs/xfs/libxfs/xfs_bmap.c | 2 -
b/fs/xfs/libxfs/xfs_bmap_btree.c | 2 -
b/fs/xfs/libxfs/xfs_btree.c | 2 -
b/fs/xfs/libxfs/xfs_btree_mem.c | 2 -
b/fs/xfs/libxfs/xfs_btree_staging.c | 2 -
b/fs/xfs/libxfs/xfs_da_btree.c | 2 -
b/fs/xfs/libxfs/xfs_defer.c | 2 -
b/fs/xfs/libxfs/xfs_dir2.c | 2 -
b/fs/xfs/libxfs/xfs_dir2_block.c | 2 -
b/fs/xfs/libxfs/xfs_dir2_data.c | 2 -
b/fs/xfs/libxfs/xfs_dir2_leaf.c | 2 -
b/fs/xfs/libxfs/xfs_dir2_node.c | 2 -
b/fs/xfs/libxfs/xfs_dir2_sf.c | 2 -
b/fs/xfs/libxfs/xfs_dquot_buf.c | 2 -
b/fs/xfs/libxfs/xfs_exchmaps.c | 2 -
b/fs/xfs/libxfs/xfs_group.c | 2 -
b/fs/xfs/libxfs/xfs_ialloc.c | 2 -
b/fs/xfs/libxfs/xfs_ialloc_btree.c | 2 -
b/fs/xfs/libxfs/xfs_iext_tree.c | 2 -
b/fs/xfs/libxfs/xfs_inode_buf.c | 2 -
b/fs/xfs/libxfs/xfs_inode_fork.c | 2 -
b/fs/xfs/libxfs/xfs_inode_util.c | 2 -
b/fs/xfs/libxfs/xfs_log_rlimit.c | 2 -
b/fs/xfs/libxfs/xfs_metadir.c | 2 -
b/fs/xfs/libxfs/xfs_metafile.c | 2 -
b/fs/xfs/libxfs/xfs_parent.c | 2 -
b/fs/xfs/libxfs/xfs_refcount.c | 2 -
b/fs/xfs/libxfs/xfs_refcount_btree.c | 2 -
b/fs/xfs/libxfs/xfs_rmap.c | 2 -
b/fs/xfs/libxfs/xfs_rmap_btree.c | 2 -
b/fs/xfs/libxfs/xfs_rtbitmap.c | 2 -
b/fs/xfs/libxfs/xfs_rtgroup.c | 2 -
b/fs/xfs/libxfs/xfs_rtrefcount_btree.c | 2 -
b/fs/xfs/libxfs/xfs_rtrmap_btree.c | 2 -
b/fs/xfs/libxfs/xfs_sb.c | 2 -
b/fs/xfs/libxfs/xfs_symlink_remote.c | 2 -
b/fs/xfs/libxfs/xfs_trans_inode.c | 2 -
b/fs/xfs/libxfs/xfs_trans_resv.c | 2 -
b/fs/xfs/libxfs/xfs_trans_space.c | 2 -
b/fs/xfs/libxfs/xfs_types.c | 2 -
b/fs/xfs/libxfs/xfs_zones.c | 2 -
b/fs/xfs/scrub/agb_bitmap.c | 2 -
b/fs/xfs/scrub/agheader.c | 2 -
b/fs/xfs/scrub/agheader_repair.c | 2 -
b/fs/xfs/scrub/alloc.c | 2 -
b/fs/xfs/scrub/alloc_repair.c | 2 -
b/fs/xfs/scrub/attr.c | 2 -
b/fs/xfs/scrub/attr_repair.c | 2 -
b/fs/xfs/scrub/bitmap.c | 2 -
b/fs/xfs/scrub/bmap.c | 2 -
b/fs/xfs/scrub/bmap_repair.c | 2 -
b/fs/xfs/scrub/btree.c | 2 -
b/fs/xfs/scrub/common.c | 2 -
b/fs/xfs/scrub/cow_repair.c | 2 -
b/fs/xfs/scrub/dabtree.c | 2 -
b/fs/xfs/scrub/dir.c | 2 -
b/fs/xfs/scrub/dir_repair.c | 2 -
b/fs/xfs/scrub/dirtree.c | 2 -
b/fs/xfs/scrub/dirtree_repair.c | 2 -
b/fs/xfs/scrub/dqiterate.c | 2 -
b/fs/xfs/scrub/findparent.c | 2 -
b/fs/xfs/scrub/fscounters.c | 2 -
b/fs/xfs/scrub/fscounters_repair.c | 2 -
b/fs/xfs/scrub/health.c | 2 -
b/fs/xfs/scrub/ialloc.c | 2 -
b/fs/xfs/scrub/ialloc_repair.c | 2 -
b/fs/xfs/scrub/inode.c | 2 -
b/fs/xfs/scrub/inode_repair.c | 2 -
b/fs/xfs/scrub/iscan.c | 2 -
b/fs/xfs/scrub/listxattr.c | 2 -
b/fs/xfs/scrub/metapath.c | 2 -
b/fs/xfs/scrub/newbt.c | 2 -
b/fs/xfs/scrub/nlinks.c | 2 -
b/fs/xfs/scrub/nlinks_repair.c | 2 -
b/fs/xfs/scrub/orphanage.c | 2 -
b/fs/xfs/scrub/parent.c | 2 -
b/fs/xfs/scrub/parent_repair.c | 2 -
b/fs/xfs/scrub/quota.c | 2 -
b/fs/xfs/scrub/quota_repair.c | 2 -
b/fs/xfs/scrub/quotacheck.c | 2 -
b/fs/xfs/scrub/quotacheck_repair.c | 2 -
b/fs/xfs/scrub/rcbag.c | 2 -
b/fs/xfs/scrub/rcbag_btree.c | 2 -
b/fs/xfs/scrub/readdir.c | 2 -
b/fs/xfs/scrub/reap.c | 2 -
b/fs/xfs/scrub/refcount.c | 2 -
b/fs/xfs/scrub/refcount_repair.c | 2 -
b/fs/xfs/scrub/repair.c | 2 -
b/fs/xfs/scrub/rgsuper.c | 2 -
b/fs/xfs/scrub/rmap.c | 2 -
b/fs/xfs/scrub/rmap_repair.c | 2 -
b/fs/xfs/scrub/rtbitmap.c | 2 -
b/fs/xfs/scrub/rtbitmap_repair.c | 2 -
b/fs/xfs/scrub/rtrefcount.c | 2 -
b/fs/xfs/scrub/rtrefcount_repair.c | 2 -
b/fs/xfs/scrub/rtrmap.c | 2 -
b/fs/xfs/scrub/rtrmap_repair.c | 2 -
b/fs/xfs/scrub/rtsummary.c | 2 -
b/fs/xfs/scrub/rtsummary_repair.c | 2 -
b/fs/xfs/scrub/scrub.c | 2 -
b/fs/xfs/scrub/stats.c | 2 -
b/fs/xfs/scrub/symlink.c | 2 -
b/fs/xfs/scrub/symlink_repair.c | 2 -
b/fs/xfs/scrub/tempfile.c | 2 -
b/fs/xfs/scrub/trace.c | 2 -
b/fs/xfs/scrub/xfarray.c | 2 -
b/fs/xfs/scrub/xfblob.c | 2 -
b/fs/xfs/scrub/xfile.c | 2 -
b/fs/xfs/xfs_acl.c | 2 -
b/fs/xfs/xfs_aops.c | 2 -
b/fs/xfs/xfs_attr_inactive.c | 2 -
b/fs/xfs/xfs_attr_item.c | 2 -
b/fs/xfs/xfs_attr_list.c | 2 -
b/fs/xfs/xfs_bio_io.c | 2 -
b/fs/xfs/xfs_bmap_item.c | 2 -
b/fs/xfs/xfs_bmap_util.c | 2 -
b/fs/xfs/xfs_buf.c | 2 -
b/fs/xfs/xfs_buf_item.c | 2 -
b/fs/xfs/xfs_buf_item_recover.c | 2 -
b/fs/xfs/xfs_buf_mem.c | 2 -
b/fs/xfs/xfs_dahash_test.c | 2 -
b/fs/xfs/xfs_dir2_readdir.c | 2 -
b/fs/xfs/xfs_discard.c | 2 -
b/fs/xfs/xfs_dquot.c | 2 -
b/fs/xfs/xfs_dquot_item.c | 2 -
b/fs/xfs/xfs_dquot_item_recover.c | 2 -
b/fs/xfs/xfs_drain.c | 2 -
b/fs/xfs/xfs_error.c | 2 -
b/fs/xfs/xfs_exchmaps_item.c | 2 -
b/fs/xfs/xfs_exchrange.c | 2 -
b/fs/xfs/xfs_export.c | 2 -
b/fs/xfs/xfs_extent_busy.c | 2 -
b/fs/xfs/xfs_extfree_item.c | 2 -
b/fs/xfs/xfs_file.c | 2 -
b/fs/xfs/xfs_filestream.c | 2 -
b/fs/xfs/xfs_fsmap.c | 2 -
b/fs/xfs/xfs_fsops.c | 2 -
b/fs/xfs/xfs_globals.c | 2 -
b/fs/xfs/xfs_handle.c | 2 -
b/fs/xfs/xfs_health.c | 2 -
b/fs/xfs/xfs_hooks.c | 2 -
b/fs/xfs/xfs_icache.c | 2 -
b/fs/xfs/xfs_icreate_item.c | 2 -
b/fs/xfs/xfs_inode.c | 2 -
b/fs/xfs/xfs_inode_item.c | 2 -
b/fs/xfs/xfs_inode_item_recover.c | 2 -
b/fs/xfs/xfs_ioctl.c | 2 -
b/fs/xfs/xfs_ioctl32.c | 2 -
b/fs/xfs/xfs_iomap.c | 2 -
b/fs/xfs/xfs_iops.c | 2 -
b/fs/xfs/xfs_itable.c | 2 -
b/fs/xfs/xfs_iunlink_item.c | 2 -
b/fs/xfs/xfs_iwalk.c | 2 -
b/fs/xfs/xfs_log.c | 2 -
b/fs/xfs/xfs_log_cil.c | 2 -
b/fs/xfs/xfs_log_recover.c | 2 -
b/fs/xfs/xfs_message.c | 2 -
b/fs/xfs/xfs_mount.c | 2 -
b/fs/xfs/xfs_mru_cache.c | 2 -
b/fs/xfs/xfs_notify_failure.c | 2 -
b/fs/xfs/xfs_platform.h | 46 ++++++++++++++++++++-------------
b/fs/xfs/xfs_pnfs.c | 2 -
b/fs/xfs/xfs_pwork.c | 2 -
b/fs/xfs/xfs_qm.c | 2 -
b/fs/xfs/xfs_qm_bhv.c | 2 -
b/fs/xfs/xfs_qm_syscalls.c | 2 -
b/fs/xfs/xfs_quotaops.c | 2 -
b/fs/xfs/xfs_refcount_item.c | 2 -
b/fs/xfs/xfs_reflink.c | 2 -
b/fs/xfs/xfs_rmap_item.c | 2 -
b/fs/xfs/xfs_rtalloc.c | 2 -
b/fs/xfs/xfs_stats.c | 2 -
b/fs/xfs/xfs_super.c | 2 -
b/fs/xfs/xfs_symlink.c | 2 -
b/fs/xfs/xfs_sysctl.c | 2 -
b/fs/xfs/xfs_sysfs.c | 2 -
b/fs/xfs/xfs_trace.c | 2 -
b/fs/xfs/xfs_trans.c | 2 -
b/fs/xfs/xfs_trans_ail.c | 2 -
b/fs/xfs/xfs_trans_buf.c | 2 -
b/fs/xfs/xfs_trans_dquot.c | 2 -
b/fs/xfs/xfs_xattr.c | 2 -
b/fs/xfs/xfs_zone_alloc.c | 2 -
b/fs/xfs/xfs_zone_gc.c | 2 -
b/fs/xfs/xfs_zone_info.c | 2 -
b/fs/xfs/xfs_zone_space_resv.c | 2 -
fs/xfs/xfs.h | 28 --------------------
195 files changed, 222 insertions(+), 238 deletions(-)
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 1/4] xfs: rename xfs_linux.h to xfs_platform.h
2025-12-19 5:41 [PATCH v2] rename xfs.h Christoph Hellwig
@ 2025-12-19 5:41 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2025-12-19 5:41 UTC (permalink / raw)
To: Carlos Maiolino
Cc: Andrey Albershteyn, Darrick J . Wong, Dave Chinner, Eric Sandeen,
linux-xfs
Rename xfs_linux.h to prepare for including including it directly
from source files including those shared with xfsprogs.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/xfs/xfs.h | 2 +-
fs/xfs/{xfs_linux.h => xfs_platform.h} | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
rename fs/xfs/{xfs_linux.h => xfs_platform.h} (98%)
diff --git a/fs/xfs/xfs.h b/fs/xfs/xfs.h
index 9355ccad9503..b335a471c088 100644
--- a/fs/xfs/xfs.h
+++ b/fs/xfs/xfs.h
@@ -23,6 +23,6 @@
#endif
-#include "xfs_linux.h"
+#include "xfs_platform.h"
#endif /* __XFS_H__ */
diff --git a/fs/xfs/xfs_linux.h b/fs/xfs/xfs_platform.h
similarity index 98%
rename from fs/xfs/xfs_linux.h
rename to fs/xfs/xfs_platform.h
index 4dd747bdbcca..ec8cd71fc868 100644
--- a/fs/xfs/xfs_linux.h
+++ b/fs/xfs/xfs_platform.h
@@ -3,8 +3,8 @@
* Copyright (c) 2000-2005 Silicon Graphics, Inc.
* All Rights Reserved.
*/
-#ifndef __XFS_LINUX__
-#define __XFS_LINUX__
+#ifndef _XFS_PLATFORM_H
+#define _XFS_PLATFORM_H
#include <linux/types.h>
#include <linux/uuid.h>
@@ -281,4 +281,4 @@ kmem_to_page(void *addr)
return virt_to_page(addr);
}
-#endif /* __XFS_LINUX__ */
+#endif /* _XFS_PLATFORM_H */
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-19 17:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-19 17:18 [PATCH 1/4] xfs: rename xfs_linux.h to xfs_platform.h kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2025-12-19 5:41 [PATCH v2] rename xfs.h Christoph Hellwig
2025-12-19 5:41 ` [PATCH 1/4] xfs: rename xfs_linux.h to xfs_platform.h Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.