From: Adrian Hunter <adrian.hunter@intel.com>
To: alexandre.belloni@bootlin.com
Cc: Frank.Li@nxp.com, Wolfram Sang <wsa+renesas@sang-engineering.com>,
Aniket <aniketmaurya@google.com>,
linux-i3c@lists.infradead.org
Subject: [PATCH V2 08/20] i3c: mipi-i3c-hci: Cache DAT in memory for Runtime PM restore
Date: Thu, 8 Jan 2026 10:05:46 +0200 [thread overview]
Message-ID: <20260108080558.21767-9-adrian.hunter@intel.com> (raw)
In-Reply-To: <20260108080558.21767-1-adrian.hunter@intel.com>
Prepare for Runtime PM support, which requires restoring the Device Address
Table (DAT) registers after resume. Maintain a copy of DAT in memory so it
can be reprogrammed when the controller is powered back up.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
Changes in V2:
Add Frank's Rev'd-by
drivers/i3c/master/mipi-i3c-hci/dat_v1.c | 29 +++++++++++++++++++-----
drivers/i3c/master/mipi-i3c-hci/hci.h | 6 +++++
2 files changed, 29 insertions(+), 6 deletions(-)
diff --git a/drivers/i3c/master/mipi-i3c-hci/dat_v1.c b/drivers/i3c/master/mipi-i3c-hci/dat_v1.c
index c60ef5d77ca3..644ab939be1c 100644
--- a/drivers/i3c/master/mipi-i3c-hci/dat_v1.c
+++ b/drivers/i3c/master/mipi-i3c-hci/dat_v1.c
@@ -34,13 +34,26 @@
/* DAT_0_IBI_PAYLOAD W0_BIT_(12) */
#define DAT_0_STATIC_ADDRESS W0_MASK(6, 0)
-#define dat_w0_read(i) readl(hci->DAT_regs + (i) * 8)
-#define dat_w1_read(i) readl(hci->DAT_regs + (i) * 8 + 4)
-#define dat_w0_write(i, v) writel(v, hci->DAT_regs + (i) * 8)
-#define dat_w1_write(i, v) writel(v, hci->DAT_regs + (i) * 8 + 4)
+#define dat_w0_read(i) hci->DAT[i].w0
+#define dat_w1_read(i) hci->DAT[i].w1
+#define dat_w0_write(i, v) hci_dat_w0_write(hci, i, v)
+#define dat_w1_write(i, v) hci_dat_w1_write(hci, i, v)
+
+static inline void hci_dat_w0_write(struct i3c_hci *hci, int i, u32 v)
+{
+ hci->DAT[i].w0 = v;
+ writel(v, hci->DAT_regs + i * 8);
+}
+
+static inline void hci_dat_w1_write(struct i3c_hci *hci, int i, u32 v)
+{
+ hci->DAT[i].w1 = v;
+ writel(v, hci->DAT_regs + i * 8 + 4);
+}
static int hci_dat_v1_init(struct i3c_hci *hci)
{
+ struct device *dev = hci->master.dev.parent;
unsigned int dat_idx;
if (!hci->DAT_regs) {
@@ -54,9 +67,13 @@ static int hci_dat_v1_init(struct i3c_hci *hci)
return -EOPNOTSUPP;
}
- if (!hci->DAT_data) {
- struct device *dev = hci->master.dev.parent;
+ if (!hci->DAT) {
+ hci->DAT = devm_kcalloc(dev, hci->DAT_entries, hci->DAT_entry_size, GFP_KERNEL);
+ if (!hci->DAT)
+ return -ENOMEM;
+ }
+ if (!hci->DAT_data) {
/* use a bitmap for faster free slot search */
hci->DAT_data = devm_bitmap_zalloc(dev, hci->DAT_entries, GFP_KERNEL);
if (!hci->DAT_data)
diff --git a/drivers/i3c/master/mipi-i3c-hci/hci.h b/drivers/i3c/master/mipi-i3c-hci/hci.h
index fd08b701d094..aa8a03594e64 100644
--- a/drivers/i3c/master/mipi-i3c-hci/hci.h
+++ b/drivers/i3c/master/mipi-i3c-hci/hci.h
@@ -31,6 +31,11 @@
struct hci_cmd_ops;
+struct dat_words {
+ u32 w0;
+ u32 w1;
+};
+
/* Our main structure */
struct i3c_hci {
struct i3c_master_controller master;
@@ -51,6 +56,7 @@ struct i3c_hci {
unsigned int DAT_entries;
unsigned int DAT_entry_size;
void *DAT_data;
+ struct dat_words *DAT;
unsigned int DCT_entries;
unsigned int DCT_entry_size;
u8 version_major;
--
2.51.0
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2026-01-08 8:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 8:05 [PATCH V2 00/20] i3c: mipi-i3c-hci-pci: Add Runtime PM support Adrian Hunter
2026-01-08 8:05 ` [PATCH V2 01/20] i3c: mipi-i3c-hci: Reset RING_OPERATION1 fields during init Adrian Hunter
2026-01-08 8:05 ` [PATCH V2 02/20] i3c: mipi-i3c-hci: Ensure proper bus clean-up Adrian Hunter
2026-01-08 8:05 ` [PATCH V2 03/20] i3c: master: Update hot-join flag only on success Adrian Hunter
2026-01-08 14:52 ` Frank Li
2026-01-08 8:05 ` [PATCH V2 04/20] i3c: master: Replace WARN_ON() with dev_err() in i3c_dev_free_ibi_locked() Adrian Hunter
2026-01-08 8:05 ` [PATCH V2 05/20] i3c: mipi-i3c-hci: Switch DAT bitmap allocation to devm_bitmap_zalloc() Adrian Hunter
2026-01-08 8:05 ` [PATCH V2 06/20] i3c: mipi-i3c-hci: Switch PIO data allocation to devm_kzalloc() Adrian Hunter
2026-01-08 8:05 ` [PATCH V2 07/20] i3c: mipi-i3c-hci: Manage DMA deallocation via devres action Adrian Hunter
2026-01-08 14:56 ` Frank Li
2026-01-08 8:05 ` Adrian Hunter [this message]
2026-01-08 8:05 ` [PATCH V2 09/20] i3c: mipi-i3c-hci: Introduce helper to restore DAT Adrian Hunter
2026-01-08 8:05 ` [PATCH V2 10/20] i3c: mipi-i3c-hci: Extract ring initialization from hci_dma_init() Adrian Hunter
2026-01-08 8:05 ` [PATCH V2 11/20] i3c: mipi-i3c-hci: Add DMA suspend and resume support Adrian Hunter
2026-01-08 8:05 ` [PATCH V2 12/20] i3c: mipi-i3c-hci: Refactor PIO register initialization Adrian Hunter
2026-01-08 8:05 ` [PATCH V2 13/20] i3c: mipi-i3c-hci: Add PIO suspend and resume support Adrian Hunter
2026-01-08 8:05 ` [PATCH V2 14/20] i3c: mipi-i3c-hci: Factor out software reset into helper Adrian Hunter
2026-01-08 14:57 ` Frank Li
2026-01-08 8:05 ` [PATCH V2 15/20] i3c: mipi-i3c-hci: Factor out IO mode setting " Adrian Hunter
2026-01-08 15:03 ` Frank Li
2026-01-08 8:05 ` [PATCH V2 16/20] i3c: mipi-i3c-hci: Factor out core initialization " Adrian Hunter
2026-01-08 15:25 ` Frank Li
2026-01-08 8:05 ` [PATCH V2 17/20] i3c: mipi-i3c-hci: Factor out master dynamic address setting " Adrian Hunter
2026-01-08 15:28 ` Frank Li
2026-01-08 8:05 ` [PATCH V2 18/20] i3c: master: Introduce optional Runtime PM support Adrian Hunter
2026-01-08 15:09 ` Frank Li
2026-01-09 11:42 ` Adrian Hunter
2026-01-12 16:04 ` Frank Li
2026-01-08 8:05 ` [PATCH V2 19/20] i3c: mipi-i3c-hci: Add " Adrian Hunter
2026-01-08 15:15 ` Frank Li
2026-01-08 8:05 ` [PATCH V2 20/20] i3c: mipi-i3c-hci-pci: Add " Adrian Hunter
2026-01-08 15:17 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260108080558.21767-9-adrian.hunter@intel.com \
--to=adrian.hunter@intel.com \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=aniketmaurya@google.com \
--cc=linux-i3c@lists.infradead.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.