Re: [PATCH v2 37/37] arm64: dts: qcom: msm8996: Move PCIe phy and GPIOs to root port node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message claims to move both the 'phys' and 'phy-names' properties to the root port nodes, but the patch actually deletes 'phy-names' entirely.
--

commit baa70baca6b8bb3dd12472bf021f252ebb1f4c9c
Author: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>

arm64: dts: qcom: msm8996: Move PCIe phy and GPIOs to root port node

This patch moves the PCIe phy reference and GPIO properties to the root port
node from the RC controller node. It adjusts the device tree nodes and adds
labels to allow board-level overrides for the root port context.

> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 2f67e665996f3..8db1448e5e610 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -1900,9 +1900,6 @@ pcie0: pcie@600000 {
>  				      <0x0c100000 0x100000>;
>  				reg-names = "parf", "dbi", "elbi","config";
>  
> -				phys = <&pciephy_0>;
> -				phy-names = "pciephy";
> -
>  				#address-cells = <3>;
>  				#size-cells = <2>;
>  				ranges = <0x01000000 0x0 0x00000000 0x0c200000 0x0 0x100000>,

[ ... ]

> @@ -1951,7 +1948,7 @@ pcie0: pcie@600000 {
>  						"bus_master",
>  						"bus_slave";
>  
> -				pcie@0 {
> +				pcie0_port0: pcie@0 {
>  					device_type = "pci";
>  					reg = <0x0 0x0 0x0 0x0 0x0>;
>  					bus-range = <0x01 0xff>;
> @@ -1959,6 +1956,8 @@ pcie@0 {
>  					#address-cells = <3>;
>  					#size-cells = <2>;
>  					ranges;
> +
> +					phys = <&pciephy_0>;
>  				};

[Severity: Medium]
The commit message states "Move phys and phy-names from the controller to
pcie0_port0, pcie1_port0, and pcie2_port0".

However, looking at the removal in pcie0 and the addition in pcie0_port0, it
appears phy-names was deleted but not added to the new port nodes. The same
pattern is present for pcie1_port0 and pcie2_port0.

Is the intention to drop the phy-names property completely because it is no
longer needed by the new bindings? If so, could the commit message be
updated to reflect that phy-names was removed rather than moved?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260611-wake-v2-0-2744251b1181@oss.qualcomm.com?part=37