Re: [PATCH 11/11] ASoC: fsl: mpc5200_psc_ac97: Use guard() for mutex locks

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Build failure due to invalid guard class name `mutex_lock` in `scoped_guard()`.
--

commit 1d8ae1620f1469808672c10039fce92329ce78b6
Author: bui duc phuc <phucduc.bui@gmail.com>

ASoC: fsl: mpc5200_psc_ac97: Use guard() for mutex locks

This commit cleans up the MPC5200 PSC AC97 driver by replacing manual
mutex lock and unlock calls with the scope-based guard() and scoped_guard()
macros to simplify execution paths.

> diff --git a/sound/soc/fsl/mpc5200_psc_ac97.c b/sound/soc/fsl/mpc5200_psc_ac97.c
> index 8554fb690772c..80666da923d02 100644
> --- a/sound/soc/fsl/mpc5200_psc_ac97.c
> +++ b/sound/soc/fsl/mpc5200_psc_ac97.c

[ ... ]

> @@ -83,16 +82,15 @@ static void psc_ac97_cold_reset(struct snd_ac97 *ac97)
>  {
>  	struct mpc52xx_psc __iomem *regs = psc_dma->psc_regs;
>  
> -	mutex_lock(&psc_dma->mutex);
> -	dev_dbg(psc_dma->dev, "cold reset\n");
> +	scoped_guard(mutex_lock, &psc_dma->mutex) {

[Severity: Low]
Does this code compile successfully? The scoped_guard() macro expects the
lock class name as its first argument, which for a standard mutex should be
"mutex", not "mutex_lock".

Passing "mutex_lock" here will likely result in a build failure due to an
undefined guard class type.

> +		dev_dbg(psc_dma->dev, "cold reset\n");
>  
> -	mpc5200_psc_ac97_gpio_reset(psc_dma->id);
> +		mpc5200_psc_ac97_gpio_reset(psc_dma->id);
>  
> -	/* Notify the PSC that a reset has occurred */
> -	out_be32(&regs->sicr, psc_dma->sicr | MPC52xx_PSC_SICR_ACRB);
> +		/* Notify the PSC that a reset has occurred */
> +		out_be32(&regs->sicr, psc_dma->sicr | MPC52xx_PSC_SICR_ACRB);
>  
> -	/* Re-enable RX and TX */
> -	out_8(&regs->command, MPC52xx_PSC_TX_ENABLE | MPC52xx_PSC_RX_ENABLE);
> -
> -	mutex_unlock(&psc_dma->mutex);
> +		/* Re-enable RX and TX */
> +		out_8(&regs->command, MPC52xx_PSC_TX_ENABLE | MPC52xx_PSC_RX_ENABLE);
> +	}
>  
>  	usleep_range(1000, 2000);
>  	psc_ac97_warm_reset(ac97);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260612132639.78086-1-phucduc.bui@gmail.com?part=11