Re: [PATCH v1 01/10] mpi3mr: Skip device shutdown during unload per controller configuration

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing `le32_to_cpu()` conversion when reading the little-endian `flags` field from `driver_pg1`.
--

commit d356c9ee9428175d4bc2bdb0dd4aaf2c6a81d8bd
Author: Ranjan Kumar <ranjan.kumar@broadcom.com>

mpi3mr: Skip device shutdown during unload per controller configuration

This commit updates the driver to cache the Driver Page 1 configuration
and skip device shutdown requests during driver unload when the controller
requests it.

> diff --git a/drivers/scsi/mpi3mr/mpi3mr_fw.c b/drivers/scsi/mpi3mr/mpi3mr_fw.c
> index 31b19ed1528e5..eb730318db474 100644
> --- a/drivers/scsi/mpi3mr/mpi3mr_fw.c
> +++ b/drivers/scsi/mpi3mr/mpi3mr_fw.c
[ ... ]
>  static void
> -mpi3mr_read_tsu_interval(struct mpi3mr_ioc *mrioc)
> +mpi3mr_read_driver_page1(struct mpi3mr_ioc *mrioc)
>  {
>  	struct mpi3_driver_page1 driver_pg1;
>  	u16 pg_sz = sizeof(driver_pg1);
>  	int retval = 0;
>  
>  	mrioc->ts_update_interval = MPI3MR_TSUPDATE_INTERVAL;
> +	mrioc->skip_dev_shutdown_on_unload = 0;
>  
>  	retval = mpi3mr_cfg_get_driver_pg1(mrioc, &driver_pg1, pg_sz);
> -	if (!retval && driver_pg1.time_stamp_update)
> +
> +	if (retval)
> +		return;
> +
> +	if (driver_pg1.time_stamp_update)
>  		mrioc->ts_update_interval = (driver_pg1.time_stamp_update * 60);
> +
> +	mrioc->skip_dev_shutdown_on_unload =
> +		(driver_pg1.flags &
> +		 MPI3_DRIVER1_FLAGS_DEVICE_SHUTDOWN_ON_UNLOAD_DISABLE) ? 1 : 0;

[Severity: Medium]
Does this bitwise operation need an endian conversion?

Since driver_pg1.flags is an __le32, evaluating it with a bitwise AND
without conversion on a big-endian system will check the wrong byte.
This might cause the feature to silently fail to activate.

Could this use le32_to_cpu(driver_pg1.flags) before the bitwise AND?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260626114109.43685-1-ranjan.kumar@broadcom.com?part=1