Re: [PATCH v1 02/10] mpi3mr: Update MPI Headers to revision 41

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing endian conversion for `driver_pg1.flags` before bitwise AND.
--

commit dcead2e50e7c04fa8f12bc236d238e9408c959bb
Author: Ranjan Kumar <ranjan.kumar@broadcom.com>

mpi3mr: Update MPI Headers to revision 41

Update MPI Headers to revision 41.

> diff --git a/drivers/scsi/mpi3mr/mpi3mr_fw.c b/drivers/scsi/mpi3mr/mpi3mr_fw.c
> --- a/drivers/scsi/mpi3mr/mpi3mr_fw.c
> +++ b/drivers/scsi/mpi3mr/mpi3mr_fw.c
[ ... ]
> @@ -4128,11 +4128,15 @@ mpi3mr_read_driver_page1(struct mpi3mr_ioc *mrioc)
>  	struct mpi3_driver_page1 driver_pg1;
>  	u16 pg_sz = sizeof(driver_pg1);
>  	int retval = 0;
>  
>  	mrioc->ts_update_interval = MPI3MR_TSUPDATE_INTERVAL;
> +	mrioc->skip_dev_shutdown_on_unload = 0;
>  
>  	retval = mpi3mr_cfg_get_driver_pg1(mrioc, &driver_pg1, pg_sz);
> -	if (!retval && driver_pg1.time_stamp_update)
> +
> +	if (retval)
> +		return;
> +
> +	if (driver_pg1.time_stamp_update)
>  		mrioc->ts_update_interval = (driver_pg1.time_stamp_update * 60);
> +
> +	mrioc->skip_dev_shutdown_on_unload =
> +		(driver_pg1.flags &
> +		 MPI3_DRIVER1_FLAGS_DEVICE_SHUTDOWN_ON_UNLOAD_DISABLE) ? 1 : 0;

[Severity: High]
Does this code miss an endianness conversion for driver_pg1.flags before the
bitwise AND?

If driver_pg1.flags is populated natively in little-endian format from the
controller without swapping, evaluating it against a host-endian macro could
lead to incorrect logic on Big-Endian architectures.

For example, if the firmware sets
MPI3_DRIVER1_FLAGS_DEVICE_SHUTDOWN_ON_UNLOAD_DISABLE (0x01), a Big-Endian CPU
would read it as 0x01000000, evaluate the check to false, and fail to skip the
requested device shutdown.

Conversely, if a future flag sets bit 24, a Big-Endian CPU reads it as
0x00000001, evaluates the check to true, and falsely skips device shutdown,
which could lead to data loss such as unflushed drive caches.

Is le32_to_cpu() or similar needed here?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260626114109.43685-1-ranjan.kumar@broadcom.com?part=2