Re: [PATCH v2 1/4] hw/riscv/virt: Add CXL support to the RISC-V virt machine

[Chen Pei <cp0613@linux.alibaba.com>]

Hi Daniel,

On 6/24/2026 1:42 PM, Daniel Henrique Barboza wrote:
> create_cxl_host_reg_region() is doing the same check:
>
>     if (!s->cxl_devices_state.is_enabled) {
>     (...)
>
> Maybe we could squash these update_mmio() lines in the same helper to have
> everything CXL related in the same place.  The helper would need to be
> renamed to something more appropriate (e.g. cxl_host_state_init() since we're
> at init time).

Thanks for the review. You are right, the x86 pc_memory_init() path keeps
the CXL host register region creation and the FMW address programming
inside a single 'if (is_enabled)' block, and there is no reason for
RISC-V to split them. I'll fold the cxl_fmws_set_memmap() and
cxl_fmws_update_mmio() calls into create_cxl_host_reg_region(), rename
the helper to cxl_host_state_init(), and drop the duplicate guard in
virt_machine_init() in v3.

Thanks,
Pei