* [PATCH] imx93_frdm: Add OP-TEE device tree node @ 2026-07-06 12:34 Mathieu Dubois-Briand 2026-07-06 14:14 ` Peter Robinson 0 siblings, 1 reply; 6+ messages in thread From: Mathieu Dubois-Briand @ 2026-07-06 12:34 UTC (permalink / raw) To: NXP i.MX U-Boot Team, u-boot Cc: Thomas Petazzoni, Stefano Babic, Fabio Estevam, Tom Rini, Ilias Apalodimas, Peng Fan, Mathieu Dubois-Briand Add missing firmware/optee node, so is can be both used and copied into Linux device tree by optee_copy_firmware_node(). This is consistent with other i.MX93 boards. Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com> --- arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi b/arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi index 41111b1a95a2..2ce9f46b2ad8 100644 --- a/arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi +++ b/arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi @@ -12,6 +12,13 @@ bootph-pre-ram; bootph-some-ram; }; + + firmware { + optee { + compatible = "linaro,optee-tz"; + method = "smc"; + }; + }; }; &A55_0 { --- base-commit: 780084d7c07f511da4a39b43277c573156ed42e0 change-id: 20260706-master-c71a02f504f0 Best regards, -- Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com> ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] imx93_frdm: Add OP-TEE device tree node 2026-07-06 12:34 [PATCH] imx93_frdm: Add OP-TEE device tree node Mathieu Dubois-Briand @ 2026-07-06 14:14 ` Peter Robinson 2026-07-06 14:54 ` Mathieu Dubois-Briand 0 siblings, 1 reply; 6+ messages in thread From: Peter Robinson @ 2026-07-06 14:14 UTC (permalink / raw) To: Mathieu Dubois-Briand Cc: NXP i.MX U-Boot Team, u-boot, Thomas Petazzoni, Stefano Babic, Fabio Estevam, Tom Rini, Ilias Apalodimas, Peng Fan On Mon, 6 Jul 2026 at 13:34, Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com> wrote: > > Add missing firmware/optee node, so is can be both used and copied into > Linux device tree by optee_copy_firmware_node(). This is consistent with > other i.MX93 boards. Shouldn't this be going to the upstream Linux DT at which point get it when we resync? > Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com> > --- > arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi b/arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi > index 41111b1a95a2..2ce9f46b2ad8 100644 > --- a/arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi > +++ b/arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi > @@ -12,6 +12,13 @@ > bootph-pre-ram; > bootph-some-ram; > }; > + > + firmware { > + optee { > + compatible = "linaro,optee-tz"; > + method = "smc"; > + }; > + }; > }; > > &A55_0 { > > --- > base-commit: 780084d7c07f511da4a39b43277c573156ed42e0 > change-id: 20260706-master-c71a02f504f0 > > Best regards, > -- > Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com> > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] imx93_frdm: Add OP-TEE device tree node 2026-07-06 14:14 ` Peter Robinson @ 2026-07-06 14:54 ` Mathieu Dubois-Briand 2026-07-06 14:59 ` Tom Rini 0 siblings, 1 reply; 6+ messages in thread From: Mathieu Dubois-Briand @ 2026-07-06 14:54 UTC (permalink / raw) To: Peter Robinson Cc: NXP i.MX U-Boot Team, u-boot, Thomas Petazzoni, Stefano Babic, Fabio Estevam, Tom Rini, Ilias Apalodimas, Peng Fan Hi, On Mon Jul 6, 2026 at 4:14 PM CEST, Peter Robinson wrote: > On Mon, 6 Jul 2026 at 13:34, Mathieu Dubois-Briand > <mathieu.dubois-briand@bootlin.com> wrote: >> >> Add missing firmware/optee node, so is can be both used and copied into >> Linux device tree by optee_copy_firmware_node(). This is consistent with >> other i.MX93 boards. > > Shouldn't this be going to the upstream Linux DT at which point get it > when we resync? I don't think it should. Or maybe it should, but then we are doing wrong things for other boards, particularly for the i.MX family. We have this node in the -u-boot.dtsi file for various other boards: git grep "linaro,optee-tz" -- '*-u-boot.dtsi' arch/arm/dts/imx8mm-u-boot.dtsi: compatible = "linaro,optee-tz"; arch/arm/dts/imx8mn-u-boot.dtsi: compatible = "linaro,optee-tz"; arch/arm/dts/imx8mp-debix-model-a-u-boot.dtsi: compatible = "linaro,optee-tz"; arch/arm/dts/imx8mp-navqp-u-boot.dtsi: compatible = "linaro,optee-tz"; arch/arm/dts/imx8mp-u-boot.dtsi: compatible = "linaro,optee-tz"; arch/arm/dts/imx91-11x11-evk-u-boot.dtsi: compatible = "linaro,optee-tz"; arch/arm/dts/imx91-11x11-frdm-u-boot.dtsi: compatible = "linaro,optee-tz"; arch/arm/dts/imx91-93-phyboard-segin-common-u-boot.dtsi: compatible = "linaro,optee-tz"; arch/arm/dts/imx93-11x11-evk-u-boot.dtsi: compatible = "linaro,optee-tz"; arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi: compatible = "linaro,optee-tz"; arch/arm/dts/imx93-9x9-qsb-u-boot.dtsi: compatible = "linaro,optee-tz"; arch/arm/dts/imx93-kontron-bl-osm-s-u-boot.dtsi: compatible = "linaro,optee-tz"; arch/arm/dts/imx93-var-som-symphony-u-boot.dtsi: compatible = "linaro,optee-tz"; arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi: compatible = "linaro,optee-tz"; arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi: compatible = "linaro,optee-tz"; Thanks, Mathieu -- Mathieu Dubois-Briand, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] imx93_frdm: Add OP-TEE device tree node 2026-07-06 14:54 ` Mathieu Dubois-Briand @ 2026-07-06 14:59 ` Tom Rini 2026-07-06 15:37 ` Mathieu Dubois-Briand 0 siblings, 1 reply; 6+ messages in thread From: Tom Rini @ 2026-07-06 14:59 UTC (permalink / raw) To: Mathieu Dubois-Briand Cc: Peter Robinson, NXP i.MX U-Boot Team, u-boot, Thomas Petazzoni, Stefano Babic, Fabio Estevam, Ilias Apalodimas, Peng Fan [-- Attachment #1: Type: text/plain, Size: 2481 bytes --] On Mon, Jul 06, 2026 at 04:54:17PM +0200, Mathieu Dubois-Briand wrote: > Hi, > > On Mon Jul 6, 2026 at 4:14 PM CEST, Peter Robinson wrote: > > On Mon, 6 Jul 2026 at 13:34, Mathieu Dubois-Briand > > <mathieu.dubois-briand@bootlin.com> wrote: > >> > >> Add missing firmware/optee node, so is can be both used and copied into > >> Linux device tree by optee_copy_firmware_node(). This is consistent with > >> other i.MX93 boards. > > > > Shouldn't this be going to the upstream Linux DT at which point get it > > when we resync? > > I don't think it should. Or maybe it should, but then we are doing wrong > things for other boards, particularly for the i.MX family. > > We have this node in the -u-boot.dtsi file for various other boards: > > git grep "linaro,optee-tz" -- '*-u-boot.dtsi' > arch/arm/dts/imx8mm-u-boot.dtsi: compatible = "linaro,optee-tz"; > arch/arm/dts/imx8mn-u-boot.dtsi: compatible = "linaro,optee-tz"; > arch/arm/dts/imx8mp-debix-model-a-u-boot.dtsi: compatible = "linaro,optee-tz"; > arch/arm/dts/imx8mp-navqp-u-boot.dtsi: compatible = "linaro,optee-tz"; > arch/arm/dts/imx8mp-u-boot.dtsi: compatible = "linaro,optee-tz"; > arch/arm/dts/imx91-11x11-evk-u-boot.dtsi: compatible = "linaro,optee-tz"; > arch/arm/dts/imx91-11x11-frdm-u-boot.dtsi: compatible = "linaro,optee-tz"; > arch/arm/dts/imx91-93-phyboard-segin-common-u-boot.dtsi: compatible = "linaro,optee-tz"; > arch/arm/dts/imx93-11x11-evk-u-boot.dtsi: compatible = "linaro,optee-tz"; > arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi: compatible = "linaro,optee-tz"; > arch/arm/dts/imx93-9x9-qsb-u-boot.dtsi: compatible = "linaro,optee-tz"; > arch/arm/dts/imx93-kontron-bl-osm-s-u-boot.dtsi: compatible = "linaro,optee-tz"; > arch/arm/dts/imx93-var-som-symphony-u-boot.dtsi: compatible = "linaro,optee-tz"; > arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi: compatible = "linaro,optee-tz"; > arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi: compatible = "linaro,optee-tz"; Since I assume this would still pass validation in the Linux kernel, yes, it looks like a lot of platforms are doing it wrong here and should be pushing this upstream. Thanks. -- Tom [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] imx93_frdm: Add OP-TEE device tree node 2026-07-06 14:59 ` Tom Rini @ 2026-07-06 15:37 ` Mathieu Dubois-Briand 2026-07-06 15:54 ` Tom Rini 0 siblings, 1 reply; 6+ messages in thread From: Mathieu Dubois-Briand @ 2026-07-06 15:37 UTC (permalink / raw) To: Tom Rini Cc: Peter Robinson, NXP i.MX U-Boot Team, u-boot, Thomas Petazzoni, Stefano Babic, Fabio Estevam, Ilias Apalodimas, Peng Fan On Mon Jul 6, 2026 at 4:59 PM CEST, Tom Rini wrote: > On Mon, Jul 06, 2026 at 04:54:17PM +0200, Mathieu Dubois-Briand wrote: >> Hi, >> >> On Mon Jul 6, 2026 at 4:14 PM CEST, Peter Robinson wrote: >> > On Mon, 6 Jul 2026 at 13:34, Mathieu Dubois-Briand >> > <mathieu.dubois-briand@bootlin.com> wrote: >> >> >> >> Add missing firmware/optee node, so is can be both used and copied into >> >> Linux device tree by optee_copy_firmware_node(). This is consistent with >> >> other i.MX93 boards. >> > >> > Shouldn't this be going to the upstream Linux DT at which point get it >> > when we resync? >> >> I don't think it should. Or maybe it should, but then we are doing wrong >> things for other boards, particularly for the i.MX family. >> >> We have this node in the -u-boot.dtsi file for various other boards: >> >> git grep "linaro,optee-tz" -- '*-u-boot.dtsi' >> arch/arm/dts/imx8mm-u-boot.dtsi: compatible = "linaro,optee-tz"; >> arch/arm/dts/imx8mn-u-boot.dtsi: compatible = "linaro,optee-tz"; >> arch/arm/dts/imx8mp-debix-model-a-u-boot.dtsi: compatible = "linaro,optee-tz"; >> arch/arm/dts/imx8mp-navqp-u-boot.dtsi: compatible = "linaro,optee-tz"; >> arch/arm/dts/imx8mp-u-boot.dtsi: compatible = "linaro,optee-tz"; >> arch/arm/dts/imx91-11x11-evk-u-boot.dtsi: compatible = "linaro,optee-tz"; >> arch/arm/dts/imx91-11x11-frdm-u-boot.dtsi: compatible = "linaro,optee-tz"; >> arch/arm/dts/imx91-93-phyboard-segin-common-u-boot.dtsi: compatible = "linaro,optee-tz"; >> arch/arm/dts/imx93-11x11-evk-u-boot.dtsi: compatible = "linaro,optee-tz"; >> arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi: compatible = "linaro,optee-tz"; >> arch/arm/dts/imx93-9x9-qsb-u-boot.dtsi: compatible = "linaro,optee-tz"; >> arch/arm/dts/imx93-kontron-bl-osm-s-u-boot.dtsi: compatible = "linaro,optee-tz"; >> arch/arm/dts/imx93-var-som-symphony-u-boot.dtsi: compatible = "linaro,optee-tz"; >> arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi: compatible = "linaro,optee-tz"; >> arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi: compatible = "linaro,optee-tz"; > > Since I assume this would still pass validation in the Linux kernel, > yes, it looks like a lot of platforms are doing it wrong here and should > be pushing this upstream. Thanks. Ok, so I suspect I should instead submit a similar patch against the Kernel. Should I try to add something similar for other i.MX boards and stm32 boards at the same time? So they could later be removed from u-boot. -- Mathieu Dubois-Briand, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] imx93_frdm: Add OP-TEE device tree node 2026-07-06 15:37 ` Mathieu Dubois-Briand @ 2026-07-06 15:54 ` Tom Rini 0 siblings, 0 replies; 6+ messages in thread From: Tom Rini @ 2026-07-06 15:54 UTC (permalink / raw) To: Mathieu Dubois-Briand Cc: Peter Robinson, NXP i.MX U-Boot Team, u-boot, Thomas Petazzoni, Stefano Babic, Fabio Estevam, Ilias Apalodimas, Peng Fan [-- Attachment #1: Type: text/plain, Size: 3014 bytes --] On Mon, Jul 06, 2026 at 05:37:41PM +0200, Mathieu Dubois-Briand wrote: > On Mon Jul 6, 2026 at 4:59 PM CEST, Tom Rini wrote: > > On Mon, Jul 06, 2026 at 04:54:17PM +0200, Mathieu Dubois-Briand wrote: > >> Hi, > >> > >> On Mon Jul 6, 2026 at 4:14 PM CEST, Peter Robinson wrote: > >> > On Mon, 6 Jul 2026 at 13:34, Mathieu Dubois-Briand > >> > <mathieu.dubois-briand@bootlin.com> wrote: > >> >> > >> >> Add missing firmware/optee node, so is can be both used and copied into > >> >> Linux device tree by optee_copy_firmware_node(). This is consistent with > >> >> other i.MX93 boards. > >> > > >> > Shouldn't this be going to the upstream Linux DT at which point get it > >> > when we resync? > >> > >> I don't think it should. Or maybe it should, but then we are doing wrong > >> things for other boards, particularly for the i.MX family. > >> > >> We have this node in the -u-boot.dtsi file for various other boards: > >> > >> git grep "linaro,optee-tz" -- '*-u-boot.dtsi' > >> arch/arm/dts/imx8mm-u-boot.dtsi: compatible = "linaro,optee-tz"; > >> arch/arm/dts/imx8mn-u-boot.dtsi: compatible = "linaro,optee-tz"; > >> arch/arm/dts/imx8mp-debix-model-a-u-boot.dtsi: compatible = "linaro,optee-tz"; > >> arch/arm/dts/imx8mp-navqp-u-boot.dtsi: compatible = "linaro,optee-tz"; > >> arch/arm/dts/imx8mp-u-boot.dtsi: compatible = "linaro,optee-tz"; > >> arch/arm/dts/imx91-11x11-evk-u-boot.dtsi: compatible = "linaro,optee-tz"; > >> arch/arm/dts/imx91-11x11-frdm-u-boot.dtsi: compatible = "linaro,optee-tz"; > >> arch/arm/dts/imx91-93-phyboard-segin-common-u-boot.dtsi: compatible = "linaro,optee-tz"; > >> arch/arm/dts/imx93-11x11-evk-u-boot.dtsi: compatible = "linaro,optee-tz"; > >> arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi: compatible = "linaro,optee-tz"; > >> arch/arm/dts/imx93-9x9-qsb-u-boot.dtsi: compatible = "linaro,optee-tz"; > >> arch/arm/dts/imx93-kontron-bl-osm-s-u-boot.dtsi: compatible = "linaro,optee-tz"; > >> arch/arm/dts/imx93-var-som-symphony-u-boot.dtsi: compatible = "linaro,optee-tz"; > >> arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi: compatible = "linaro,optee-tz"; > >> arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi: compatible = "linaro,optee-tz"; > > > > Since I assume this would still pass validation in the Linux kernel, > > yes, it looks like a lot of platforms are doing it wrong here and should > > be pushing this upstream. Thanks. > > Ok, so I suspect I should instead submit a similar patch against the > Kernel. > > Should I try to add something similar for other i.MX boards and stm32 > boards at the same time? So they could later be removed from u-boot. That would be much appreciated, thanks again! -- Tom [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-07-06 15:54 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-07-06 12:34 [PATCH] imx93_frdm: Add OP-TEE device tree node Mathieu Dubois-Briand 2026-07-06 14:14 ` Peter Robinson 2026-07-06 14:54 ` Mathieu Dubois-Briand 2026-07-06 14:59 ` Tom Rini 2026-07-06 15:37 ` Mathieu Dubois-Briand 2026-07-06 15:54 ` Tom Rini
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.