Re: [PATCH v4 2/9] perf c2c: add function view browser skeleton

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing explicit header inclusions for `bool`, `u64`, and `__maybe_unused`.
--

--- Patch [2]: [PATCH v4 2/9] perf c2c: add function view browser skeleton ---
commit c25169191e0e48643ab4ff1b7b22eb6d0762403b
Author: Jiebin Sun <jiebin.sun@intel.com>

perf c2c: add function view browser skeleton

This commit adds the skeleton of the c2c function view, introducing a new
TUI browser in tools/perf/ui/browsers/c2c-function.c. It wires up the entry
point, registers the file in the build, and adds the TAB key handler to the
cacheline browser.

> diff --git a/tools/perf/ui/browsers/c2c-function.c b/tools/perf/ui/browsers/c2c-function.c
> new file mode 100644
> index 0000000000000..3f6822f616004
> --- /dev/null
> +++ b/tools/perf/ui/browsers/c2c-function.c

[ ... ]

> +#include <linux/list.h>
> +#include <linux/rbtree.h>
> +#include <linux/zalloc.h>
> +
> +#include "../browser.h"

[ ... ]

> +struct perf_c2c_ext {
> +	struct c2c_hists	function_hists;
> +	/* Cached across all level-1 entries; 0 means "not yet computed". */
> +	u64			total_cycles;
> +};

[Severity: Low]
Does this file need explicit header inclusions for u64, bool, and
__maybe_unused?

Code compiled under musl libc strictly separates declarations and may fail to
build if headers are not explicitly included. Including <linux/types.h> for
u64, <stdbool.h> for bool, and <linux/compiler.h> for __maybe_unused would
ensure compatibility and prevent build breakages on environments with strict
standard library separations.

> +
> +static struct perf_c2c_ext c2c_ext __maybe_unused;
> +
> +struct c2c_function_browser {
> +	struct hist_browser	hb;
> +};
> +
> +static inline __maybe_unused u64 c2c_hitm_count(const struct c2c_stats *stats)
> +{
> +	return stats->tot_hitm;
> +}
> +
> +static inline __maybe_unused bool symbol_name_equal(struct symbol *a, struct symbol *b)
> +{
> +	/* Two unknown symbols compare equal, matching cmp_null() in util/sort.c. */

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260724095842.995920-1-jiebin.sun@intel.com?part=2