All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Stefan Dösinger" <stefandoesinger@gmail.com>
Cc: mfd@lists.linux.dev, robh@kernel.org, neil.armstrong@linaro.org,
	vkoul@kernel.org, olteanv@gmail.com, devicetree@vger.kernel.org,
	linux-phy@lists.infradead.org, lee@kernel.org,
	conor+dt@kernel.org
Subject: Re: [PATCH v8 11/12] reset: zte: Add a zx297520v3 reset driver
Date: Mon, 27 Jul 2026 19:59:47 +0000	[thread overview]
Message-ID: <20260727195947.9FB7C1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260727-zx29clk-v8-11-7a107b00f1dd@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The Kconfig entry selects MFD_SYSCON without inheriting its HAS_IOMEM dependency, risking an unmet direct dependency warning.
--

--- Patch [11]: [PATCH v8 11/12] reset: zte: Add a zx297520v3 reset driver ---
commit 12743a130823c55b091e1dd6972558ed49c19d61
Author: Stefan Dösinger <stefandoesinger@gmail.com>

reset: zte: Add a zx297520v3 reset driver

This commit adds the reset driver for ZTE zx297520v3 SoCs to drive the MFD 
child devices created by the zte-zx297520v3-crm driver.

> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index d009eb0849a3b..97f41574d81d5 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
[ ... ]
> +config RESET_ZTE_ZX297520V3
> +	tristate "ZTE zx297520v3 Reset Driver"
> +	depends on MFD_ZTE_ZX297520V3_CRM || COMPILE_TEST
> +	default SOC_ZX297520V3
> +	select MFD_SYSCON

[Severity: Medium]
Could this select statement trigger an unmet direct dependency warning?

Since this driver can be built with COMPILE_TEST, it might be compiled on
architectures like UML that do not enable HAS_IOMEM. MFD_SYSCON requires
HAS_IOMEM, so selecting it here without inheriting the HAS_IOMEM dependency
can cause Kconfig warnings and potential build failures.

Would it be better to add a dependency on HAS_IOMEM?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727-zx29clk-v8-0-7a107b00f1dd@gmail.com?part=11

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Stefan Dösinger" <stefandoesinger@gmail.com>
Cc: mfd@lists.linux.dev, robh@kernel.org, neil.armstrong@linaro.org,
	vkoul@kernel.org, olteanv@gmail.com, devicetree@vger.kernel.org,
	linux-phy@lists.infradead.org, lee@kernel.org,
	conor+dt@kernel.org
Subject: Re: [PATCH v8 11/12] reset: zte: Add a zx297520v3 reset driver
Date: Mon, 27 Jul 2026 19:59:47 +0000	[thread overview]
Message-ID: <20260727195947.9FB7C1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260727-zx29clk-v8-11-7a107b00f1dd@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The Kconfig entry selects MFD_SYSCON without inheriting its HAS_IOMEM dependency, risking an unmet direct dependency warning.
--

--- Patch [11]: [PATCH v8 11/12] reset: zte: Add a zx297520v3 reset driver ---
commit 12743a130823c55b091e1dd6972558ed49c19d61
Author: Stefan Dösinger <stefandoesinger@gmail.com>

reset: zte: Add a zx297520v3 reset driver

This commit adds the reset driver for ZTE zx297520v3 SoCs to drive the MFD 
child devices created by the zte-zx297520v3-crm driver.

> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index d009eb0849a3b..97f41574d81d5 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
[ ... ]
> +config RESET_ZTE_ZX297520V3
> +	tristate "ZTE zx297520v3 Reset Driver"
> +	depends on MFD_ZTE_ZX297520V3_CRM || COMPILE_TEST
> +	default SOC_ZX297520V3
> +	select MFD_SYSCON

[Severity: Medium]
Could this select statement trigger an unmet direct dependency warning?

Since this driver can be built with COMPILE_TEST, it might be compiled on
architectures like UML that do not enable HAS_IOMEM. MFD_SYSCON requires
HAS_IOMEM, so selecting it here without inheriting the HAS_IOMEM dependency
can cause Kconfig warnings and potential build failures.

Would it be better to add a dependency on HAS_IOMEM?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727-zx29clk-v8-0-7a107b00f1dd@gmail.com?part=11

  reply	other threads:[~2026-07-27 19:59 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27 18:24 [PATCH v8 00/12] ZTE zx297520v3 clock bindings and driver Stefan Dösinger
2026-07-27 18:24 ` Stefan Dösinger
2026-07-27 18:24 ` [PATCH v8 01/12] dt-bindings: clk: zte: Add zx297520v3 top clock and reset controller Stefan Dösinger
2026-07-27 18:24   ` Stefan Dösinger
2026-07-27 18:32   ` sashiko-bot
2026-07-27 18:32     ` sashiko-bot
2026-07-27 18:24 ` [PATCH v8 02/12] dt-bindings: clk: zte: Add zx297520v3 matrix " Stefan Dösinger
2026-07-27 18:24   ` Stefan Dösinger
2026-07-27 18:34   ` sashiko-bot
2026-07-27 18:34     ` sashiko-bot
2026-07-27 18:24 ` [PATCH v8 03/12] dt-bindings: clk: zte: Add zx297520v3 LSP " Stefan Dösinger
2026-07-27 18:24   ` Stefan Dösinger
2026-07-27 18:36   ` sashiko-bot
2026-07-27 18:36     ` sashiko-bot
2026-07-27 18:24 ` [PATCH v8 04/12] mfd: zx297520v3: Add a clock and reset MFD driver Stefan Dösinger
2026-07-27 18:24   ` Stefan Dösinger
2026-07-27 18:41   ` sashiko-bot
2026-07-27 18:41     ` sashiko-bot
2026-07-27 18:24 ` [PATCH v8 05/12] clk: zte: Add Clock registration infrastructure Stefan Dösinger
2026-07-27 18:24   ` Stefan Dösinger
2026-07-27 18:52   ` sashiko-bot
2026-07-27 18:52     ` sashiko-bot
2026-07-27 18:24 ` [PATCH v8 06/12] clk: zte: Add regmap-based clocks Stefan Dösinger
2026-07-27 18:24   ` Stefan Dösinger
2026-07-27 19:03   ` sashiko-bot
2026-07-27 19:03     ` sashiko-bot
2026-07-27 18:24 ` [PATCH v8 07/12] clk: zte: Add zx PLL support infrastructure Stefan Dösinger
2026-07-27 18:24   ` Stefan Dösinger
2026-07-27 19:15   ` sashiko-bot
2026-07-27 19:15     ` sashiko-bot
2026-07-27 18:24 ` [PATCH v8 08/12] clk: zte: Introduce a driver for zx297520v3 top clocks Stefan Dösinger
2026-07-27 18:24   ` Stefan Dösinger
2026-07-27 19:29   ` sashiko-bot
2026-07-27 19:29     ` sashiko-bot
2026-07-27 18:24 ` [PATCH v8 09/12] clk: zte: Introduce a driver for zx297520v3 matrix clocks Stefan Dösinger
2026-07-27 18:24   ` Stefan Dösinger
2026-07-27 19:41   ` sashiko-bot
2026-07-27 19:41     ` sashiko-bot
2026-07-27 18:24 ` [PATCH v8 10/12] clk: zte: Introduce a driver for zx297520v3 LSP clocks Stefan Dösinger
2026-07-27 18:24   ` Stefan Dösinger
2026-07-27 19:46   ` sashiko-bot
2026-07-27 19:46     ` sashiko-bot
2026-07-27 18:24 ` [PATCH v8 11/12] reset: zte: Add a zx297520v3 reset driver Stefan Dösinger
2026-07-27 18:24   ` Stefan Dösinger
2026-07-27 19:59   ` sashiko-bot [this message]
2026-07-27 19:59     ` sashiko-bot
2026-07-27 18:24 ` [PATCH v8 12/12] ARM: dts: zte: Declare zx297520v3 CRM device nodes Stefan Dösinger
2026-07-27 18:24   ` Stefan Dösinger
2026-07-27 20:13   ` sashiko-bot
2026-07-27 20:13     ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260727195947.9FB7C1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=mfd@lists.linux.dev \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=stefandoesinger@gmail.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.