Re: [PATCH v10 01/12] dt-bindings: clk: zte: Add zx297520v3 top clock and reset controller - sashiko-bot

From: sashiko-bot@kernel.org
To: "Stefan Dösinger" <stefandoesinger@gmail.com>
Cc: robh@kernel.org, vkoul@kernel.org, devicetree@vger.kernel.org,
	lee@kernel.org, neil.armstrong@linaro.org,
	linux-phy@lists.infradead.org, olteanv@gmail.com,
	conor+dt@kernel.org, mfd@lists.linux.dev
Subject: Re: [PATCH v10 01/12] dt-bindings: clk: zte: Add zx297520v3 top clock and reset controller
Date: Mon, 10 Aug 2026 07:12:23 +0000	[thread overview]
Message-ID: <20260810071224.5AA301F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260810-zx29clk-v10-1-63846490712c@gmail.com>

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Missing `resets` property definition in the YAML schema.
- [Medium] Missing `simple-mfd` in compatible string list for syscon with children.
--

--- Patch [1]: [PATCH v10 01/12] dt-bindings: clk: zte: Add zx297520v3 top clock and reset controller ---
commit 882e8225886a115922ab8c1c6e5b59390b7d1aa8
Author: Stefan Dösinger <stefandoesinger@gmail.com>

dt-bindings: clk: zte: Add zx297520v3 top clock and reset controller

This commit adds the device tree binding schema for the zx297520v3 top clock
and reset controller. It details the required oscillators, clock outputs, PHY
controls, and includes a child node for syscon-reboot functionality.

> diff --git a/Documentation/devicetree/bindings/clock/zte,zx297520v3-topcrm.yaml b/Documentation/devicetree/bindings/clock/zte,zx297520v3-topcrm.yaml
> new file mode 100644
> index 0000000000000..8510ffde29249
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/zte,zx297520v3-topcrm.yaml
[ ... ]
> +properties:
> +  compatible:
> +    items:
> +      - const: zte,zx297520v3-topcrm
> +      - const: syscon

[Severity: Medium]
This binding includes a syscon-reboot child node, but restricts the compatible
strings to just the specific topcrm string and "syscon". Without "simple-mfd"
in the compatible list, will the kernel's generic platform code fail to
automatically probe the reboot child node?

[Severity: Medium]
The commit message mentions a self-referencing reset property, but the
"resets" property is not explicitly defined in this properties block. Since
the schema later sets additionalProperties: false, will device trees
utilizing this self-referencing reset fail dtbs_check schema validation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260810-zx29clk-v10-0-63846490712c@gmail.com?part=1

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy