All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Stefan Dösinger" <stefandoesinger@gmail.com>
To: sashiko-reviews@lists.linux.dev, Rob Herring <robh@kernel.org>
Cc: vkoul@kernel.org, devicetree@vger.kernel.org, lee@kernel.org,
	neil.armstrong@linaro.org, linux-phy@lists.infradead.org,
	olteanv@gmail.com, conor+dt@kernel.org, mfd@lists.linux.dev
Subject: Re: [PATCH v10 01/12] dt-bindings: clk: zte: Add zx297520v3 top clock and reset controller
Date: Mon, 10 Aug 2026 21:49:27 +0300	[thread overview]
Message-ID: <gypuIvsORyye1Tbviu_vVQ@gmail.com> (raw)
In-Reply-To: <20260810153805.GA1793660-robh@kernel.org>


[-- Attachment #1.1: Type: text/plain, Size: 1135 bytes --]

Am Montag, 10. August 2026, 18:38:05 Ostafrikanische Zeit schrieb Rob Herring:
> On Mon, Aug 10, 2026 at 07:12:23AM +0000, sashiko-bot@kernel.org wrote:
> > Thank you for your contribution! Sashiko AI review found 2 potential
> > issue(s) to consider: - [Medium] Missing `resets` property definition in
> > the YAML schema. - [Medium] Missing `simple-mfd` in compatible string
> > list for syscon with children.
> Neither of these look valid to me.

Yeah, I removed the resets property in response to Krzysztof's feedback [0]. 
And the syscon-reboot is registered by the MFD driver, which in turn goes back 
to Conor's suggestion at [1].

Should I reply to the list when I think Sashiko produced a false warning? In a 
way it feels like fighting windmills, as it will likely bring up the same 
warning for further patch revisions.

It does find a lot of real problems though and as a newbie contributor I feel 
like it is a valuable tool.

Cheers,
Stefan

0: https://lore.kernel.org/linux-arm-kernel/20260717-uncovered-feathered-groundhog-eab16e@quoll/
1: https://lore.kernel.org/linux-arm-kernel/20260617-deed-snap-4649ffae0e27@spud/

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 870 bytes --]

[-- Attachment #2: Type: text/plain, Size: 112 bytes --]

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: "Stefan Dösinger" <stefandoesinger@gmail.com>
To: sashiko-reviews@lists.linux.dev, Rob Herring <robh@kernel.org>
Cc: vkoul@kernel.org, devicetree@vger.kernel.org, lee@kernel.org,
	neil.armstrong@linaro.org, linux-phy@lists.infradead.org,
	olteanv@gmail.com, conor+dt@kernel.org, mfd@lists.linux.dev
Subject: Re: [PATCH v10 01/12] dt-bindings: clk: zte: Add zx297520v3 top clock and reset controller
Date: Mon, 10 Aug 2026 21:49:27 +0300	[thread overview]
Message-ID: <gypuIvsORyye1Tbviu_vVQ@gmail.com> (raw)
In-Reply-To: <20260810153805.GA1793660-robh@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]

Am Montag, 10. August 2026, 18:38:05 Ostafrikanische Zeit schrieb Rob Herring:
> On Mon, Aug 10, 2026 at 07:12:23AM +0000, sashiko-bot@kernel.org wrote:
> > Thank you for your contribution! Sashiko AI review found 2 potential
> > issue(s) to consider: - [Medium] Missing `resets` property definition in
> > the YAML schema. - [Medium] Missing `simple-mfd` in compatible string
> > list for syscon with children.
> Neither of these look valid to me.

Yeah, I removed the resets property in response to Krzysztof's feedback [0]. 
And the syscon-reboot is registered by the MFD driver, which in turn goes back 
to Conor's suggestion at [1].

Should I reply to the list when I think Sashiko produced a false warning? In a 
way it feels like fighting windmills, as it will likely bring up the same 
warning for further patch revisions.

It does find a lot of real problems though and as a newbie contributor I feel 
like it is a valuable tool.

Cheers,
Stefan

0: https://lore.kernel.org/linux-arm-kernel/20260717-uncovered-feathered-groundhog-eab16e@quoll/
1: https://lore.kernel.org/linux-arm-kernel/20260617-deed-snap-4649ffae0e27@spud/

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 870 bytes --]

  reply	other threads:[~2026-08-10 18:49 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-09 21:28 [PATCH v10 00/12] ZTE zx297520v3 clock bindings and driver Stefan Dösinger
2026-08-09 21:28 ` Stefan Dösinger
2026-08-09 21:28 ` [PATCH v10 01/12] dt-bindings: clk: zte: Add zx297520v3 top clock and reset controller Stefan Dösinger
2026-08-09 21:28   ` Stefan Dösinger
2026-08-10  7:12   ` sashiko-bot
2026-08-10  7:12     ` sashiko-bot
2026-08-10 15:38     ` Rob Herring
2026-08-10 15:38       ` Rob Herring
2026-08-10 18:49       ` Stefan Dösinger [this message]
2026-08-10 18:49         ` Stefan Dösinger
2026-08-09 21:28 ` [PATCH v10 02/12] dt-bindings: clk: zte: Add zx297520v3 matrix " Stefan Dösinger
2026-08-09 21:28   ` Stefan Dösinger
2026-08-10  7:07   ` sashiko-bot
2026-08-10  7:07     ` sashiko-bot
2026-08-09 21:28 ` [PATCH v10 03/12] dt-bindings: clk: zte: Add zx297520v3 LSP " Stefan Dösinger
2026-08-09 21:28   ` Stefan Dösinger
2026-08-10  7:05   ` sashiko-bot
2026-08-10  7:05     ` sashiko-bot
2026-08-09 21:28 ` [PATCH v10 04/12] mfd: zx297520v3: Add a clock and reset MFD driver Stefan Dösinger
2026-08-09 21:28   ` Stefan Dösinger
2026-08-10  7:10   ` sashiko-bot
2026-08-10  7:10     ` sashiko-bot
2026-08-09 21:28 ` [PATCH v10 05/12] clk: zte: Add Clock registration infrastructure Stefan Dösinger
2026-08-09 21:28   ` Stefan Dösinger
2026-08-10  7:17   ` sashiko-bot
2026-08-10  7:17     ` sashiko-bot
2026-08-10 21:47   ` Brian Masney
2026-08-10 21:47     ` Brian Masney
2026-08-09 21:28 ` [PATCH v10 06/12] clk: zte: Add regmap-based clocks Stefan Dösinger
2026-08-09 21:28   ` Stefan Dösinger
2026-08-10  7:10   ` sashiko-bot
2026-08-10  7:10     ` sashiko-bot
2026-08-09 21:28 ` [PATCH v10 07/12] clk: zte: Add zx PLL support infrastructure Stefan Dösinger
2026-08-09 21:28   ` Stefan Dösinger
2026-08-10  7:13   ` sashiko-bot
2026-08-10  7:13     ` sashiko-bot
2026-08-10 21:56   ` Brian Masney
2026-08-10 21:56     ` Brian Masney
2026-08-09 21:28 ` [PATCH v10 08/12] clk: zte: Introduce a driver for zx297520v3 top clocks Stefan Dösinger
2026-08-09 21:28   ` Stefan Dösinger
2026-08-10  7:15   ` sashiko-bot
2026-08-10  7:15     ` sashiko-bot
2026-08-10 21:58   ` Brian Masney
2026-08-10 21:58     ` Brian Masney
2026-08-09 21:28 ` [PATCH v10 09/12] clk: zte: Introduce a driver for zx297520v3 matrix clocks Stefan Dösinger
2026-08-09 21:28   ` Stefan Dösinger
2026-08-10  7:14   ` sashiko-bot
2026-08-10  7:14     ` sashiko-bot
2026-08-10 21:59   ` Brian Masney
2026-08-10 21:59     ` Brian Masney
2026-08-09 21:28 ` [PATCH v10 10/12] clk: zte: Introduce a driver for zx297520v3 LSP clocks Stefan Dösinger
2026-08-09 21:28   ` Stefan Dösinger
2026-08-10  7:10   ` sashiko-bot
2026-08-10  7:10     ` sashiko-bot
2026-08-10 21:59   ` Brian Masney
2026-08-10 21:59     ` Brian Masney
2026-08-09 21:28 ` [PATCH v10 11/12] reset: zte: Add a zx297520v3 reset driver Stefan Dösinger
2026-08-09 21:28   ` Stefan Dösinger
2026-08-10  7:15   ` sashiko-bot
2026-08-10  7:15     ` sashiko-bot
2026-08-10  7:03 ` [PATCH v10 12/12] ARM: dts: zte: Declare zx297520v3 CRM device nodes Stefan Dösinger
2026-08-10  7:03   ` Stefan Dösinger
2026-08-10  7:11   ` sashiko-bot
2026-08-10  7:11     ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gypuIvsORyye1Tbviu_vVQ@gmail.com \
    --to=stefandoesinger@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=mfd@lists.linux.dev \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.