Re: [PATCH v2 07/14] dt-bindings: usb: qcom,snps-dwc3: Add clocks for USB3 on Qualcomm IPQ5018

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] DT schema backward compatibility violation: qcom,ipq5018-dwc3 mandates exactly 6 clocks, breaking existing High-Speed configurations.
--

--- Patch [7]: [PATCH v2 07/14] dt-bindings: usb: qcom,snps-dwc3: Add clocks for USB3 on Qualcomm IPQ5018 ---
commit 52d44d5749e478530dd0178f543b2a151efa9d68
Author: George Moussalem <george.moussalem@outlook.com>

dt-bindings: usb: qcom,snps-dwc3: Add clocks for USB3 on Qualcomm IPQ5018

This commit adds support for the aux and lfps clocks for the Qualcomm
IPQ5018 SoC in the snps-dwc3 device tree bindings. It creates a new
conditional block to specify these extra clocks and removes the compatible
string from a shared configuration.

> diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> index e59fbfc1af71b..e3e22ac8462de 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> @@ -181,6 +181,26 @@ allOf:
>              - const: sleep
>              - const: mock_utmi
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - qcom,ipq5018-dwc3
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 6

[Severity: Medium]
Will this break dtbs_check for existing High-Speed only device trees?

The commit message notes these new clocks are only required for USB
Super-Speed support, but setting minItems to 6 in the allOf conditional
block for qcom,ipq5018-dwc3 in
Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml mandates all 6
clocks for every device tree using this compatible string.

Since older configurations only provide 4 clocks, they will fail schema
validation.

Should minItems be set to 4 to preserve backward compatibility?

> +          maxItems: 6
> +        clock-names:
> +          items:
> +            - const: core
> +            - const: iface
> +            - const: sleep
> +            - const: mock_utmi
> +            - const: aux
> +            - const: lfps

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260812-ipq5018-usb3-v2-0-8f355d7ff0ef@outlook.com?part=7