Re: [PATCH v2 10/14] arm64: dts: qcom: ipq5332: Add Super-Speed UNIPHY to USB node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch introduces a reference to an undefined phandle `<&usbphy1>`, which will break devicetree compilation.
--

--- Patch [10]: [PATCH v2 10/14] arm64: dts: qcom: ipq5332: Add Super-Speed UNIPHY to USB node ---
commit 27afe7df7dfd63bf61a327eb2425e1692b59003b
Author: Praveenkumar I <quic_ipkumar@quicinc.com>

arm64: dts: qcom: ipq5332: Add Super-Speed UNIPHY to USB node

This patch adds the USB3 UNIPHY node to the USB controller node.
It also switches to the pipe clock supplied by the USB3 UNIPHY
instead of the UTMI clock.

> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> index 4c1016f5059e9..c2d384fa9df18 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> @@ -486,10 +486,8 @@ usb: usb@8a00000 {
>  					<&gcc MASTER_SNOC_USB &gcc SLAVE_SNOC_USB>;
>  			interconnect-names = "usb-ddr", "apps-usb";
>  
> -			phys = <&usbphy0>;
> -			phy-names = "usb2-phy";
> -
> -			qcom,select-utmi-as-pipe-clk;
> +			phys = <&usbphy0>, <&usbphy1>;

[Severity: Low]
Does this introduce a reference to an undefined phandle <&usbphy1>? It
appears this might break devicetree compilation with a "Reference to
non-existent node or label" error when building a board that includes
this SoC .dtsi.

> +			phy-names = "usb2-phy", "usb3-phy";
>  
>  			tx-fifo-resize;
>  			snps,is-utmi-l1-suspend;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260812-ipq5018-usb3-v2-0-8f355d7ff0ef@outlook.com?part=10

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy