Re: [PATCH 3/7] arm64: dts: rockchip: Rename rk3328 HDMI audio card

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] Changing the ALSA card name breaks existing userspace audio configurations.
--

commit 81852803c5b1ff9241b2ba92674226713005891f
Author: Detlev Casanova <detlev.casanova@collabora.com>

arm64: dts: rockchip: Rename rk3328 HDMI audio card

This commit renames the audio card for RK3328 from "HDMI" to "RK3328 HDMI"
in the device tree. The stated goal is to avoid colliding with identical
"HDMI" strings used by other Rockchip SoCs in user-visible ALSA fields.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> @@ -207,7 +207,7 @@ hdmi_sound: hdmi-sound {
>  		compatible = "simple-audio-card";
>  		simple-audio-card,format = "i2s";
>  		simple-audio-card,mclk-fs = <128>;
> -		simple-audio-card,name = "HDMI";
> +		simple-audio-card,name = "RK3328 HDMI";

[Severity: Critical]
Does this change break existing userspace audio configurations?

When the system boots with the updated device tree in hdmi_sound, the ALSA
core registers the card with the new "RK3328 HDMI" name. ALSA state
restoration tools (alsactl), Use Case Manager (UCM) profiles, and audio
servers like PulseAudio and PipeWire rely on this exact string to identify
the hardware, load appropriate rules, and restore mixer states.

Since this sound card name has been established in previous releases,
userspace tools attempting to match the old "HDMI" name will fail to apply
their configurations. Modifying an established user-visible identifier can
constitute an ABI breakage, causing audio regressions for any system using
the RK3328 SoC that upgrades to this device tree.

>  		status = "disabled";
>  
>  		simple-audio-card,cpu {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-fix-rockchip-hdmi-audio-names-v1-0-5b155ae05293@collabora.com?part=3