Re: [PATCH 4/7] arm64: dts: rockchip: Rename rk3399 HDMI audio card

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] Changing the ALSA sound card name breaks userspace audio configurations and constitutes an ABI regression.
- [Medium] The commit message claims the new name matches the Rockchip family naming scheme, which is demonstrably false.
--

commit d9591718c98e7ed37b2a63128b5ae03809c98902
Author: Detlev Casanova <detlev.casanova@collabora.com>

arm64: dts: rockchip: Rename rk3399 HDMI audio card

This commit renames the HDMI audio card in the RK3399 device tree from
"hdmi-sound" to "RK3399 HDMI". The stated goal is to better identify the SoC
in ALSA fields and match naming conventions across the rest of the Rockchip
family.

>     Rename the card from "hdmi-sound" to "RK3399 HDMI" so it identifies
>     the SoC in user-visible ALSA fields and matches the naming scheme
>     used across the rest of the Rockchip family.

[Severity: Medium]
Is this description accurate?

Looking at the baseline tree, all other Rockchip base device trees use generic
HDMI names without an SoC prefix (e.g., "HDMI" in rk3328, rk356x, and rk3576;
"hdmi0" in rk3588).

Since the series itself introduces the SoC prefix to these other files in
subsequent patches, it seems no such naming scheme existed across the rest of
the family at the time of this commit. Could the commit message be more
precise about the motivation?

> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi
> index 49c68fe65de66..c46e58d4af0d4 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi
> @@ -2008,7 +2008,7 @@ hdmi_sound: hdmi-sound {
>  		compatible = "simple-audio-card";
>  		simple-audio-card,format = "i2s";
>  		simple-audio-card,mclk-fs = <256>;
> -		simple-audio-card,name = "hdmi-sound";
> +		simple-audio-card,name = "RK3399 HDMI";

[Severity: High]
Does changing the user-visible ALSA card name constitute an ABI regression?

Userspace audio frameworks like PulseAudio or ALSA UCM use the ALSA card name
to identify the device and apply correct mixer and routing profiles. Changing
simple-audio-card,name alters this user-visible identifier.

Existing userspace configurations on the widely deployed RK3399 platform that
match on "hdmi-sound" will fail on boot, resulting in broken audio
out-of-the-box and violating the kernel's rules regarding userspace ABI
regressions.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-fix-rockchip-hdmi-audio-names-v1-0-5b155ae05293@collabora.com?part=4