Re: [PATCH 5/7] arm64: dts: rockchip: Rename rk356x HDMI audio card

From: Detlev Casanova <detlev.casanova@collabora.com>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Johan Jonker <jbx6244@gmail.com>, Alex Bee <knaerzche@gmail.com>,
	Christian Hewitt <christianshewitt@gmail.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
	Nicolas Frattaroli <nicolas.frattaroli@collabora.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Diederik de Haas <diederik@cknow-tech.com>
Cc: kernel@collabora.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] arm64: dts: rockchip: Rename rk356x HDMI audio card
Date: Mon, 31 Aug 2026 16:07:37 -0400	[thread overview]
Message-ID: <1l5cQ5HdTvCBGiUCVh40og@collabora.com> (raw)
In-Reply-To: <DL3B1XH7K4WC.1ZXA6ANI8Q1A0@cknow-tech.com>

On Monday, 31 August 2026 13:29:00 EDT Diederik de Haas wrote:
> On Mon Aug 31, 2026 at 4:20 PM CEST, Detlev Casanova wrote:
> > Rename the card from "HDMI" to "RK356x HDMI" so it identifies the SoC
> > in user-visible ALSA fields and no longer collides with the identical
> > "HDMI" string used by other Rockchip SoCs.
> > 
> > Fixes: 697ee8546e241 ("arm64: dts: rockchip: Add HDMI audio nodes to
> > rk356x") Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
> > ---
> > 
> >  arch/arm64/boot/dts/rockchip/rk356x-base.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> > b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi index
> > a5832895bd39..98785c812fc4 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> > @@ -150,7 +150,7 @@ scmi_clk: protocol@14 {
> > 
> >  	hdmi_sound: hdmi-sound {
> >  	
> >  		compatible = "simple-audio-card";
> > 
> > -		simple-audio-card,name = "HDMI";
> > +		simple-audio-card,name = "RK356x HDMI";
> 
> Move the name property to rk3566.dtsi and rk3568.dtsi and use their actual
> SoC name, thus RK3566 and RK3568?

I hesitated on this one but I agree with you, it's better to have more 
granularity. Will update in v2.

Detlev.

> Cheers,
>   Diederik
> 
> >  		simple-audio-card,format = "i2s";
> >  		simple-audio-card,mclk-fs = <256>;
> >  		status = "disabled";

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip