Re: [PATCH 5/7] arm64: dts: rockchip: Rename rk356x HDMI audio card

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] ABI Breakage: Renaming ALSA sound card breaks existing user-space audio configurations
--

commit 09adc9bbc18df386e17d8391018eada18c2a6d2a
Author: Detlev Casanova <detlev.casanova@collabora.com>

arm64: dts: rockchip: Rename rk356x HDMI audio card

This commit modifies the ALSA sound card name exposed by the device tree 
from "HDMI" to "RK356x HDMI" to avoid collisions with other Rockchip SoCs.

> diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> index a5832895bd392..98785c812fc40 100644
> --- a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> @@ -150,7 +150,7 @@ scmi_clk: protocol@14 {
>  
>  	hdmi_sound: hdmi-sound {
>  		compatible = "simple-audio-card";
> -		simple-audio-card,name = "HDMI";
> +		simple-audio-card,name = "RK356x HDMI";

[Severity: Critical]
Is it safe to change the ALSA card name exposed to userspace? 

The simple-audio-card,name property in hdmi_sound defines the exact sound
card name seen by userspace via ALSA. Changing this string from HDMI to
RK356x HDMI might break backwards compatibility with existing userspace audio
configurations, such as ALSA UCM profiles, PipeWire rules, or PulseAudio
matchers that rely on the established generic name. 

A user booting an updated kernel on an rk356x platform using existing UCM
profiles could experience broken audio unconditionally upon boot. Does this
change violate the kernel's policy against breaking userspace ABI?

>  		simple-audio-card,format = "i2s";
>  		simple-audio-card,mclk-fs = <256>;
>  		status = "disabled";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-fix-rockchip-hdmi-audio-names-v1-0-5b155ae05293@collabora.com?part=5