All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: zbigniew.kempczynski@intel.com, andrzej.hajda@intel.com,
	Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
Subject: [PATCH i-g-t 0/2] Derive write-through availability from the PAT config
Date: Fri,  4 Sep 2026 14:26:48 +0530	[thread overview]
Message-ID: <20260904085650.98553-1-sujaritha.sundaresan@intel.com> (raw)

Not every platform has a write-through entry in its PAT table. Where
there is none the KMD reports the UC index for XE_CACHE_WT, so a test
which asks for write-through quietly gets uncached instead, re-running
coverage it already has under a misleading name. Spotting that currently
means enumerating IP versions in the test, which needs revisiting for
every new platform.

Patch 1 adds intel_pat_has_wt(), which answers the question from the PAT
config itself: a WT index which aliases UC means there is no distinct
write-through entry. Patch 2 uses it to skip the write-through checks in
xe_pat where there is nothing to exercise, so they report an honest skip
rather than a pass.

Following the library guidance in CONTRIBUTING.md, the helper is a plain
query: no igt_require()/igt_skip() in the library, the tests decide what
to do with the answer.

intel_get_pat_idx_wt() itself is deliberately left alone here. Having it
return XE_PAT_IDX_INVALID rather than the UC index is the stricter fix
and probably the right end state, but it changes behaviour for the
callers in kms_ccs and xe_exec_system_allocator as well, so it seems
better as a follow-up once the helper is in tree.

No functional change intended for platforms which do have a write-through
PAT index.

Sujaritha Sundaresan (2):
  lib/intel_pat: add intel_pat_has_wt()
  tests/intel/xe_pat: skip the write-through checks without a WT index

 lib/intel_pat.c      | 22 ++++++++++++++++++++++
 lib/intel_pat.h      |  2 ++
 tests/intel/xe_pat.c | 38 ++++++++++++++++++++++----------------
 3 files changed, 46 insertions(+), 16 deletions(-)

-- 
2.34.1


             reply	other threads:[~2026-09-04  8:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04  8:56 Sujaritha Sundaresan [this message]
2026-09-04  8:56 ` [PATCH i-g-t 1/2] lib/intel_pat: add intel_pat_has_wt() Sujaritha Sundaresan
2026-09-08  6:09   ` Hajda, Andrzej
2026-09-08  6:21     ` Sundaresan, Sujaritha
2026-09-04  8:56 ` [PATCH i-g-t 2/2] tests/intel/xe_pat: skip the write-through checks without a WT index Sujaritha Sundaresan
2026-09-08  6:18   ` Hajda, Andrzej
2026-09-04  9:33 ` ✓ Xe.CI.BAT: success for Derive write-through availability from the PAT config Patchwork
2026-09-04  9:43 ` ✗ i915.CI.BAT: failure " Patchwork
2026-09-04 20:10 ` ✗ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260904085650.98553-1-sujaritha.sundaresan@intel.com \
    --to=sujaritha.sundaresan@intel.com \
    --cc=andrzej.hajda@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.