From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: qemu-devel@nongnu.org
Cc: "John Snow" <jsnow@redhat.com>, "Denis V. Lunev" <den@openvz.org>,
"Fabiano Rosas" <farosas@suse.de>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-block@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <th.huth+qemu@posteo.eu>,
"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
qemu-arm@nongnu.org, "Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Eric Farman" <farman@linux.ibm.com>,
"Matthew Rosato" <mjrosato@linux.ibm.com>,
"Cornelia Huck" <cohuck@redhat.com>,
qemu-s390x@nongnu.org, "Daniel P. Berrangé" <berrange@redhat.com>,
"Glenn Miles" <milesg@linux.ibm.com>,
qemu-ppc@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PATCH 7/9] qtest: compile out HMP helper when !CONFIG_HMP
Date: Sun, 06 Sep 2026 12:42:38 +0400 [thread overview]
Message-ID: <20260906-nohmp-v1-7-daee96491c43@redhat.com> (raw)
In-Reply-To: <20260906-nohmp-v1-0-daee96491c43@redhat.com>
This should help prevent introducing HMP tests inadvertently.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
tests/qtest/libqtest.c | 2 ++
tests/qtest/libqtest.h | 2 ++
2 files changed, 4 insertions(+)
diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
index 370f79a3b6fb..05d884761540 100644
--- a/tests/qtest/libqtest.c
+++ b/tests/qtest/libqtest.c
@@ -1021,6 +1021,7 @@ void qtest_qmp_job_wait(QTestState *s, const char *job_id)
qobject_unref(response);
}
+#ifdef CONFIG_HMP
char *qtest_vhmp(QTestState *s, const char *fmt, va_list ap)
{
char *cmd;
@@ -1048,6 +1049,7 @@ char *qtest_hmp(QTestState *s, const char *fmt, ...)
va_end(ap);
return ret;
}
+#endif
void qtest_qemu_io(QTestState *s, const char *device,
const char *fmt, ...)
diff --git a/tests/qtest/libqtest.h b/tests/qtest/libqtest.h
index f06e061d214b..20982d3fe8dd 100644
--- a/tests/qtest/libqtest.h
+++ b/tests/qtest/libqtest.h
@@ -409,6 +409,7 @@ QDict *qtest_qmp_event_ref(QTestState *s, const char *event);
*/
void qtest_qmp_job_wait(QTestState *s, const char *job_id);
+#ifdef CONFIG_HMP
/**
* qtest_hmp:
* @s: #QTestState instance to operate on.
@@ -434,6 +435,7 @@ char *qtest_hmp(QTestState *s, const char *fmt, ...) G_GNUC_PRINTF(2, 3);
*/
char *qtest_vhmp(QTestState *s, const char *fmt, va_list ap)
G_GNUC_PRINTF(2, 0);
+#endif
/**
* qtest_qemu_io:
--
2.55.0.543.g5ebe2ebe4ea8
next prev parent reply other threads:[~2026-09-06 8:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 8:42 [PATCH 0/9] Make HMP optional - follow-up Marc-André Lureau
2026-09-06 8:42 ` [PATCH 1/9] tests/ahci-test: replace HMP usage with QMP Marc-André Lureau
2026-09-07 9:24 ` Daniel P. Berrangé
2026-09-06 8:42 ` [PATCH 2/9] tests/functional: replace HMP " Marc-André Lureau
2026-09-06 11:06 ` Thomas Huth
2026-09-07 10:16 ` Marc-André Lureau
2026-09-06 8:42 ` [PATCH 3/9] tests/functional/s390x: use QMP for balloon Marc-André Lureau
2026-09-06 11:07 ` Thomas Huth
2026-09-07 9:29 ` Daniel P. Berrangé
2026-09-06 8:42 ` [PATCH 4/9] tests/qtest: add qtest_qmp_job_wait() Marc-André Lureau
2026-09-07 9:50 ` Daniel P. Berrangé
2026-09-07 10:13 ` Marc-André Lureau
2026-09-07 10:16 ` Daniel P. Berrangé
2026-09-06 8:42 ` [PATCH 5/9] tests/ide-test: convert to QMP Marc-André Lureau
2026-09-07 9:33 ` Daniel P. Berrangé
2026-09-06 8:42 ` [PATCH 6/9] tests/drive_del-test: compile out HMP-dependent tests when !CONFIG_HMP Marc-André Lureau
2026-09-07 9:44 ` Daniel P. Berrangé
2026-09-06 8:42 ` Marc-André Lureau [this message]
2026-09-07 9:44 ` [PATCH 7/9] qtest: compile out HMP helper " Daniel P. Berrangé
2026-09-06 8:42 ` [PATCH 8/9] tests/functional: add skipTestIfNoHMP() helper Marc-André Lureau
2026-09-06 11:08 ` Thomas Huth
2026-09-06 8:42 ` [PATCH 9/9] tests/functional: fix some tests that require HMP Marc-André Lureau
2026-09-06 11:10 ` Thomas Huth
2026-09-07 9:45 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260906-nohmp-v1-7-daee96491c43@redhat.com \
--to=marcandre.lureau@redhat.com \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=den@openvz.org \
--cc=farman@linux.ibm.com \
--cc=farosas@suse.de \
--cc=jsnow@redhat.com \
--cc=lvivier@redhat.com \
--cc=milesg@linux.ibm.com \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@oss.qualcomm.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=th.huth+qemu@posteo.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.