Re: [PATCH 2/9] tests/functional: replace HMP with QMP

[Thomas Huth <th.huth+qemu@posteo.eu>]

Am Sun, 06 Sep 2026 12:42:33 +0400
schrieb Marc-André Lureau <marcandre.lureau@redhat.com>:

> Replace HMP with QMP equivalent.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  tests/functional/arm/test_integratorcp.py | 7 ++-----
>  tests/functional/m68k/test_nextcube.py    | 5 +----
>  tests/functional/mips64el/test_malta.py   | 7 ++-----
>  3 files changed, 5 insertions(+), 14 deletions(-)
> 
> diff --git a/tests/functional/arm/test_integratorcp.py b/tests/functional/arm/test_integratorcp.py
> index 23ae919359d5..fefed26266f4 100755
> --- a/tests/functional/arm/test_integratorcp.py
> +++ b/tests/functional/arm/test_integratorcp.py
> @@ -72,11 +72,8 @@ def test_framebuffer_tux_logo(self):
>          self.boot_integratorcp()
>          framebuffer_ready = 'Console: switching to colour frame buffer device'
>          wait_for_console_pattern(self, framebuffer_ready)
> -        self.vm.cmd('human-monitor-command', command_line='stop')
> -        res = self.vm.cmd('human-monitor-command',
> -                          command_line='screendump %s' % screendump_path)
> -        if 'unknown command' in res:
> -            self.skipTest('screendump not available')
> +        self.vm.cmd('stop')
> +        self.vm.cmd('screendump', filename=screendump_path)

screendump is an optional command - it is only available if CONFIG_PIXMAN
is enabled. That's why there was a check for "unknown command" here.
Does your new code still works if pixman is disabled?

 Thomas