From: Thomas Huth <th.huth+qemu@posteo.eu>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, "John Snow" <jsnow@redhat.com>,
"Denis V. Lunev" <den@openvz.org>,
"Fabiano Rosas" <farosas@suse.de>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-block@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
qemu-arm@nongnu.org, "Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Eric Farman" <farman@linux.ibm.com>,
"Matthew Rosato" <mjrosato@linux.ibm.com>,
"Cornelia Huck" <cohuck@redhat.com>,
qemu-s390x@nongnu.org, "Daniel P. Berrangé" <berrange@redhat.com>,
"Glenn Miles" <milesg@linux.ibm.com>,
qemu-ppc@nongnu.org
Subject: Re: [PATCH 8/9] tests/functional: add skipTestIfNoHMP() helper
Date: Sun, 06 Sep 2026 11:08:32 +0000 [thread overview]
Message-ID: <20260906130829.5926f44d@tpx1> (raw)
In-Reply-To: <20260906-nohmp-v1-8-daee96491c43@redhat.com>
Am Sun, 06 Sep 2026 12:42:39 +0400
schrieb Marc-André Lureau <marcandre.lureau@redhat.com>:
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> tests/functional/qemu_test/testcase.py | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu_test/testcase.py
> index 69d3d06cc0e3..bf2dc1dc101c 100644
> --- a/tests/functional/qemu_test/testcase.py
> +++ b/tests/functional/qemu_test/testcase.py
> @@ -369,6 +369,12 @@ def require_accelerator(self, accelerator):
> self.skipTest("%s accelerator does not seem to be "
> "available" % accelerator)
>
> + def skipTestIfNoHMP(self):
> + commands = self.vm.cmd('query-commands')
> + if not any(cmd['name'] == 'human-monitor-command'
> + for cmd in commands):
> + self.skipTest('HMP support is not available')
> +
> def require_netdev(self, netdevname):
> helptxt = run([self.qemu_bin, '-M', 'none', '-netdev', 'help'],
> capture_output=True, check=True, encoding='utf8').stdout
>
Reviewed-by: Thomas Huth <th.huth+qemu@posteo.eu>
next prev parent reply other threads:[~2026-09-06 11:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 8:42 [PATCH 0/9] Make HMP optional - follow-up Marc-André Lureau
2026-09-06 8:42 ` [PATCH 1/9] tests/ahci-test: replace HMP usage with QMP Marc-André Lureau
2026-09-07 9:24 ` Daniel P. Berrangé
2026-09-06 8:42 ` [PATCH 2/9] tests/functional: replace HMP " Marc-André Lureau
2026-09-06 11:06 ` Thomas Huth
2026-09-07 10:16 ` Marc-André Lureau
2026-09-06 8:42 ` [PATCH 3/9] tests/functional/s390x: use QMP for balloon Marc-André Lureau
2026-09-06 11:07 ` Thomas Huth
2026-09-07 9:29 ` Daniel P. Berrangé
2026-09-06 8:42 ` [PATCH 4/9] tests/qtest: add qtest_qmp_job_wait() Marc-André Lureau
2026-09-07 9:50 ` Daniel P. Berrangé
2026-09-07 10:13 ` Marc-André Lureau
2026-09-07 10:16 ` Daniel P. Berrangé
2026-09-06 8:42 ` [PATCH 5/9] tests/ide-test: convert to QMP Marc-André Lureau
2026-09-07 9:33 ` Daniel P. Berrangé
2026-09-06 8:42 ` [PATCH 6/9] tests/drive_del-test: compile out HMP-dependent tests when !CONFIG_HMP Marc-André Lureau
2026-09-07 9:44 ` Daniel P. Berrangé
2026-09-06 8:42 ` [PATCH 7/9] qtest: compile out HMP helper " Marc-André Lureau
2026-09-07 9:44 ` Daniel P. Berrangé
2026-09-06 8:42 ` [PATCH 8/9] tests/functional: add skipTestIfNoHMP() helper Marc-André Lureau
2026-09-06 11:08 ` Thomas Huth [this message]
2026-09-06 8:42 ` [PATCH 9/9] tests/functional: fix some tests that require HMP Marc-André Lureau
2026-09-06 11:10 ` Thomas Huth
2026-09-07 9:45 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260906130829.5926f44d@tpx1 \
--to=th.huth+qemu@posteo.eu \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=den@openvz.org \
--cc=farman@linux.ibm.com \
--cc=farosas@suse.de \
--cc=jsnow@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=milesg@linux.ibm.com \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@oss.qualcomm.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.