Re: [PATCH 4/9] tests/qtest: add qtest_qmp_job_wait()

["Daniel P. Berrangé" <berrange@redhat.com>]

On Sun, Sep 06, 2026 at 12:42:35PM +0400, Marc-André Lureau wrote:
> Add a helper to wait for job conclusion, used in next changes.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  tests/qtest/libqtest.c | 37 +++++++++++++++++++++++++++++++++++++
>  tests/qtest/libqtest.h | 11 +++++++++++
>  2 files changed, 48 insertions(+)
> 
> diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
> index 28bb72bfaecf..370f79a3b6fb 100644
> --- a/tests/qtest/libqtest.c
> +++ b/tests/qtest/libqtest.c
> @@ -984,6 +984,43 @@ void qtest_qmp_eventwait(QTestState *s, const char *event)
>      qobject_unref(response);
>  }
>  
> +void qtest_qmp_job_wait(QTestState *s, const char *job_id)
> +{
> +    QDict *response, *data, *error;
> +    QList *jobs;
> +    const QListEntry *entry;
> +
> +    for (;;) {
> +        response = qtest_qmp_eventwait_ref(s, "JOB_STATUS_CHANGE");
> +        data = qdict_get_qdict(response, "data");
> +        if (!strcmp(qdict_get_str(data, "id"), job_id) &&
> +            !strcmp(qdict_get_str(data, "status"), "concluded")) {



> +            qobject_unref(response);
> +            break;
> +        }
> +        qobject_unref(response);
> +    }
> +
> +    response = qtest_qmp(s, "{ 'execute': 'query-jobs' }");
> +    g_assert(qdict_haskey(response, "return"));
> +    jobs = qobject_to(QList, qdict_get(response, "return"));
> +    g_assert(jobs);
> +    QLIST_FOREACH_ENTRY(jobs, entry) {
> +        QDict *job = qobject_to(QDict, qlist_entry_obj(entry));
> +        if (!strcmp(qdict_get_str(job, "id"), job_id)) {
> +            g_assert_null(qdict_get_try_str(job, "error"));

If "job" did contain "error", then wouldn't we have hit
a SEGV in the qdict_get_str() call due to missing 'id'
field.

IOW, we should likely validate this is NOT an error
response first.


> +            break;
> +        }
> +    }
> +    qobject_unref(response);
> +
> +    response = qtest_qmp(s,
> +        "{ 'execute': 'job-dismiss', 'arguments': { 'id': %s } }", job_id);
> +    error = qdict_get_qdict(response, "error");
> +    g_assert_null(error);
> +    qobject_unref(response);
> +}
> +

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|