Re: [PATCH v2 01/13] drm/xe/log: Add VRAM, PAT, and HWMON DRIVER_HARDWARE components

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The VRAM log component is incorrectly named "Virtual RAM" instead of "Video RAM" in the macro definition.
--

commit 7e2394ed2d7e6aa2312536fe5e3e318f1713fb04
Author: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>

drm/xe/log: Add VRAM, PAT, and HWMON DRIVER_HARDWARE components

This commit registers new DRIVER_HARDWARE log components for VRAM, PAT, and
HWMON subsystems to enable structured error reporting. It assigns them IDs
and string names for use in the ABI.

> diff --git a/drivers/gpu/drm/xe/abi/xe_log_abi.h b/drivers/gpu/drm/xe/abi/xe_log_abi.h
> index d6105520173e7..4a60aa48fab19 100644
> --- a/drivers/gpu/drm/xe/abi/xe_log_abi.h
> +++ b/drivers/gpu/drm/xe/abi/xe_log_abi.h
[ ... ]
> @@ -150,6 +150,9 @@ enum xe_log_location_bits {
>  	define(DRIVER_HARDWARE, 3, GT, GT_TDR, "Graphics Technology")		\
>  	define(DRIVER_HARDWARE, 4, LMTT, IO_BUS, "LMEM Translation Table")	\
>  	define(DRIVER_HARDWARE, 5, MEMIRQ, IO_BUS, "Memory Based IRQ")		\
> +	define(DRIVER_HARDWARE, 6, VRAM, IO_BUS, "Virtual RAM")			\

[Severity: Low]
Is the string name for this component correct? VRAM typically stands for
"Video RAM" rather than "Virtual RAM" in the context of hardware subsystems.
The commit message describes it as "Video RAM access", but this ABI definition
exposes it as "Virtual RAM" in structured error logs.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908101849.1219614-1-dnyaneshwar.bhadane@intel.com?part=1