Re: [PATCH v2 10/13] drm/xe/pci: Report unknown GMDID versions using structured xe_log API

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch uses the 'REGS' component tag instead of the 'GT' tag claimed in the commit message.
--

commit 5fd6d40222829ad569de8cdf73c334a89531ce68
Author: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>

drm/xe/pci: Report unknown GMDID versions using structured xe_log API

This commit updates the GMDID handling code to replace drm_err() with the
structured xe_log_err() function when hardware reports unrecognized graphics
or media IP versions.

> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -718,8 +718,9 @@ static int handle_gmdid(struct xe_device *xe,
>  
>  	*graphics_ip = find_graphics_ip(ver);
>  	if (!*graphics_ip) {
> -		drm_err(&xe->drm, "Hardware reports unknown graphics version %u.%02u\n",
> -			ver / 100, ver % 100);
> +		xe_log_err(xe, REGS, -EINVAL,
> +			   "Hardware reports unknown graphics version %u.%02u\n",
> +			   ver / 100, ver % 100);

[Severity: Medium]
The commit message states this replaces drm_err() with xe_log_err() "using
the GT component tag". However, handle_gmdid() uses the REGS tag here.
Should this use the GT tag as described in the commit message, or is REGS
the intended tag for this log?

>  	}
>  
>  	ret = read_gmdid(xe, GMDID_MEDIA, &ver, media_revid);
> @@ -732,8 +733,9 @@ static int handle_gmdid(struct xe_device *xe,
>  
>  	*media_ip = find_media_ip(ver);
>  	if (!*media_ip) {
> -		drm_err(&xe->drm, "Hardware reports unknown media version %u.%02u\n",
> -			ver / 100, ver % 100);
> +		xe_log_err(xe, REGS, -EINVAL,
> +			   "Hardware reports unknown media version %u.%02u\n",
> +			   ver / 100, ver % 100);

[Severity: Medium]
Similarly, this uses the REGS tag for the unknown media version error. Does
this also need to be updated to use the GT tag to match the commit
description?

>  	}
>  
>  	return 0;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908101849.1219614-1-dnyaneshwar.bhadane@intel.com?part=10