Re: [PATCH v2 05/13] drm/xe/memirq: Report errors using structured xe_log API

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `memirq_err` macro definition was left behind as dead code after all of its usages were replaced.
--

commit 391745f6a990d1f601917ad8a478f9eb84f04e45
Author: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>

drm/xe/memirq: Report errors using structured xe_log API

Replace memirq_err() calls with xe_log_err() using the MEMIRQ
component tag for memory-based IRQ failures

> diff --git a/drivers/gpu/drm/xe/xe_memirq.c b/drivers/gpu/drm/xe/xe_memirq.c
> index 9dfe965cb46ec..32b9f87a10ecf 100644
> --- a/drivers/gpu/drm/xe/xe_memirq.c
> +++ b/drivers/gpu/drm/xe/xe_memirq.c
> @@ -232,7 +233,7 @@ static int memirq_alloc_pages(struct xe_memirq *memirq)
>  	return 0;
>  
>  out:
> -	memirq_err(memirq, "Failed to allocate memirq page (%pe)\n", ERR_PTR(err));
> +	xe_log_err(tile, MEMIRQ, err, "Failed to allocate memirq page\n");
>  	return err;
>  }

[Severity: Low]
Should the memirq_err() macro definition also be removed?

Since this patch replaced all of its usages, the macro definition at the top
of drivers/gpu/drm/xe/xe_memirq.c is left behind as unused dead code:

#define memirq_err(m, _fmt, ...)	memirq_printk(m, err, _fmt, ##__VA_ARGS__)

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908101849.1219614-1-dnyaneshwar.bhadane@intel.com?part=5