Re: [PATCH v2 09/13] drm/xe/pat: Report missing PAT table using structured xe_log API

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Inconsistent error code between structured log and function return value
--

commit 3f9326bca2893681a5346e8107dec4ac43a4112b
Author: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>

drm/xe/pat: Report missing PAT table using structured xe_log API

This commit replaces the standard drm_err() logging with the structured
xe_log_err() API using the PAT component tag for platforms that do not
have a matching PAT table entry.

> diff --git a/drivers/gpu/drm/xe/xe_pat.c b/drivers/gpu/drm/xe/xe_pat.c
> index 8af92e3c4c17c..f012eaba838a2 100644
> --- a/drivers/gpu/drm/xe/xe_pat.c
> +++ b/drivers/gpu/drm/xe/xe_pat.c

[ ... ]

> @@ -678,8 +679,9 @@ int xe_pat_init_early(struct xe_device *xe)
>  		xe->pat.idx[XE_CACHE_WT] = 2;
>  		xe->pat.idx[XE_CACHE_WB] = 0;
>  	} else {
> -		drm_err(&xe->drm, "Missing PAT table for platform with graphics version %d.%02d!\n",
> -			GRAPHICS_VER(xe), GRAPHICS_VERx100(xe) % 100);
> +		xe_log_err(xe, PAT, -EINVAL,
> +			   "Missing PAT table for platform with graphics version %d.%02d!\n",
> +			   GRAPHICS_VER(xe), GRAPHICS_VERx100(xe) % 100);
>  		return -ENODATA;

[Severity: Low]
Does this code intentionally log -EINVAL but return -ENODATA? Reaching the
end of the platform matching chain in xe_pat_init_early() logs one error
code (-EINVAL) to the structured telemetry API but returns a different one
(-ENODATA) to its caller. Would it be better to align these error codes to
prevent confusion during debugging or automated log analysis?

>  
>  	}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908101849.1219614-1-dnyaneshwar.bhadane@intel.com?part=9