From: David Vrabel <david.vrabel@nutanix.com>
To: David Vrabel <david.vrabel@nutanix.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Zhao Liu <zhao1.liu@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH v2 2/4] hw/pci-bridge: Make speed and width for PCIe ports non-experimental
Date: Tue, 8 Sep 2026 15:52:25 +0000 [thread overview]
Message-ID: <20260908155223.164787-3-david.vrabel@nutanix.com> (raw)
In-Reply-To: <20260908155223.164787-1-david.vrabel@nutanix.com>
For guests with passthrough PCIe devices, in order to make the guest
PCIe topology have the same apparent bandwidth as the underlying
hardware we need to be able to set the capabilities (speed and width)
of the virtual root, upstream, and downstream ports.
Promote the existing experimental `x-speed` and `x-width` options to
non-experimental `speed` and `width`.
Signed-off-by: David Vrabel <david.vrabel@nutanix.com>
---
hw/pci-bridge/gen_pcie_downstream_port.c | 4 ++--
hw/pci-bridge/gen_pcie_root_port.c | 4 ++--
hw/pci-bridge/gen_pcie_upstream_port.c | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/pci-bridge/gen_pcie_downstream_port.c b/hw/pci-bridge/gen_pcie_downstream_port.c
index d593846ac1..8fe71382aa 100644
--- a/hw/pci-bridge/gen_pcie_downstream_port.c
+++ b/hw/pci-bridge/gen_pcie_downstream_port.c
@@ -163,9 +163,9 @@ static const VMStateDescription vmstate_gen_pcie_downstream_port = {
static const Property gen_pcie_downstream_port_props[] = {
DEFINE_PROP_BIT(COMPAT_PROP_PCP, PCIDevice, cap_present,
QEMU_PCIE_SLTCAP_PCP_BITNR, true),
- DEFINE_PROP_PCIE_LINK_SPEED("x-speed", PCIESlot,
+ DEFINE_PROP_PCIE_LINK_SPEED("speed", PCIESlot,
speed, PCIE_LINK_SPEED_64),
- DEFINE_PROP_PCIE_LINK_WIDTH("x-width", PCIESlot,
+ DEFINE_PROP_PCIE_LINK_WIDTH("width", PCIESlot,
width, PCIE_LINK_WIDTH_32),
};
diff --git a/hw/pci-bridge/gen_pcie_root_port.c b/hw/pci-bridge/gen_pcie_root_port.c
index 5434d693d9..d3ace7f0db 100644
--- a/hw/pci-bridge/gen_pcie_root_port.c
+++ b/hw/pci-bridge/gen_pcie_root_port.c
@@ -129,9 +129,9 @@ static const Property gen_rp_props[] = {
res_reserve.mem_pref_32, -1),
DEFINE_PROP_SIZE("pref64-reserve", GenPCIERootPort,
res_reserve.mem_pref_64, -1),
- DEFINE_PROP_PCIE_LINK_SPEED("x-speed", PCIESlot,
+ DEFINE_PROP_PCIE_LINK_SPEED("speed", PCIESlot,
speed, PCIE_LINK_SPEED_16),
- DEFINE_PROP_PCIE_LINK_WIDTH("x-width", PCIESlot,
+ DEFINE_PROP_PCIE_LINK_WIDTH("width", PCIESlot,
width, PCIE_LINK_WIDTH_32),
};
diff --git a/hw/pci-bridge/gen_pcie_upstream_port.c b/hw/pci-bridge/gen_pcie_upstream_port.c
index 57d7e09485..edd5bfcafc 100644
--- a/hw/pci-bridge/gen_pcie_upstream_port.c
+++ b/hw/pci-bridge/gen_pcie_upstream_port.c
@@ -139,9 +139,9 @@ static const VMStateDescription vmstate_gen_pcie_upstream_port = {
};
static const Property gen_pcie_upstream_port_props[] = {
- DEFINE_PROP_PCIE_LINK_SPEED("x-speed", GenPCIEUpstreamPort,
+ DEFINE_PROP_PCIE_LINK_SPEED("speed", GenPCIEUpstreamPort,
speed, PCIE_LINK_SPEED_64),
- DEFINE_PROP_PCIE_LINK_WIDTH("x-width", GenPCIEUpstreamPort,
+ DEFINE_PROP_PCIE_LINK_WIDTH("width", GenPCIEUpstreamPort,
width, PCIE_LINK_WIDTH_32),
};
--
2.43.0
next prev parent reply other threads:[~2026-09-08 15:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 15:52 [PATCH v2 0/4] hw/pci-bridge: Configurable apparent bandwidth for the PCIe topology David Vrabel
2026-09-08 15:52 ` David Vrabel [this message]
2026-09-08 15:52 ` [PATCH v2 1/4] hw/pci-bridge: Add generic PCIe switch upstream and downstream ports David Vrabel
2026-09-08 16:05 ` David Vrabel
2026-09-09 15:14 ` Gerd Hoffmann
2026-09-08 15:52 ` [PATCH v2 3/4] hw/pci-bridge: Default the generic PCIe root port as Gen6 capable David Vrabel
2026-09-08 15:52 ` [PATCH v2 4/4] hw/pci: Ensure PCIe link speed/width is consistent between both ends David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908155223.164787-3-david.vrabel@nutanix.com \
--to=david.vrabel@nutanix.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.