All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anders Roxell <anders.roxell@linaro.org>
To: u-boot@lists.u-boot-project.org
Cc: marek.vasut@mailbox.org, trini@konsulko.com,
	ilias.apalodimas@linaro.org, michal.simek@amd.com, lukma@denx.de,
	alchark@flipper.net, jerome.forissier@arm.com,
	dlechner@baylibre.com, anshuld@ti.com, sjg@chromium.org,
	Thinh.Nguyen@synopsys.com,
	Anders Roxell <anders.roxell@linaro.org>,
	Mattijs Korpershoek <mkorpershoek@kernel.org>
Subject: [PATCH v8 17/25] usb: gadget: atmel_usba_udc: set endpoint capabilities
Date: Wed,  9 Sep 2026 10:50:07 +0200	[thread overview]
Message-ID: <20260909085015.2480097-18-anders.roxell@linaro.org> (raw)
In-Reply-To: <20260909085015.2480097-1-anders.roxell@linaro.org>

usb_gadget_ep_match_desc() reads the caps field and compares the wanted
packet size against maxpacket_limit. atmel_usba_udc sets neither, it only
sets maxpacket, so no endpoint matches after the dwc3 resync re-imports
epautoconf.c. Same problem dwc2 had in commit c5c4cc4c6b98 ("usb: gadget:
dwc2: Set endpoint capabilities via .caps field").

Set the capabilities like the kernel driver does, and use
usb_ep_set_maxpacket_limit() for the fifo size, like commit 6f9c431a2062
("usb: gadget: dwc2: Use usb_ep_set_maxpacket_limit() for fifo sizes").

Compile tested only.

Suggested-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
Link: https://lore.kernel.org/u-boot/87v7az6l03.fsf@kernel.org/
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
 drivers/usb/gadget/atmel_usba_udc.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c
index 52900ad654cf..bcbfe5272d5f 100644
--- a/drivers/usb/gadget/atmel_usba_udc.c
+++ b/drivers/usb/gadget/atmel_usba_udc.c
@@ -1188,7 +1188,7 @@ static struct usba_ep *usba_udc_pdata(struct usba_platform_data *pdata,
 		ep->fifo = udc->fifo + USBA_FIFO_BASE(i);
 		ep->ep.ops = &usba_ep_ops;
 		ep->ep.name = pdata->ep[i].name;
-		ep->ep.maxpacket = pdata->ep[i].fifo_size;
+		usb_ep_set_maxpacket_limit(&ep->ep, pdata->ep[i].fifo_size);
 		ep->fifo_size = ep->ep.maxpacket;
 		ep->udc = udc;
 		INIT_LIST_HEAD(&ep->queue);
@@ -1196,6 +1196,16 @@ static struct usba_ep *usba_udc_pdata(struct usba_platform_data *pdata,
 		ep->index = pdata->ep[i].index;
 		ep->can_dma = pdata->ep[i].can_dma;
 		ep->can_isoc = pdata->ep[i].can_isoc;
+
+		if (i == 0) {
+			ep->ep.caps.type_control = 1;
+		} else {
+			ep->ep.caps.type_iso = ep->can_isoc;
+			ep->ep.caps.type_bulk = 1;
+			ep->ep.caps.type_int = 1;
+		}
+		ep->ep.caps.dir_in = 1;
+		ep->ep.caps.dir_out = 1;
 		if (i)
 			list_add_tail(&ep->ep.ep_list, &udc->gadget.ep_list);
 	};
-- 
2.53.0


  parent reply	other threads:[~2026-09-09 12:46 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09  8:49 [PATCH v8 00/25] usb: dwc3: part 2, make the resynced code work Anders Roxell
2026-09-09  8:49 ` [PATCH v8 01/25] dm: add helpers needed by the resynced DWC3 code Anders Roxell
2026-09-09  8:49 ` [PATCH v8 02/25] usb: phy: add the usb_phy " Anders Roxell
2026-09-09  8:49 ` [PATCH v8 03/25] usb: gadget: adapt the gadget API after the resync Anders Roxell
2026-09-09  8:49 ` [PATCH v8 04/25] usb: gadget: udc: make udc-core build in u-boot Anders Roxell
2026-09-09  8:49 ` [PATCH v8 05/25] usb: dwc3: make the core driver " Anders Roxell
2026-09-09  8:49 ` [PATCH v8 06/25] usb: dwc3: bring back the samsung usb phy driver Anders Roxell
2026-09-09  8:49 ` [PATCH v8 07/25] usb: dwc3: make gadget and ep0 build in u-boot Anders Roxell
2026-09-09  8:49 ` [PATCH v8 08/25] usb: gadget: udc: enable async callbacks on bind Anders Roxell
2026-09-09  8:49 ` [PATCH v8 09/25] usb: dwc3: ep0: flush and invalidate cache around ep0 transfers Anders Roxell
2026-09-09  8:50 ` [PATCH v8 10/25] usb: dwc3: gadget: flush and invalidate cache around transfers Anders Roxell
2026-09-09  8:50 ` [PATCH v8 11/25] usb: dwc3: make the am62 glue build in u-boot Anders Roxell
2026-09-09  8:50 ` [PATCH v8 12/25] usb: gadget: ci_udc: move to the udc-core registration Anders Roxell
2026-09-09  8:50 ` [PATCH v8 13/25] usb: gadget: ci_udc: set endpoint capabilities Anders Roxell
2026-09-09  8:50 ` [PATCH v8 14/25] usb: gadget: dwc2_udc_otg: fix up after the resync Anders Roxell
2026-09-09  8:50 ` [PATCH v8 15/25] usb: gadget: fix up the function drivers " Anders Roxell
2026-09-09  8:50 ` [PATCH v8 16/25] usb: gadget: fix up the last UDC " Anders Roxell
2026-09-09  8:50 ` Anders Roxell [this message]
2026-09-09  8:50 ` [PATCH v8 18/25] usb: gadget: at91_udc: register with udc-core Anders Roxell
2026-09-09  8:50 ` [PATCH v8 19/25] usb: gadget: at91_udc: set endpoint capabilities Anders Roxell
2026-09-09  8:50 ` [PATCH v8 20/25] usb: musb-new: fix up after the resync Anders Roxell
2026-09-09  8:50 ` [PATCH v8 21/25] usb: musb-new: set endpoint capabilities Anders Roxell
2026-09-09  8:50 ` [PATCH v8 22/25] usb: mtu3: fix up after the resync Anders Roxell
2026-09-09  8:50 ` [PATCH v8 23/25] usb: mtu3: set endpoint capabilities Anders Roxell
2026-09-09  8:50 ` [PATCH v8 24/25] usb: host: xhci: fix up after the resync Anders Roxell
2026-09-09  8:50 ` [PATCH v8 25/25] usb: cdns3: " Anders Roxell
2026-09-09 17:53 ` [PATCH v8 00/25] usb: dwc3: part 2, make the resynced code work Marek Vasut
2026-09-16 12:21   ` Anders Roxell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260909085015.2480097-18-anders.roxell@linaro.org \
    --to=anders.roxell@linaro.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=alchark@flipper.net \
    --cc=anshuld@ti.com \
    --cc=dlechner@baylibre.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jerome.forissier@arm.com \
    --cc=lukma@denx.de \
    --cc=marek.vasut@mailbox.org \
    --cc=michal.simek@amd.com \
    --cc=mkorpershoek@kernel.org \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.u-boot-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.