Re: [PATCH v4 15/20] drm/bridge: starfive: Add JH7110 HDMI controller driver

[sashiko-bot@kernel.org]

> Add the HDMI controller (bridge) driver for the StarFive JH7110.
> 
> This driver binds to the starfive,jh7110-inno-hdmi-controller node. It
> gets its register access, module and bus clocks from voutcrg, and
> consumes the pixel clock and the PHY from its hdmi_phy sibling.
> 
> The driver calls the generic inno_hdmi_probe function, which picks up
> the regmap shared with the PHY from the parent device and registers a
> DRM bridge. The .enable hook is responsible for setting the PHY's pixel
> clock rate via clk_set_rate() and powering on the PHY via
> phy_power_on().
> 
> The DC8200 has two panels, each exposing a DP and a DPI interface, and a
> mux in the video output system controller picks which of them drives the
> HDMI transmitter. It comes out of reset on panel 0 / DPI, which happens
> [ ... ]
> devm_drm_bridge_add(). Releasing them in .remove runs before devres
> unwinds and would leave the bridge registered with its clocks already
> gated.
> 
> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260915-jh7110-clean-send-v4-0-f0e4fd6f2cc8@samsung.com?part=15


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy