Re: [PATCH v2 4/4] arm64: dts: qcom: sa8775p: Add qref and refgen supply for PCIe PHYs - sashiko-bot

From: sashiko-bot@kernel.org
To: "Ziyue Zhang" <ziyue.zhang@oss.qualcomm.com>
Cc: olteanv@gmail.com, linux-phy@lists.infradead.org,
	robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org,
	neil.armstrong@linaro.org, vkoul@kernel.org
Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: sa8775p: Add qref and refgen supply for PCIe PHYs
Date: Wed, 16 Sep 2026 10:32:19 +0000	[thread overview]
Message-ID: <20260916103220.39B731F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260916102023.2054761-5-ziyue.zhang@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] dt: qcom: sa8775p: missing refgen-supply breaks PCIe PHY probe
--

commit 01fe676ff997cb09ae0eae172966d007c6ff8142
Author: Ziyue Zhang <ziyue.zhang@oss.qualcomm.com>

arm64: dts: qcom: sa8775p: Add qref and refgen supply for PCIe PHYs

This commit adds vdda-qref-supply and vdda-refgen-supply properties to the
PCIe PHY nodes in the SA8775p Lemans-EVK and Lemans-RIDE device trees. This
ensures stable operation and prevents occasional system crashes.

> diff --git a/arch/arm64/boot/dts/qcom/lemans-evk.dts b/arch/arm64/boot/dts/qcom/lemans-evk.dts
> index a45485b54a5b7..11fb11b161fc1 100644
> --- a/arch/arm64/boot/dts/qcom/lemans-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/lemans-evk.dts
> @@ -851,6 +851,8 @@ &pcie0 {
>  &pcie0_phy {
>  	vdda-phy-supply = <&vreg_l5a>;
>  	vdda-pll-supply = <&vreg_l1c>;
> +	vdda-qref-supply = <&vreg_l4a>;
> +	vdda-refgen-supply = <&vreg_l7a>;

[Severity: High]
Does this node also need a refgen-supply property?

Looking at the QMP PCIe PHY driver for SA8775p, sa8775p_qmp_phy_vreg_l mandates
5 regulators, including refgen:

drivers/phy/qualcomm/phy-qcom-qmp-pcie.c:
static const char * const sa8775p_qmp_phy_vreg_l[] = {
	"vdda-phy", "vdda-pll", "vdda-qref", "vdda-refgen", "refgen",
};

When qmp_pcie_vreg_init() calls devm_regulator_bulk_get(), it expects all
regulators in this array to be present. Without refgen-supply defined here (or
in the base PHY node pcie0_phy in lemans.dtsi), won't devm_regulator_bulk_get()
fail with -ENODEV and break the PCIe PHY probe deterministically at boot time?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916102023.2054761-1-ziyue.zhang@oss.qualcomm.com?part=4

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy