Re: [PATCH v2 2/4] phy: qcom: qmp-pcie: Add qref and refgen regulator vote for QCS8300 and SA8775p PHY

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] phy: qcom-qmp-pcie: probe failure on SA8775P due to missing refgen supply
--

commit 6ebdf3508e888642443e5fd08f439c12e51dcc9d
Author: Ziyue Zhang <ziyue.zhang@oss.qualcomm.com>

phy: qcom: qmp-pcie: Add qref and refgen regulator vote for QCS8300 and SA8775p PHY

Adds a new sa8775p_qmp_phy_vreg_l array that includes the refgen supply,
using it for QCS8300 and SA8775p PCIe PHY configurations to fix
initialization timeouts.

> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
> index da83358c97ead..ab81c6e584a84 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
> @@ -4094,6 +4094,10 @@ static const char * const sm8550_qmp_phy_vreg_l[] = {
>  	"vdda-phy", "vdda-pll", "vdda-qref",
>  };
>  
> +static const char * const sa8775p_qmp_phy_vreg_l[] = {
> +	"vdda-phy", "vdda-pll", "vdda-qref", "vdda-refgen", "refgen",
> +};
> +

[Severity: High]
Will this cause a probe failure on SA8775p platforms due to a missing
refgen supply?

The new sa8775p_qmp_phy_vreg_l array unconditionally includes the "refgen"
supply, but is applied to both QCS8300 and SA8775p PHY configurations.
Since the "refgen" supply requirement is a hardware workaround specific
only to QCS8300, the SA8775p device trees omit the "refgen-supply"
property.

When devm_regulator_bulk_get() is called for the SA8775p configuration,
it requires all listed supplies to be present in the device tree. If
"refgen-supply" is omitted on SA8775p, won't the regulator lookup return
-ENODEV and unconditionally abort the probe?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916102023.2054761-1-ziyue.zhang@oss.qualcomm.com?part=2

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy