Re: [PATCH 02/14] dt-bindings: media: add apple,avd

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] dt-bindings: mismatch in allowed item count between reg and reg-names
- [Low] dt-bindings: typo in description inverses meaning (never vs newer)
--

commit 0cb750cf8e5918140118aa807eaabfc530d2708d
Author: Sofus Forstreuter <sofus.c@icloud.com>

dt-bindings: media: add apple,avd

Document the Apple Video Decoder. A hardware video decoder present on
Apple hardware.

> diff --git a/Documentation/devicetree/bindings/media/apple,avd.yaml b/Documentation/devicetree/bindings/media/apple,avd.yaml
> new file mode 100644
> index 0000000000000..34a4129d6a46a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/apple,avd.yaml
[ ... ]
> +title: Apple Video Decoder (AVD)
> +
> +description: |
> +  AVD is a stateless video decode IP block present on Apple devices.
> +  Notably it includes an ARM Cortex-M3 and associated DMA controller.
> +  AVD is capable of decoding H264, H265, VP9 and AV1 on never SoCs.

[Severity: Low]
This isn't a bug, but there appears to be a typo in the description. 
Should this say newer SoCs instead of never SoCs?

> +
> +  The IP does not change much, with changes being mostly the CM3 having more
> +  memory and interrupts.
[ ... ]
> +  reg:
> +    minItems: 4
> +    items:
> +      - description: Cortex-M3 code (unsigned)
> +      - description: Cortex-M3 sram
> +      - description: Mailbox
> +      - description: Video decode control
> +      - description: DMA control
> +
> +  reg-names:
> +    items:
> +      - const: code
> +      - const: sram
> +      - const: mbox
> +      - const: ctrl

[Severity: Low]
Does this schema restrict reg-names too tightly?

The reg property allows up to 5 items (including DMA control as the 5th
item), but reg-names only defines 4 items. If a device tree node defines
the 5th register region, schema validation will fail because it cannot
specify a name for the 5th region.

Should a 5th const be added to reg-names to support the DMA control region?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918-avd-v1-0-49977931f455@icloud.com?part=2