Re: [PATCH 03/14] arm64: dts: apple: t8103: add avd nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: apple: t8103: avd nodes are not sorted by unit-address
--

commit 7d170c5397d0b0258ee0909282aba065f8ee4b9e
Author: Sofus Forstreuter <sofus.c@icloud.com>

arm64: dts: apple: t8103: add avd nodes
    
This commit adds the AVD (Apple Video Decoder) and its associated DART
IOMMU nodes to the t8103 device tree.

> --- a/arch/arm64/boot/dts/apple/t8103.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8103.dtsi
[ ... ]
> +		avd: avd@269080000 {
> +			compatible = "apple,t8103-avd";
> +			reg = <0x2 0x69080000 0x0 0xc000>,
> +			      <0x2 0x6908c000 0x0 0xc000>,
> +			      <0x2 0x69098000 0x0 0x4000>,
> +			      <0x2 0x69100000 0x0 0x10000>;
> +			reg-names = "code", "sram", "mbox", "ctrl";
> +			interrupt-parent = <&aic>;
> +			interrupts = <AIC_IRQ 540 IRQ_TYPE_LEVEL_HIGH>,
> +				     <AIC_IRQ 541 IRQ_TYPE_LEVEL_HIGH>;
> +			power-domains = <&ps_avd_sys>;
> +			resets = <&ps_avd_sys>;
> +			iommus = <&avd_dart 0>;
> +		};
> +
> +		avd_dart: iommu@269010000 {
> +			compatible = "apple,t8103-dart";

[Severity: Low]
This isn't a functional bug, but are these nodes sorted correctly by their
unit-address? 

Device tree nodes are typically sorted in ascending order by unit-address
to maintain readability. Should the avd_dart (iommu@269010000) node be
placed before the avd (avd@269080000) node in t8103.dtsi?

> +			reg = <0x2 0x69010000 0x0 0x4000>;
> +			#iommu-cells = <1>;
> +			interrupt-parent = <&aic>;
> +			interrupts = <AIC_IRQ 547 IRQ_TYPE_LEVEL_HIGH>;
> +			power-domains = <&ps_avd_sys>;
> +		};
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918-avd-v1-0-49977931f455@icloud.com?part=3