Re: [PATCH 04/14] arm64: dts: apple: t8112: add avd nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: incorrect node ordering for avd and avd_dart
--

commit 840ff1be86e16002d57c9c6bb1578c5e4806bc81
Author: Sofus Forstreuter <sofus.c@icloud.com>

arm64: dts: apple: t8112: add avd nodes

This commit adds the avd and avd_dart nodes to the t8112 device tree.
It configures their memory regions, interrupts, and power domains.

> diff --git a/arch/arm64/boot/dts/apple/t8112.dtsi b/arch/arm64/boot/dts/apple/t8112.dtsi
> index ec248ca052cb2..83b1bc27dad76 100644
> --- a/arch/arm64/boot/dts/apple/t8112.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8112.dtsi
[ ... ]
> @@ -987,6 +987,30 @@ pinctrl_aop: pinctrl@24a820000 {
>  				     <AIC_IRQ 307 IRQ_TYPE_LEVEL_HIGH>;
>  		};
>  
> +		avd: avd@269080000 {
> +			compatible = "apple,t8112-avd";
> +			reg = <0x2 0x69080000 0x0 0x10000>,
> +			      <0x2 0x69090000 0x0 0x10000>,
> +			      <0x2 0x690a0000 0x0 0x4000>,
> +			      <0x2 0x69100000 0x0 0x10000>;
> +			reg-names = "code", "sram", "mbox", "ctrl";
> +			interrupt-parent = <&aic>;
> +			interrupts = <AIC_IRQ 667 IRQ_TYPE_LEVEL_HIGH>,
> +				     <AIC_IRQ 668 IRQ_TYPE_LEVEL_HIGH>;
> +			power-domains = <&ps_avd_sys>;
> +			resets = <&ps_avd_sys>;
> +			iommus = <&avd_dart 0>;
> +		};
> +
> +		avd_dart: iommu@269010000 {

[Severity: Low]
Is this node ordering correct? Standard Device Tree conventions require
subnodes to be sorted in ascending order by their unit address.

The avd_dart node has a unit address of 269010000, which is placed after the
avd node with the larger unit address of 269080000. Could this trigger
stylistic warnings in DT validation tools?

> +			compatible = "apple,t8110-dart";
> +			reg = <0x2 0x69010000 0x0 0x4000>;
> +			#iommu-cells = <1>;
> +			interrupt-parent = <&aic>;
> +			interrupts = <AIC_IRQ 674 IRQ_TYPE_LEVEL_HIGH>;
> +			power-domains = <&ps_avd_sys>;
> +		};
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918-avd-v1-0-49977931f455@icloud.com?part=4