Re: [PATCH 01/14] media: v4l2: Add P210 pixel format

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Low] media: v4l2: incomplete UAPI documentation for P210 format
- [Low] media: v4l2: incorrect bits-per-pixel comment for V4L2_PIX_FMT_P210
- [Low] media: v4l2: reStructuredText underline too short for section title
--

commit babd80a26581f15a410f128ba302cfa3a34c05de
Author: Sofus Forstreuter <sofus.c@icloud.com>

media: v4l2: Add P210 pixel format

This commit adds support for the P210 pixel format. P210 is a YUV format
with 10-bits per component with interleaved UV.

> diff --git a/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst b/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst
> index 0631919bd667b..8509f2415c9b8 100644
> --- a/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst
> +++ b/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst
[ ... ]
> @@ -834,8 +841,9 @@ number of lines as the luma plane.
>  
>  .. _V4L2_PIX_FMT_P010:
>  .. _V4L2-PIX-FMT-P010-4L4:
> +.. _V4L2-PIX-FMT-P210:
>  
> -P010 and tiled P010
> +P010, tiled P010 and P210
>  -------------------

[Severity: Low]
Is this underline length still correct? The section title was extended to
include P210, but the underline remains 19 characters, which might cause a
Sphinx documentation build warning.

>  
>  P010 is like NV12 with 10 bits per component, expanded to 16 bits.

[Severity: Low]
Does this description need an update to cover P210? The section title now
includes P210, but the text exclusively describes the 4:2:0 layout of P010
without clarifying P210's 4:2:2 structure.

> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index 5373dba640fae..b5949c378f2eb 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
[ ... ]
> @@ -659,6 +659,7 @@ struct v4l2_pix_format {
>  #define V4L2_PIX_FMT_NV42    v4l2_fourcc('N', 'V', '4', '2') /* 24  Y/CrCb 4:4:4  */
>  #define V4L2_PIX_FMT_P010    v4l2_fourcc('P', '0', '1', '0') /* 24  Y/CbCr 4:2:0 10-bit per component */
>  #define V4L2_PIX_FMT_P012    v4l2_fourcc('P', '0', '1', '2') /* 24  Y/CbCr 4:2:0 12-bit per component */
> +#define V4L2_PIX_FMT_P210    v4l2_fourcc('P', '2', '1', '0') /* 24  Y/CbCr 4:2:2 10-bit per component */

[Severity: Low]
Is the bits-per-pixel comment accurate here? The comment states "24" average
bits per pixel, which is correct for 4:2:0 formats like P010, but shouldn't
a 4:2:2 format like P210 have an average of 32 bits per pixel?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918-avd-v1-0-49977931f455@icloud.com?part=1