Re: [PATCH RFC v3 02/12] dt-bindings: net: nxp,s32-dwmac: Document pcs-handle

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: redundant type definition in pcs-handle contradicts commit message
--

commit 83228aa7bd3f939d2363db1fc38174d3181bfd69
Author: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>

dt-bindings: net: nxp,s32-dwmac: Document pcs-handle

This commit documents the pcs-handle property for the S32 DWMAC when
routed to the embedded SerDes for SGMII. The commit message indicates
that the type is inherited from ethernet-controller.yaml and does not
need to be redefined.

> diff --git a/Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml b/Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml
> index 753a04941659b..b168decb540c6 100644
> --- a/Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml

[ ... ]

> @@ -81,6 +82,14 @@ properties:
>        - const: rx
>        - const: ptp_ref
>  
> +  pcs-handle:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +    maxItems: 1

[Severity: Medium]
The commit message states "The type already comes from the
ethernet-controller.yaml reference in the schema chain; this only records
the intent". 

Is it necessary to redefine the $ref to phandle-array and set maxItems to 1
here, or does this contradict the commit message's claim that the type
definition is omitted because it is already handled by the schema chain?

> +    description:
> +      phandle pointing to the SerDes XPCS lane child node that provides
> +      the SGMII PCS for this MAC. See
> +      Documentation/devicetree/bindings/phy/nxp,s32g-serdes.yaml.
> +
>  required:
>    - clocks
>    - clock-names

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260919-s32g_serdes-v3-0-9d68868c1e89@oss.nxp.com?part=2