Re: [PATCH v20 3/8] dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing 'compatible' in top-level required list
--

commit 4b70261c8ce41e64c7020f41bb3084f3d73d0e07
Author: Aman Kumar Pandey <aman.kumarpandey@nxp.com>
    
dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support
    
This patch adds device tree bindings for the NXP P3H2x4x multiport I3C hub
family. These devices connect to a host via I3C/I2C/SMBus and allow
communication with multiple downstream peripherals.

> diff --git a/Documentation/devicetree/bindings/i3c/nxp,p3h2840.yaml b/Documentation/devicetree/bindings/i3c/nxp,p3h2840.yaml
> new file mode 100644
> index 0000000000000..09508a7bcbeb6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i3c/nxp,p3h2840.yaml

[ ... ]

> +      ldo-tpg1:
> +        type: object
> +        $ref: /schemas/regulator/regulator.yaml#
> +        unevaluatedProperties: false
> +
> +required:
> +  - reg
> +  - '#address-cells'
> +  - '#size-cells'

[Severity: Low]
Should the top-level compatible property be included in this required list?

Standard device tree binding schemas expect the top-level compatible property
to be explicitly listed in the required array for standalone device nodes.
Although dt-schema matches the node by compatible string, omitting it from the
required list allows a node to theoretically pass validation without one if
referenced through other means.

> +
> +patternProperties:
> +  "^i3c@[0-7]$":
> +    type: object
> +    $ref: /schemas/i3c/i3c.yaml#

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922103551.2754613-1-lakshay.piplani@nxp.com?part=3

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c