Re: [PATCH v20 2/8] i3c: master: Add controller-only device operation helpers - sashiko-bot

From: sashiko-bot@kernel.org
To: "Lakshay Piplani" <lakshay.piplani@nxp.com>
Cc: linux-i3c@lists.infradead.org, robh@kernel.org,
	mfd@lists.linux.dev, Frank.Li@kernel.org, lee@kernel.org,
	devicetree@vger.kernel.org,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	conor+dt@kernel.org
Subject: Re: [PATCH v20 2/8] i3c: master: Add controller-only device operation helpers
Date: Tue, 22 Sep 2026 10:45:43 +0000	[thread overview]
Message-ID: <20260922104544.4A7391F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260922103551.2754613-3-lakshay.piplani@nxp.com>

> The generic I3C device attach and IBI paths perform both core-level
> bookkeeping and controller-specific operations. An I3C hub, however,
> maintains a logical device descriptor on the virtual downstream bus and
> a separate parent-facing descriptor used by the physical parent
> controller.
> 
> Add controller-only helpers that invoke the controller callbacks
> without updating the bus device list, address-slot state, or generic IBI
> lifecycle. This allows the hub framework to keep the logical descriptor
> associated with the virtual controller while using a permanent
> parent-facing descriptor for operations handled by the physical
> controller.
> 
> Add helpers for:
>   - attaching, reattaching, and detaching a device from a controller;
> [ ... ]
> individual controller drivers.
> 
> Signed-off-by: Lakshay Piplani <lakshay.piplani@nxp.com>
> Signed-off-by: Aman Kumar Pandey <aman.kumarpandey@nxp.com>
> Signed-off-by: Vikash Bansal <vikash.bansal@nxp.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922103551.2754613-1-lakshay.piplani@nxp.com?part=2