All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Lakshay Piplani" <lakshay.piplani@nxp.com>
Cc: Frank.Li@kernel.org, linux-i3c@lists.infradead.org,
	conor+dt@kernel.org, devicetree@vger.kernel.org, lee@kernel.org,
	robh@kernel.org, mfd@lists.linux.dev,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH v20 4/8] mfd: p3h2x4x: Add driver for NXP P3H2x4x i3c hub and on-die regulator
Date: Tue, 22 Sep 2026 10:50:19 +0000	[thread overview]
Message-ID: <20260922105019.685311F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260922103551.2754613-5-lakshay.piplani@nxp.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] mfd: driver-specific header incorrectly placed in global include/linux/mfd/
--

commit ee0020c355157050632a39b51c33798536ac333a
Author: Aman Kumar Pandey <aman.kumarpandey@nxp.com>

    mfd: p3h2x4x: Add driver for NXP P3H2x4x i3c hub and on-die regulator

This commit adds core MFD support for the NXP P3H2x4x family of multiport I3C
hub devices. The devices connect to a host via I3C/I2C/SMBus and expose
multiple downstream target ports.

> diff --git a/include/linux/mfd/p3h2840.h b/include/linux/mfd/p3h2840.h
> new file mode 100644
> index 0000000000000..eb4792de5440e
> --- /dev/null
> +++ b/include/linux/mfd/p3h2840.h
> @@ -0,0 +1,41 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright 2025-2026 NXP
> + */
> +
> +#ifndef _LINUX_MFD_P3H2840_H
> +#define _LINUX_MFD_P3H2840_H

[Severity: Low]
Could this newly introduced driver-specific header be moved to the local
drivers/mfd/ directory instead of being placed in the global
include/linux/mfd/ space?

The MFD subsystem guidelines specify that driver-specific headers containing
private structures like struct p3h2x4x should not be placed in the global
include/linux/mfd/ directory if they are only used by the parent and its
immediate children.

Placing it here causes a layering violation and introduces tight coupling by
polluting the global include space at compile time.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922103551.2754613-1-lakshay.piplani@nxp.com?part=4

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Lakshay Piplani" <lakshay.piplani@nxp.com>
Cc: Frank.Li@kernel.org, linux-i3c@lists.infradead.org,
	conor+dt@kernel.org, devicetree@vger.kernel.org, lee@kernel.org,
	robh@kernel.org, mfd@lists.linux.dev,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH v20 4/8] mfd: p3h2x4x: Add driver for NXP P3H2x4x i3c hub and on-die regulator
Date: Tue, 22 Sep 2026 10:50:19 +0000	[thread overview]
Message-ID: <20260922105019.685311F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260922103551.2754613-5-lakshay.piplani@nxp.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] mfd: driver-specific header incorrectly placed in global include/linux/mfd/
--

commit ee0020c355157050632a39b51c33798536ac333a
Author: Aman Kumar Pandey <aman.kumarpandey@nxp.com>

    mfd: p3h2x4x: Add driver for NXP P3H2x4x i3c hub and on-die regulator

This commit adds core MFD support for the NXP P3H2x4x family of multiport I3C
hub devices. The devices connect to a host via I3C/I2C/SMBus and expose
multiple downstream target ports.

> diff --git a/include/linux/mfd/p3h2840.h b/include/linux/mfd/p3h2840.h
> new file mode 100644
> index 0000000000000..eb4792de5440e
> --- /dev/null
> +++ b/include/linux/mfd/p3h2840.h
> @@ -0,0 +1,41 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright 2025-2026 NXP
> + */
> +
> +#ifndef _LINUX_MFD_P3H2840_H
> +#define _LINUX_MFD_P3H2840_H

[Severity: Low]
Could this newly introduced driver-specific header be moved to the local
drivers/mfd/ directory instead of being placed in the global
include/linux/mfd/ space?

The MFD subsystem guidelines specify that driver-specific headers containing
private structures like struct p3h2x4x should not be placed in the global
include/linux/mfd/ directory if they are only used by the parent and its
immediate children.

Placing it here causes a layering violation and introduces tight coupling by
polluting the global include space at compile time.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922103551.2754613-1-lakshay.piplani@nxp.com?part=4

  reply	other threads:[~2026-09-22 10:50 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22 10:35 [PATCH v20 0/8] Add support for NXP P3H2x4x I3C hub driver Lakshay Piplani
2026-09-22 10:35 ` Lakshay Piplani
2026-09-22 10:35 ` [PATCH v20 1/8] i3c: master: Add APIs for I3C hub support Lakshay Piplani
2026-09-22 10:35   ` Lakshay Piplani
2026-09-22 10:48   ` sashiko-bot
2026-09-22 10:48     ` sashiko-bot
2026-09-22 10:35 ` [PATCH v20 2/8] i3c: master: Add controller-only device operation helpers Lakshay Piplani
2026-09-22 10:35   ` Lakshay Piplani
2026-09-22 10:45   ` sashiko-bot
2026-09-22 10:45     ` sashiko-bot
2026-09-22 10:35 ` [PATCH v20 3/8] dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support Lakshay Piplani
2026-09-22 10:35   ` Lakshay Piplani
2026-09-22 10:44   ` sashiko-bot
2026-09-22 10:44     ` sashiko-bot
2026-09-22 10:35 ` [PATCH v20 4/8] mfd: p3h2x4x: Add driver for NXP P3H2x4x i3c hub and on-die regulator Lakshay Piplani
2026-09-22 10:35   ` Lakshay Piplani
2026-09-22 10:50   ` sashiko-bot [this message]
2026-09-22 10:50     ` sashiko-bot
2026-09-22 10:35 ` [PATCH v20 5/8] regulator: p3h2x4x: Add driver for on-die regulators in NXP P3H2x4x i3c hub Lakshay Piplani
2026-09-22 10:35   ` Lakshay Piplani
2026-09-22 10:47   ` sashiko-bot
2026-09-22 10:47     ` sashiko-bot
2026-09-22 10:35 ` [PATCH v20 6/8] i3c: hub: Add support for the I3C interface in the I3C hub Lakshay Piplani
2026-09-22 10:35   ` Lakshay Piplani
2026-09-22 10:53   ` sashiko-bot
2026-09-22 10:53     ` sashiko-bot
2026-09-22 10:35 ` [PATCH v20 7/8] i3c: hub: p3h2x4x: Add support for NXP P3H2x4x I3C hub functionality Lakshay Piplani
2026-09-22 10:35   ` Lakshay Piplani
2026-09-22 10:55   ` sashiko-bot
2026-09-22 10:55     ` sashiko-bot
2026-09-22 10:35 ` [PATCH v20 8/8] i3c: hub: p3h2x4x: Add SMBus slave mode support Lakshay Piplani
2026-09-22 10:35   ` Lakshay Piplani
2026-09-22 10:55   ` sashiko-bot
2026-09-22 10:55     ` sashiko-bot
2026-09-30 14:23 ` (subset) [PATCH v20 0/8] Add support for NXP P3H2x4x I3C hub driver Alexandre Belloni
2026-09-30 14:23   ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260922105019.685311F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lakshay.piplani@nxp.com \
    --cc=lee@kernel.org \
    --cc=linux-i3c@lists.infradead.org \
    --cc=mfd@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.