* [PATCH] serial: arc_uart: Use platform IRQ helper
@ 2026-09-25 18:30 ` Rosen Penev
0 siblings, 0 replies; 11+ messages in thread
From: Rosen Penev @ 2026-09-25 18:30 UTC (permalink / raw)
To: linux-serial
Cc: Vineet Gupta, Greg Kroah-Hartman, Jiri Slaby,
open list:SYNOPSYS ARC ARCHITECTURE,
open list:TTY LAYER AND SERIAL DRIVERS
Avoid calling irq_dispose_mapping() by letting the platform_device
machinery handle it. Also enable possibility of handling -EPROBE_DEFER
and other errors. Handle as early as possible to avoid doing unnecessary
work.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/tty/serial/arc_uart.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
index 3988e5958896..b46b057a181b 100644
--- a/drivers/tty/serial/arc_uart.c
+++ b/drivers/tty/serial/arc_uart.c
@@ -30,7 +30,6 @@
#include <linux/tty_flip.h>
#include <linux/serial_core.h>
#include <linux/io.h>
-#include <linux/of_irq.h>
#include <linux/of_address.h>
/*************************************
@@ -571,12 +570,17 @@ static int arc_serial_probe(struct platform_device *pdev)
struct arc_uart_port *uart;
struct uart_port *port;
int dev_id;
+ int irq;
u32 val;
/* no device tree device */
if (!np)
return -ENODEV;
+ irq = platform_get_irq(pdev, 0);
+ if (irq < 0)
+ return irq;
+
dev_id = of_alias_get_id(np, "serial");
if (dev_id < 0)
dev_id = 0;
@@ -607,7 +611,7 @@ static int arc_serial_probe(struct platform_device *pdev)
return PTR_ERR(port->membase);
}
- port->irq = irq_of_parse_and_map(np, 0);
+ port->irq = irq;
port->dev = &pdev->dev;
port->iotype = UPIO_MEM;
--
2.55.0
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH] serial: arc_uart: Use platform IRQ helper
@ 2026-09-25 18:30 ` Rosen Penev
0 siblings, 0 replies; 11+ messages in thread
From: Rosen Penev @ 2026-09-25 18:30 UTC (permalink / raw)
To: linux-serial
Cc: Vineet Gupta, Greg Kroah-Hartman, Jiri Slaby,
open list:SYNOPSYS ARC ARCHITECTURE,
open list:TTY LAYER AND SERIAL DRIVERS
Avoid calling irq_dispose_mapping() by letting the platform_device
machinery handle it. Also enable possibility of handling -EPROBE_DEFER
and other errors. Handle as early as possible to avoid doing unnecessary
work.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/tty/serial/arc_uart.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
index 3988e5958896..b46b057a181b 100644
--- a/drivers/tty/serial/arc_uart.c
+++ b/drivers/tty/serial/arc_uart.c
@@ -30,7 +30,6 @@
#include <linux/tty_flip.h>
#include <linux/serial_core.h>
#include <linux/io.h>
-#include <linux/of_irq.h>
#include <linux/of_address.h>
/*************************************
@@ -571,12 +570,17 @@ static int arc_serial_probe(struct platform_device *pdev)
struct arc_uart_port *uart;
struct uart_port *port;
int dev_id;
+ int irq;
u32 val;
/* no device tree device */
if (!np)
return -ENODEV;
+ irq = platform_get_irq(pdev, 0);
+ if (irq < 0)
+ return irq;
+
dev_id = of_alias_get_id(np, "serial");
if (dev_id < 0)
dev_id = 0;
@@ -607,7 +611,7 @@ static int arc_serial_probe(struct platform_device *pdev)
return PTR_ERR(port->membase);
}
- port->irq = irq_of_parse_and_map(np, 0);
+ port->irq = irq;
port->dev = &pdev->dev;
port->iotype = UPIO_MEM;
--
2.55.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] serial: arc_uart: Use platform IRQ helper
2026-09-25 18:30 ` Rosen Penev
(?)
@ 2026-09-25 18:38 ` sashiko-bot
-1 siblings, 0 replies; 11+ messages in thread
From: sashiko-bot @ 2026-09-25 18:38 UTC (permalink / raw)
To: Rosen Penev; +Cc: linux-serial
> Avoid calling irq_dispose_mapping() by letting the platform_device
> machinery handle it. Also enable possibility of handling -EPROBE_DEFER
> and other errors. Handle as early as possible to avoid doing unnecessary
> work.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260925183050.56839-1-rosenp@gmail.com?part=1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] serial: arc_uart: Use platform IRQ helper
2026-09-25 18:30 ` Rosen Penev
@ 2026-10-01 8:42 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 11+ messages in thread
From: Greg Kroah-Hartman @ 2026-10-01 8:42 UTC (permalink / raw)
To: Rosen Penev
Cc: linux-serial, Vineet Gupta, Jiri Slaby,
open list:SYNOPSYS ARC ARCHITECTURE,
open list:TTY LAYER AND SERIAL DRIVERS
On Fri, Sep 25, 2026 at 11:30:50AM -0700, Rosen Penev wrote:
> Avoid calling irq_dispose_mapping() by letting the platform_device
> machinery handle it. Also enable possibility of handling -EPROBE_DEFER
> and other errors. Handle as early as possible to avoid doing unnecessary
> work.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> drivers/tty/serial/arc_uart.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
> index 3988e5958896..b46b057a181b 100644
> --- a/drivers/tty/serial/arc_uart.c
> +++ b/drivers/tty/serial/arc_uart.c
> @@ -30,7 +30,6 @@
> #include <linux/tty_flip.h>
> #include <linux/serial_core.h>
> #include <linux/io.h>
> -#include <linux/of_irq.h>
> #include <linux/of_address.h>
>
> /*************************************
> @@ -571,12 +570,17 @@ static int arc_serial_probe(struct platform_device *pdev)
> struct arc_uart_port *uart;
> struct uart_port *port;
> int dev_id;
> + int irq;
> u32 val;
>
> /* no device tree device */
> if (!np)
> return -ENODEV;
>
> + irq = platform_get_irq(pdev, 0);
> + if (irq < 0)
> + return irq;
> +
> dev_id = of_alias_get_id(np, "serial");
> if (dev_id < 0)
> dev_id = 0;
> @@ -607,7 +611,7 @@ static int arc_serial_probe(struct platform_device *pdev)
> return PTR_ERR(port->membase);
> }
>
> - port->irq = irq_of_parse_and_map(np, 0);
> + port->irq = irq;
>
> port->dev = &pdev->dev;
> port->iotype = UPIO_MEM;
> --
> 2.55.0
>
>
You forgot an Assisted-by: tag here :(
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] serial: arc_uart: Use platform IRQ helper
@ 2026-10-01 8:42 ` Greg Kroah-Hartman
0 siblings, 0 replies; 11+ messages in thread
From: Greg Kroah-Hartman @ 2026-10-01 8:42 UTC (permalink / raw)
To: Rosen Penev
Cc: linux-serial, Vineet Gupta, Jiri Slaby,
open list:SYNOPSYS ARC ARCHITECTURE,
open list:TTY LAYER AND SERIAL DRIVERS
On Fri, Sep 25, 2026 at 11:30:50AM -0700, Rosen Penev wrote:
> Avoid calling irq_dispose_mapping() by letting the platform_device
> machinery handle it. Also enable possibility of handling -EPROBE_DEFER
> and other errors. Handle as early as possible to avoid doing unnecessary
> work.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> drivers/tty/serial/arc_uart.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
> index 3988e5958896..b46b057a181b 100644
> --- a/drivers/tty/serial/arc_uart.c
> +++ b/drivers/tty/serial/arc_uart.c
> @@ -30,7 +30,6 @@
> #include <linux/tty_flip.h>
> #include <linux/serial_core.h>
> #include <linux/io.h>
> -#include <linux/of_irq.h>
> #include <linux/of_address.h>
>
> /*************************************
> @@ -571,12 +570,17 @@ static int arc_serial_probe(struct platform_device *pdev)
> struct arc_uart_port *uart;
> struct uart_port *port;
> int dev_id;
> + int irq;
> u32 val;
>
> /* no device tree device */
> if (!np)
> return -ENODEV;
>
> + irq = platform_get_irq(pdev, 0);
> + if (irq < 0)
> + return irq;
> +
> dev_id = of_alias_get_id(np, "serial");
> if (dev_id < 0)
> dev_id = 0;
> @@ -607,7 +611,7 @@ static int arc_serial_probe(struct platform_device *pdev)
> return PTR_ERR(port->membase);
> }
>
> - port->irq = irq_of_parse_and_map(np, 0);
> + port->irq = irq;
>
> port->dev = &pdev->dev;
> port->iotype = UPIO_MEM;
> --
> 2.55.0
>
>
You forgot an Assisted-by: tag here :(
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] serial: arc_uart: Use platform IRQ helper
2026-10-01 8:42 ` Greg Kroah-Hartman
@ 2026-10-01 18:58 ` Rosen Penev
-1 siblings, 0 replies; 11+ messages in thread
From: Rosen Penev @ 2026-10-01 18:58 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-serial, Vineet Gupta, Jiri Slaby,
open list:SYNOPSYS ARC ARCHITECTURE,
open list:TTY LAYER AND SERIAL DRIVERS
On Thu, Oct 1, 2026 at 1:42 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Fri, Sep 25, 2026 at 11:30:50AM -0700, Rosen Penev wrote:
> > Avoid calling irq_dispose_mapping() by letting the platform_device
> > machinery handle it. Also enable possibility of handling -EPROBE_DEFER
> > and other errors. Handle as early as possible to avoid doing unnecessary
> > work.
> >
> > Signed-off-by: Rosen Penev <rosenp@gmail.com>
> > ---
> > drivers/tty/serial/arc_uart.c | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
> > index 3988e5958896..b46b057a181b 100644
> > --- a/drivers/tty/serial/arc_uart.c
> > +++ b/drivers/tty/serial/arc_uart.c
> > @@ -30,7 +30,6 @@
> > #include <linux/tty_flip.h>
> > #include <linux/serial_core.h>
> > #include <linux/io.h>
> > -#include <linux/of_irq.h>
> > #include <linux/of_address.h>
> >
> > /*************************************
> > @@ -571,12 +570,17 @@ static int arc_serial_probe(struct platform_device *pdev)
> > struct arc_uart_port *uart;
> > struct uart_port *port;
> > int dev_id;
> > + int irq;
> > u32 val;
> >
> > /* no device tree device */
> > if (!np)
> > return -ENODEV;
> >
> > + irq = platform_get_irq(pdev, 0);
> > + if (irq < 0)
> > + return irq;
> > +
> > dev_id = of_alias_get_id(np, "serial");
> > if (dev_id < 0)
> > dev_id = 0;
> > @@ -607,7 +611,7 @@ static int arc_serial_probe(struct platform_device *pdev)
> > return PTR_ERR(port->membase);
> > }
> >
> > - port->irq = irq_of_parse_and_map(np, 0);
> > + port->irq = irq;
> >
> > port->dev = &pdev->dev;
> > port->iotype = UPIO_MEM;
> > --
> > 2.55.0
> >
> >
>
> You forgot an Assisted-by: tag here :(
No LLM used here.
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] serial: arc_uart: Use platform IRQ helper
@ 2026-10-01 18:58 ` Rosen Penev
0 siblings, 0 replies; 11+ messages in thread
From: Rosen Penev @ 2026-10-01 18:58 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-serial, Vineet Gupta, Jiri Slaby,
open list:SYNOPSYS ARC ARCHITECTURE,
open list:TTY LAYER AND SERIAL DRIVERS
On Thu, Oct 1, 2026 at 1:42 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Fri, Sep 25, 2026 at 11:30:50AM -0700, Rosen Penev wrote:
> > Avoid calling irq_dispose_mapping() by letting the platform_device
> > machinery handle it. Also enable possibility of handling -EPROBE_DEFER
> > and other errors. Handle as early as possible to avoid doing unnecessary
> > work.
> >
> > Signed-off-by: Rosen Penev <rosenp@gmail.com>
> > ---
> > drivers/tty/serial/arc_uart.c | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
> > index 3988e5958896..b46b057a181b 100644
> > --- a/drivers/tty/serial/arc_uart.c
> > +++ b/drivers/tty/serial/arc_uart.c
> > @@ -30,7 +30,6 @@
> > #include <linux/tty_flip.h>
> > #include <linux/serial_core.h>
> > #include <linux/io.h>
> > -#include <linux/of_irq.h>
> > #include <linux/of_address.h>
> >
> > /*************************************
> > @@ -571,12 +570,17 @@ static int arc_serial_probe(struct platform_device *pdev)
> > struct arc_uart_port *uart;
> > struct uart_port *port;
> > int dev_id;
> > + int irq;
> > u32 val;
> >
> > /* no device tree device */
> > if (!np)
> > return -ENODEV;
> >
> > + irq = platform_get_irq(pdev, 0);
> > + if (irq < 0)
> > + return irq;
> > +
> > dev_id = of_alias_get_id(np, "serial");
> > if (dev_id < 0)
> > dev_id = 0;
> > @@ -607,7 +611,7 @@ static int arc_serial_probe(struct platform_device *pdev)
> > return PTR_ERR(port->membase);
> > }
> >
> > - port->irq = irq_of_parse_and_map(np, 0);
> > + port->irq = irq;
> >
> > port->dev = &pdev->dev;
> > port->iotype = UPIO_MEM;
> > --
> > 2.55.0
> >
> >
>
> You forgot an Assisted-by: tag here :(
No LLM used here.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] serial: arc_uart: Use platform IRQ helper
2026-10-01 18:58 ` Rosen Penev
@ 2026-10-02 5:55 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 11+ messages in thread
From: Greg Kroah-Hartman @ 2026-10-02 5:55 UTC (permalink / raw)
To: Rosen Penev
Cc: linux-serial, Vineet Gupta, Jiri Slaby,
open list:SYNOPSYS ARC ARCHITECTURE,
open list:TTY LAYER AND SERIAL DRIVERS
On Thu, Oct 01, 2026 at 11:58:05AM -0700, Rosen Penev wrote:
> On Thu, Oct 1, 2026 at 1:42 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Fri, Sep 25, 2026 at 11:30:50AM -0700, Rosen Penev wrote:
> > > Avoid calling irq_dispose_mapping() by letting the platform_device
> > > machinery handle it. Also enable possibility of handling -EPROBE_DEFER
> > > and other errors. Handle as early as possible to avoid doing unnecessary
> > > work.
> > >
> > > Signed-off-by: Rosen Penev <rosenp@gmail.com>
> > > ---
> > > drivers/tty/serial/arc_uart.c | 8 ++++++--
> > > 1 file changed, 6 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
> > > index 3988e5958896..b46b057a181b 100644
> > > --- a/drivers/tty/serial/arc_uart.c
> > > +++ b/drivers/tty/serial/arc_uart.c
> > > @@ -30,7 +30,6 @@
> > > #include <linux/tty_flip.h>
> > > #include <linux/serial_core.h>
> > > #include <linux/io.h>
> > > -#include <linux/of_irq.h>
> > > #include <linux/of_address.h>
> > >
> > > /*************************************
> > > @@ -571,12 +570,17 @@ static int arc_serial_probe(struct platform_device *pdev)
> > > struct arc_uart_port *uart;
> > > struct uart_port *port;
> > > int dev_id;
> > > + int irq;
> > > u32 val;
> > >
> > > /* no device tree device */
> > > if (!np)
> > > return -ENODEV;
> > >
> > > + irq = platform_get_irq(pdev, 0);
> > > + if (irq < 0)
> > > + return irq;
> > > +
> > > dev_id = of_alias_get_id(np, "serial");
> > > if (dev_id < 0)
> > > dev_id = 0;
> > > @@ -607,7 +611,7 @@ static int arc_serial_probe(struct platform_device *pdev)
> > > return PTR_ERR(port->membase);
> > > }
> > >
> > > - port->irq = irq_of_parse_and_map(np, 0);
> > > + port->irq = irq;
> > >
> > > port->dev = &pdev->dev;
> > > port->iotype = UPIO_MEM;
> > > --
> > > 2.55.0
> > >
> > >
> >
> > You forgot an Assisted-by: tag here :(
> No LLM used here.
Then what tool was used to find this issue?
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] serial: arc_uart: Use platform IRQ helper
@ 2026-10-02 5:55 ` Greg Kroah-Hartman
0 siblings, 0 replies; 11+ messages in thread
From: Greg Kroah-Hartman @ 2026-10-02 5:55 UTC (permalink / raw)
To: Rosen Penev
Cc: linux-serial, Vineet Gupta, Jiri Slaby,
open list:SYNOPSYS ARC ARCHITECTURE,
open list:TTY LAYER AND SERIAL DRIVERS
On Thu, Oct 01, 2026 at 11:58:05AM -0700, Rosen Penev wrote:
> On Thu, Oct 1, 2026 at 1:42 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Fri, Sep 25, 2026 at 11:30:50AM -0700, Rosen Penev wrote:
> > > Avoid calling irq_dispose_mapping() by letting the platform_device
> > > machinery handle it. Also enable possibility of handling -EPROBE_DEFER
> > > and other errors. Handle as early as possible to avoid doing unnecessary
> > > work.
> > >
> > > Signed-off-by: Rosen Penev <rosenp@gmail.com>
> > > ---
> > > drivers/tty/serial/arc_uart.c | 8 ++++++--
> > > 1 file changed, 6 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
> > > index 3988e5958896..b46b057a181b 100644
> > > --- a/drivers/tty/serial/arc_uart.c
> > > +++ b/drivers/tty/serial/arc_uart.c
> > > @@ -30,7 +30,6 @@
> > > #include <linux/tty_flip.h>
> > > #include <linux/serial_core.h>
> > > #include <linux/io.h>
> > > -#include <linux/of_irq.h>
> > > #include <linux/of_address.h>
> > >
> > > /*************************************
> > > @@ -571,12 +570,17 @@ static int arc_serial_probe(struct platform_device *pdev)
> > > struct arc_uart_port *uart;
> > > struct uart_port *port;
> > > int dev_id;
> > > + int irq;
> > > u32 val;
> > >
> > > /* no device tree device */
> > > if (!np)
> > > return -ENODEV;
> > >
> > > + irq = platform_get_irq(pdev, 0);
> > > + if (irq < 0)
> > > + return irq;
> > > +
> > > dev_id = of_alias_get_id(np, "serial");
> > > if (dev_id < 0)
> > > dev_id = 0;
> > > @@ -607,7 +611,7 @@ static int arc_serial_probe(struct platform_device *pdev)
> > > return PTR_ERR(port->membase);
> > > }
> > >
> > > - port->irq = irq_of_parse_and_map(np, 0);
> > > + port->irq = irq;
> > >
> > > port->dev = &pdev->dev;
> > > port->iotype = UPIO_MEM;
> > > --
> > > 2.55.0
> > >
> > >
> >
> > You forgot an Assisted-by: tag here :(
> No LLM used here.
Then what tool was used to find this issue?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] serial: arc_uart: Use platform IRQ helper
2026-10-02 5:55 ` Greg Kroah-Hartman
@ 2026-10-02 7:25 ` Rosen Penev
-1 siblings, 0 replies; 11+ messages in thread
From: Rosen Penev @ 2026-10-02 7:25 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-serial, Vineet Gupta, Jiri Slaby,
open list:SYNOPSYS ARC ARCHITECTURE,
open list:TTY LAYER AND SERIAL DRIVERS
On Thu, Oct 1, 2026 at 10:55 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Thu, Oct 01, 2026 at 11:58:05AM -0700, Rosen Penev wrote:
> > On Thu, Oct 1, 2026 at 1:42 AM Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Fri, Sep 25, 2026 at 11:30:50AM -0700, Rosen Penev wrote:
> > > > Avoid calling irq_dispose_mapping() by letting the platform_device
> > > > machinery handle it. Also enable possibility of handling -EPROBE_DEFER
> > > > and other errors. Handle as early as possible to avoid doing unnecessary
> > > > work.
> > > >
> > > > Signed-off-by: Rosen Penev <rosenp@gmail.com>
> > > > ---
> > > > drivers/tty/serial/arc_uart.c | 8 ++++++--
> > > > 1 file changed, 6 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
> > > > index 3988e5958896..b46b057a181b 100644
> > > > --- a/drivers/tty/serial/arc_uart.c
> > > > +++ b/drivers/tty/serial/arc_uart.c
> > > > @@ -30,7 +30,6 @@
> > > > #include <linux/tty_flip.h>
> > > > #include <linux/serial_core.h>
> > > > #include <linux/io.h>
> > > > -#include <linux/of_irq.h>
> > > > #include <linux/of_address.h>
> > > >
> > > > /*************************************
> > > > @@ -571,12 +570,17 @@ static int arc_serial_probe(struct platform_device *pdev)
> > > > struct arc_uart_port *uart;
> > > > struct uart_port *port;
> > > > int dev_id;
> > > > + int irq;
> > > > u32 val;
> > > >
> > > > /* no device tree device */
> > > > if (!np)
> > > > return -ENODEV;
> > > >
> > > > + irq = platform_get_irq(pdev, 0);
> > > > + if (irq < 0)
> > > > + return irq;
> > > > +
> > > > dev_id = of_alias_get_id(np, "serial");
> > > > if (dev_id < 0)
> > > > dev_id = 0;
> > > > @@ -607,7 +611,7 @@ static int arc_serial_probe(struct platform_device *pdev)
> > > > return PTR_ERR(port->membase);
> > > > }
> > > >
> > > > - port->irq = irq_of_parse_and_map(np, 0);
> > > > + port->irq = irq;
> > > >
> > > > port->dev = &pdev->dev;
> > > > port->iotype = UPIO_MEM;
> > > > --
> > > > 2.55.0
> > > >
> > > >
> > >
> > > You forgot an Assisted-by: tag here :(
> > No LLM used here.
>
> Then what tool was used to find this issue?
git grep irq_of_parse_and_map
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] serial: arc_uart: Use platform IRQ helper
@ 2026-10-02 7:25 ` Rosen Penev
0 siblings, 0 replies; 11+ messages in thread
From: Rosen Penev @ 2026-10-02 7:25 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-serial, Vineet Gupta, Jiri Slaby,
open list:SYNOPSYS ARC ARCHITECTURE,
open list:TTY LAYER AND SERIAL DRIVERS
On Thu, Oct 1, 2026 at 10:55 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Thu, Oct 01, 2026 at 11:58:05AM -0700, Rosen Penev wrote:
> > On Thu, Oct 1, 2026 at 1:42 AM Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Fri, Sep 25, 2026 at 11:30:50AM -0700, Rosen Penev wrote:
> > > > Avoid calling irq_dispose_mapping() by letting the platform_device
> > > > machinery handle it. Also enable possibility of handling -EPROBE_DEFER
> > > > and other errors. Handle as early as possible to avoid doing unnecessary
> > > > work.
> > > >
> > > > Signed-off-by: Rosen Penev <rosenp@gmail.com>
> > > > ---
> > > > drivers/tty/serial/arc_uart.c | 8 ++++++--
> > > > 1 file changed, 6 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
> > > > index 3988e5958896..b46b057a181b 100644
> > > > --- a/drivers/tty/serial/arc_uart.c
> > > > +++ b/drivers/tty/serial/arc_uart.c
> > > > @@ -30,7 +30,6 @@
> > > > #include <linux/tty_flip.h>
> > > > #include <linux/serial_core.h>
> > > > #include <linux/io.h>
> > > > -#include <linux/of_irq.h>
> > > > #include <linux/of_address.h>
> > > >
> > > > /*************************************
> > > > @@ -571,12 +570,17 @@ static int arc_serial_probe(struct platform_device *pdev)
> > > > struct arc_uart_port *uart;
> > > > struct uart_port *port;
> > > > int dev_id;
> > > > + int irq;
> > > > u32 val;
> > > >
> > > > /* no device tree device */
> > > > if (!np)
> > > > return -ENODEV;
> > > >
> > > > + irq = platform_get_irq(pdev, 0);
> > > > + if (irq < 0)
> > > > + return irq;
> > > > +
> > > > dev_id = of_alias_get_id(np, "serial");
> > > > if (dev_id < 0)
> > > > dev_id = 0;
> > > > @@ -607,7 +611,7 @@ static int arc_serial_probe(struct platform_device *pdev)
> > > > return PTR_ERR(port->membase);
> > > > }
> > > >
> > > > - port->irq = irq_of_parse_and_map(np, 0);
> > > > + port->irq = irq;
> > > >
> > > > port->dev = &pdev->dev;
> > > > port->iotype = UPIO_MEM;
> > > > --
> > > > 2.55.0
> > > >
> > > >
> > >
> > > You forgot an Assisted-by: tag here :(
> > No LLM used here.
>
> Then what tool was used to find this issue?
git grep irq_of_parse_and_map
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2026-10-02 7:25 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-25 18:30 [PATCH] serial: arc_uart: Use platform IRQ helper Rosen Penev
2026-09-25 18:30 ` Rosen Penev
2026-09-25 18:38 ` sashiko-bot
2026-10-01 8:42 ` Greg Kroah-Hartman
2026-10-01 8:42 ` Greg Kroah-Hartman
2026-10-01 18:58 ` Rosen Penev
2026-10-01 18:58 ` Rosen Penev
2026-10-02 5:55 ` Greg Kroah-Hartman
2026-10-02 5:55 ` Greg Kroah-Hartman
2026-10-02 7:25 ` Rosen Penev
2026-10-02 7:25 ` Rosen Penev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.